mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Keith Chew" <keith.chew@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Subject: network tx_timeout guidance
Date: Thu, 20 Jul 2006 08:53:28 +1200	[thread overview]
Message-ID: <20f65d530607191353p734e9392g1283dae9a7b14b1a@mail.gmail.com> (raw)

Hi

We are stress testing a wireless network driver from a vendor (ZD1211
chip, we realise that there is a rewrite project happenning but that
it still not ready for production yet).

So far, everything is going very well except after several days when a
Tx Timeout occurs. In this scenario, the driver goes into a tight
loop, and we keep getting the Tx Timeout. I have already contacted the
vendor, but just wanted additional opinion/feedback from the experts
at LKML.

In the code, this is the callback from the assignment:
============================
#define	ZD1211_TX_TIMEOUT		(HZ*10)
...
dev->watchdog_timeo = ZD1211_TX_TIMEOUT;
dev->tx_timeout = &zd1211_tx_timeout;
============================

A couple of questions:
(1) How should the zd1211_tx_timeout handle a Tx Timeout? At present
it is calling the usb_kill_urb via the kevent. Is this what it is
suppose to do?

============================
static void zd1211_tx_timeout(struct net_device *dev)
  struct zd1205_private *macp = dev->priv;
// Which will call zd1211_kill_tx_urb() below via kevent;
  defer_kevent(macp, KEVENT_KILL_TX_URB);
}

static void zd1211_kill_tx_urb(void *_macp) {
	  struct zd1205_private *macp = (struct zd1205_private *)_macp;
// conditional defines are ommited to keep things clear
    usb_kill_urb(macp->tx_urb);
}
============================

(2) What is the best way to simulate a Tx Timeout? Currently we have
to wait for several days (for 1 of the 10 PCs under stress testing)
for it to occur.

Regards
Keith

             reply	other threads:[~2006-07-19 20:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-19 20:53 Keith Chew [this message]
2006-07-19 21:12 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20f65d530607191353p734e9392g1283dae9a7b14b1a@mail.gmail.com \
    --to=keith.chew@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®