From: Hans de Goede <hdegoede@redhat.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mark Gross <markgross@kernel.org>,
kernel test robot <lkp@intel.com>, Kate Hsuan <hpa@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: p2sb: Move out of X86_PLATFORM_DEVICES dependency
Date: Mon, 1 Aug 2022 15:38:55 +0200 [thread overview]
Message-ID: <20f78e0f-cbf5-2672-7c27-e366f5d7be5f@redhat.com> (raw)
In-Reply-To: <YufTmwg/A94XjrQ8@google.com>
Hi,
On 8/1/22 15:22, Lee Jones wrote:
> On Thu, 28 Jul 2022, Hans de Goede wrote:
>
>> Hi,
>>
>> On 7/18/22 16:53, Andy Shevchenko wrote:
>>> The P2SB library is used for various drivers, including server
>>> platforms. That's why the dependency on X86_PLATFORM_DEVICES
>>> seems superfluous.
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>> ---
>>> v2: added X86 to the dependencies of P2SB (Hans), added Rb tag (Hans)
>>
>> Lee I presume that since you've merged the original series
>> (in your ib-mfd-edac-i2c-leds-pinctrl-platform-watchdog-5.20
>> branch) that you will take this fix on top ?
>
> The point of supplying an immutable branch is that whoever maintains
> this subsystem can pull from it and apply this patch on-top.
True, ok I'll merge the branch and add Andy's fix on top.
Regards,
Hans
>
>> This fix is necessary to fix a bunch of randconfig build
>> failures in the current linux-next.
>>
>>> drivers/platform/x86/Kconfig | 12 ++++++++++++
>>> drivers/platform/x86/Makefile | 4 ++++
>>> drivers/platform/x86/intel/Kconfig | 12 ------------
>>> drivers/platform/x86/intel/Makefile | 2 --
>>> drivers/platform/x86/{intel => }/p2sb.c | 0
>>> 5 files changed, 16 insertions(+), 14 deletions(-)
>>> rename drivers/platform/x86/{intel => }/p2sb.c (100%)
>
next prev parent reply other threads:[~2022-08-01 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 14:53 Andy Shevchenko
2022-07-28 13:36 ` Hans de Goede
2022-08-01 13:22 ` Lee Jones
2022-08-01 13:38 ` Hans de Goede [this message]
2022-08-01 14:40 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20f78e0f-cbf5-2672-7c27-e366f5d7be5f@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hpa@redhat.com \
--cc=lee.jones@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome