mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Icenowy Zheng <zhengxingda@iscas.ac.cn>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard	 <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/panel: ilitek-ili9881c: add Mingjun MJ070BI30IA2
Date: Wed, 18 Nov 2026 23:38:09 +0800	[thread overview]
Message-ID: <2103adaf3f073cd21c42a4b00cb724a8dc836aae.camel@iscas.ac.cn> (raw)
In-Reply-To: <20261102140524.1544755-1-zhengxingda@iscas.ac.cn>

在 2026-11-02一的 22:05 +0800,Icenowy Zheng写道:
> Mingjun MJ070BI30IA2 is a 7" MIPI DSI LCD panel used by Lichee
> Console
> 4A, with a initialization sequence matching the pattern of Ilitek
> ILI9881C driver chip.
> 
> Add it to the driver for ILI9881C-based panels.
> 
> As the sequence provided by Sipeed is captured with a logic analyzer,
> some values are obviously wrong and I patched them with other panels'
> sequence as reference. This fixes a weird problem that the liquid
> crystal gets DC polarized when the panel enters sleep mode, and I am
> grateful to Sashiko for pointing this out.
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>

Is it okay for me to just apply it to drm-misc-next?

Thanks,
Icenowy

> ---
> Changes in v2:
> - Made all hex values in the initialization sequence lower case to
> match
>   other panels.
> - Fixed some obvious errors in the initialization sequence as pointed
> by
>   Sashiko. This also removes the need for doing soft reset in
>   unprepare callback.
> - Added Neil's R-b.
> - Rebased on top of drm-misc-next.
>  drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 222
> ++++++++++++++++++
>  1 file changed, 222 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index acc560dc5ea5d..0854c4cf7ebd7 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -2387,6 +2387,201 @@ static const struct ili9881c_instr
> dt300249_init[] = {
>  	ILI9881C_COMMAND_INSTR(0xd3, 0x3f),
>  };
>  
> +static const struct ili9881c_instr mj070bi30ia2_init[] = {
> +	ILI9881C_SWITCH_PAGE_INSTR(3),
> +	ILI9881C_COMMAND_INSTR(0x01, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x02, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x03, 0x73),
> +	ILI9881C_COMMAND_INSTR(0x04, 0x13),
> +	ILI9881C_COMMAND_INSTR(0x05, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x06, 0x0a),
> +	ILI9881C_COMMAND_INSTR(0x07, 0x05),
> +	ILI9881C_COMMAND_INSTR(0x08, 0x00), /* raw capture 0x11,
> 0x00 */
> +	ILI9881C_COMMAND_INSTR(0x09, 0x28),
> +	ILI9881C_COMMAND_INSTR(0x0a, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x0b, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x0c, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x0d, 0x28),
> +	ILI9881C_COMMAND_INSTR(0x0e, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x0f, 0x28),
> +	ILI9881C_COMMAND_INSTR(0x10, 0x28),
> +	ILI9881C_COMMAND_INSTR(0x11, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x12, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x13, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x14, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x15, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x16, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x17, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x18, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x19, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x1a, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x1b, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x1c, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x1d, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x1e, 0x40),
> +	ILI9881C_COMMAND_INSTR(0x1f, 0x80),
> +	ILI9881C_COMMAND_INSTR(0x20, 0x06),
> +	ILI9881C_COMMAND_INSTR(0x21, 0x01),
> +	ILI9881C_COMMAND_INSTR(0x22, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x23, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x24, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x25, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x26, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x27, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x28, 0x33),
> +	ILI9881C_COMMAND_INSTR(0x29, 0x33),
> +	ILI9881C_COMMAND_INSTR(0x2a, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x2b, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x2c, 0x04),
> +	ILI9881C_COMMAND_INSTR(0x2d, 0x0c),
> +	ILI9881C_COMMAND_INSTR(0x2e, 0x05),
> +	ILI9881C_COMMAND_INSTR(0x2f, 0x05),
> +	ILI9881C_COMMAND_INSTR(0x30, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x31, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x32, 0x31),
> +	ILI9881C_COMMAND_INSTR(0x33, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x34, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x35, 0x0a),
> +	ILI9881C_COMMAND_INSTR(0x36, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x37, 0x08),
> +	ILI9881C_COMMAND_INSTR(0x38, 0x00), /* raw capture 0x70,
> 0x00 */
> +	ILI9881C_COMMAND_INSTR(0x39, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x3a, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x3b, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x3c, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x3d, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x3e, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x3f, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x40, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x41, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x42, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x43, 0x08),
> +	ILI9881C_COMMAND_INSTR(0x44, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x50, 0x01), /* raw capture 0xa0,
> 0x00 */
> +	ILI9881C_COMMAND_INSTR(0x51, 0x23), /* raw capture 0x51,
> 0x22 */
> +	ILI9881C_COMMAND_INSTR(0x52, 0x45),
> +	ILI9881C_COMMAND_INSTR(0x53, 0x67),
> +	ILI9881C_COMMAND_INSTR(0x54, 0x89),
> +	ILI9881C_COMMAND_INSTR(0x55, 0xab),
> +	ILI9881C_COMMAND_INSTR(0x56, 0x01),
> +	ILI9881C_COMMAND_INSTR(0x57, 0x23),
> +	ILI9881C_COMMAND_INSTR(0x58, 0x45),
> +	ILI9881C_COMMAND_INSTR(0x59, 0x67),
> +	ILI9881C_COMMAND_INSTR(0x5a, 0x89),
> +	ILI9881C_COMMAND_INSTR(0x5b, 0xab),
> +	ILI9881C_COMMAND_INSTR(0x5c, 0xcd),
> +	ILI9881C_COMMAND_INSTR(0x5d, 0xef),
> +	ILI9881C_COMMAND_INSTR(0x5e, 0x11),
> +	ILI9881C_COMMAND_INSTR(0x5f, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x60, 0x08),
> +	ILI9881C_COMMAND_INSTR(0x61, 0x0e),
> +	ILI9881C_COMMAND_INSTR(0x62, 0x0f),
> +	ILI9881C_COMMAND_INSTR(0x63, 0x0c),
> +	ILI9881C_COMMAND_INSTR(0x64, 0x0d),
> +	ILI9881C_COMMAND_INSTR(0x65, 0x17),
> +	ILI9881C_COMMAND_INSTR(0x66, 0x01),
> +	ILI9881C_COMMAND_INSTR(0x67, 0x01),
> +	ILI9881C_COMMAND_INSTR(0x68, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x69, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x6a, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x6b, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x6c, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x6d, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x6e, 0x16),
> +	ILI9881C_COMMAND_INSTR(0x6f, 0x16),
> +	ILI9881C_COMMAND_INSTR(0x70, 0x06),
> +	ILI9881C_COMMAND_INSTR(0x71, 0x06),
> +	ILI9881C_COMMAND_INSTR(0x72, 0x07),
> +	ILI9881C_COMMAND_INSTR(0x73, 0x07),
> +	ILI9881C_COMMAND_INSTR(0x74, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x75, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x76, 0x08),
> +	ILI9881C_COMMAND_INSTR(0x77, 0x0e),
> +	ILI9881C_COMMAND_INSTR(0x78, 0x0f),
> +	ILI9881C_COMMAND_INSTR(0x79, 0x0c),
> +	ILI9881C_COMMAND_INSTR(0x7a, 0x0d),
> +	ILI9881C_COMMAND_INSTR(0x7b, 0x17),
> +	ILI9881C_COMMAND_INSTR(0x7c, 0x01),
> +	ILI9881C_COMMAND_INSTR(0x7d, 0x01),
> +	ILI9881C_COMMAND_INSTR(0x7e, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x7f, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x80, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x81, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x82, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x83, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x84, 0x16),
> +	ILI9881C_COMMAND_INSTR(0x85, 0x16),
> +	ILI9881C_COMMAND_INSTR(0x86, 0x06),
> +	ILI9881C_COMMAND_INSTR(0x87, 0x06),
> +	ILI9881C_COMMAND_INSTR(0x88, 0x07),
> +	ILI9881C_COMMAND_INSTR(0x89, 0x07),
> +	ILI9881C_COMMAND_INSTR(0x8a, 0x02),
> +
> +	ILI9881C_SWITCH_PAGE_INSTR(4),
> +	ILI9881C_COMMAND_INSTR(0x6e, 0x1a),
> +	ILI9881C_COMMAND_INSTR(0x6f, 0x37),
> +	ILI9881C_COMMAND_INSTR(0x3a, 0xa4),
> +	ILI9881C_COMMAND_INSTR(0x8d, 0x1f),
> +	ILI9881C_COMMAND_INSTR(0x87, 0xba),
> +	ILI9881C_COMMAND_INSTR(0xb2, 0xd1),
> +	ILI9881C_COMMAND_INSTR(0x88, 0x0b),
> +	ILI9881C_COMMAND_INSTR(0x38, 0x01),
> +	ILI9881C_COMMAND_INSTR(0x39, 0x00),
> +	ILI9881C_COMMAND_INSTR(0xb5, 0x02),
> +	ILI9881C_COMMAND_INSTR(0x31, 0x25),
> +	ILI9881C_COMMAND_INSTR(0x3b, 0x98),
> +
> +	ILI9881C_SWITCH_PAGE_INSTR(1),
> +	ILI9881C_COMMAND_INSTR(0x22, 0x0a),
> +	ILI9881C_COMMAND_INSTR(0x31, 0x00),
> +	ILI9881C_COMMAND_INSTR(0x53, 0x4c), /* raw capture 0xa6,
> 0xa6 */
> +	ILI9881C_COMMAND_INSTR(0x55, 0x3d),
> +	ILI9881C_COMMAND_INSTR(0x50, 0x9e),
> +	ILI9881C_COMMAND_INSTR(0x51, 0x99),
> +	ILI9881C_COMMAND_INSTR(0x60, 0x06),
> +	ILI9881C_COMMAND_INSTR(0x62, 0x20),
> +	ILI9881C_COMMAND_INSTR(0xa0, 0x00),
> +	ILI9881C_COMMAND_INSTR(0xa1, 0x17),
> +	ILI9881C_COMMAND_INSTR(0xa2, 0x26),
> +	ILI9881C_COMMAND_INSTR(0xa3, 0x13),
> +	ILI9881C_COMMAND_INSTR(0xa4, 0x16),
> +	ILI9881C_COMMAND_INSTR(0xa5, 0x29),
> +	ILI9881C_COMMAND_INSTR(0xa6, 0x1e),
> +	ILI9881C_COMMAND_INSTR(0xa7, 0x1f),
> +	ILI9881C_COMMAND_INSTR(0xa8, 0x8b),
> +	ILI9881C_COMMAND_INSTR(0xa9, 0x1d),
> +	ILI9881C_COMMAND_INSTR(0xaa, 0x2a),
> +	ILI9881C_COMMAND_INSTR(0xab, 0x7b),
> +	ILI9881C_COMMAND_INSTR(0xac, 0x1a),
> +	ILI9881C_COMMAND_INSTR(0xad, 0x19),
> +	ILI9881C_COMMAND_INSTR(0xae, 0x4e),
> +	ILI9881C_COMMAND_INSTR(0xaf, 0x24),
> +	ILI9881C_COMMAND_INSTR(0xb0, 0x29),
> +	ILI9881C_COMMAND_INSTR(0xb1, 0x4f),
> +	ILI9881C_COMMAND_INSTR(0xb2, 0x5c),
> +	ILI9881C_COMMAND_INSTR(0xb3, 0x3e),
> +	ILI9881C_COMMAND_INSTR(0xc0, 0x00),
> +	ILI9881C_COMMAND_INSTR(0xc1, 0x17),
> +	ILI9881C_COMMAND_INSTR(0xc2, 0x26),
> +	ILI9881C_COMMAND_INSTR(0xc3, 0x13),
> +	ILI9881C_COMMAND_INSTR(0xc4, 0x16),
> +	ILI9881C_COMMAND_INSTR(0xc5, 0x29),
> +	ILI9881C_COMMAND_INSTR(0xc6, 0x1e),
> +	ILI9881C_COMMAND_INSTR(0xc7, 0x1f),
> +	ILI9881C_COMMAND_INSTR(0xc8, 0x8b),
> +	ILI9881C_COMMAND_INSTR(0xc9, 0x1d),
> +	ILI9881C_COMMAND_INSTR(0xca, 0x2a),
> +	ILI9881C_COMMAND_INSTR(0xcb, 0x7b),
> +	ILI9881C_COMMAND_INSTR(0xcc, 0x1a),
> +	ILI9881C_COMMAND_INSTR(0xcd, 0x19),
> +	ILI9881C_COMMAND_INSTR(0xce, 0x4e),
> +	ILI9881C_COMMAND_INSTR(0xcf, 0x24),
> +	ILI9881C_COMMAND_INSTR(0xd0, 0x29),
> +	ILI9881C_COMMAND_INSTR(0xd1, 0x4d),
> +	ILI9881C_COMMAND_INSTR(0xd2, 0x5c),
> +	ILI9881C_COMMAND_INSTR(0xd3, 0x3e),
> +};
> +
>  static inline struct ili9881c *panel_to_ili9881c(struct drm_panel
> *panel)
>  {
>  	return container_of(panel, struct ili9881c, panel);
> @@ -2699,6 +2894,23 @@ static const struct drm_display_mode
> dt300249_default_mode = {
>  	.height_mm	= 121,
>  };
>  
> +static const struct drm_display_mode mj070bi30ia2_mode = {
> +	.clock		= 75750,
> +
> +	.hdisplay	= 800,
> +	.hsync_start	= 800 + 48,
> +	.hsync_end	= 800 + 48 + 32,
> +	.htotal		= 800 + 48 + 32 + 80,
> +
> +	.vdisplay	= 1280,
> +	.vsync_start	= 1280 + 3,
> +	.vsync_end	= 1280 + 3 + 10,
> +	.vtotal		= 1280 + 3 + 10 + 24,
> +
> +	.width_mm	= 94,
> +	.height_mm	= 150,
> +};
> +
>  static int ili9881c_get_modes(struct drm_panel *panel,
>  			      struct drm_connector *connector)
>  {
> @@ -2913,6 +3125,15 @@ static const struct ili9881c_desc
> dt300249_desc = {
>  	.lanes = 4,
>  };
>  
> +static const struct ili9881c_desc mj070bi30ia2_desc = {
> +	.init = mj070bi30ia2_init,
> +	.init_length = ARRAY_SIZE(mj070bi30ia2_init),
> +	.mode = &mj070bi30ia2_mode,
> +	.mode_flags = MIPI_DSI_MODE_VIDEO |
> MIPI_DSI_MODE_VIDEO_BURST |
> +		      MIPI_DSI_MODE_LPM,
> +	.lanes = 4,
> +};
> +
>  static const struct of_device_id ili9881c_of_match[] = {
>  	{ .compatible = "bananapi,lhr050h41", .data =
> &lhr050h41_desc },
>  	{ .compatible = "bestar,bsd1218-a101kl68", .data =
> &bsd1218_a101kl68_desc },
> @@ -2924,6 +3145,7 @@ static const struct of_device_id
> ili9881c_of_match[] = {
>  	{ .compatible = "wanchanglong,w552946aba", .data =
> &w552946aba_desc },
>  	{ .compatible = "waveshare,7.0-dsi-touch-a", .data =
> &waveshare_7inch_a_desc },
>  	{ .compatible = "ampire,am8001280g", .data =
> &am8001280g_desc },
> +	{ .compatible = "mingjun,mj070bi30ia2", .data =
> &mj070bi30ia2_desc },
>  	{ .compatible = "raspberrypi,dsi-5inch", &rpi_5inch_desc },
>  	{ .compatible = "raspberrypi,dsi-7inch", &rpi_7inch_desc },
>  	{ }


      reply	other threads:[~2026-11-18 15:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 14:05 Icenowy Zheng
2026-11-18 15:38 ` Icenowy Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2103adaf3f073cd21c42a4b00cb724a8dc836aae.camel@iscas.ac.cn \
    --to=zhengxingda@iscas.ac.cn \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®