From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7292D31326C for ; Mon, 12 Jan 2026 20:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768249504; cv=none; b=LOwCQc2dHFYDFUWle6DJN1KGbDR/tbqcXBFCPQH+OJRf0bsfQxU20krcoMPEqvPfFXfC/H1y6sCQSQN6Vm0LFSHfU0Jgp9HtqDdR42bMRWSVQbFsFc/YeTBsnjf1MUdw/e8/gZ9lkkhER6MLoDbvkz2Ey+m5K5hKrmYx56SPd0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768249504; c=relaxed/simple; bh=/dklBrNC9dtNwtEkW3+1FasmVEQ+IfE0nrDRIZz1Bd0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=IorbUSIWnfp8saBK9RKv8XLyCgp0JCXDRAK0PWJfgEovSwKtelSQViW9F7zGXkkvL075tGI3POunTYH+7LAK0OEkAdf54OmK5xlF4jceKnoNgnb/WXHgLkwsrJJCIpg5yW6D3Q+OhlyGxDD2vm0amPcD87XPrMAUL/9B+xyh+sA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SVXF4SDY; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GbBRSZu6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SVXF4SDY"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GbBRSZu6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768249502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/dklBrNC9dtNwtEkW3+1FasmVEQ+IfE0nrDRIZz1Bd0=; b=SVXF4SDYZyKKq6YNegUyovzjzI71rPGHWj2Sgs7n+JvSZQ7Xfbi97+r+6o33Futc1uOeXX zR72mEKv6nNqtuNJPk4c16nUAnKEJPqFdpG6cF6uDnPgzYcfF6ACXUmEunwjf+r5KUscUA Q1IBOgGL3Uy75mGLvbjUoj1/9BqBSxE= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-1JXodxC1NlOzhdOuTS1OUQ-1; Mon, 12 Jan 2026 15:24:59 -0500 X-MC-Unique: 1JXodxC1NlOzhdOuTS1OUQ-1 X-Mimecast-MFC-AGG-ID: 1JXodxC1NlOzhdOuTS1OUQ_1768249498 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-88a316ddbacso179268296d6.2 for ; Mon, 12 Jan 2026 12:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768249498; x=1768854298; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=/dklBrNC9dtNwtEkW3+1FasmVEQ+IfE0nrDRIZz1Bd0=; b=GbBRSZu6MZGUDxqWE7fhIhbEW9bhMMpJ/DcI32V6tI9zC1XF5rYAv6m+DyTJPWjMgB gAm2FahBJAt3d7EuPK31ZI1UPIpwslzYsgiUIlf/4BeyjbwZHmMehrdcUHTjwDnBFWyB RGMbkho+yI822NZjeNAuBB87Y+uzTm1kbMcW6IhbL82JkcBLbvYInNZhS+em+cBFSmUG 7igwfFaP/R8H3pNCKHYWDGVk46QcHlG4Ka5t71kNJFt5UMTyqu76KW3mqGf4AYn39SBi BxZ+4ge0u9edqf6uSESdlBFvgPiBxuuLpmFq0EjYHbX/piFHHFOYsc62Mzveg3CPGGNU R9jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768249498; x=1768854298; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/dklBrNC9dtNwtEkW3+1FasmVEQ+IfE0nrDRIZz1Bd0=; b=ac2r94LdRk561CBFafm09xLDJn755vniWl7rAKVzL/iWvl7PfNAeopDqITqrpHJD+w WBusxSWpo8BMh1PEgt8Y8Qs22EESB7j/W0pLUIf/xvGJogRfyXbJ7GLPIRhssRZZnDJR gGC8fuBtW7TfghOI4q5V3bgeJPCiQNlprpjUpxE0BwbbzRqaY4eD2vosomU/pR/vtkpx lkc7prmfXFA5fs1Yvf0ms9NzQjX8gKPVg4iPOQIbY8Hp2hGnhbvVDVgJZ6Z5T6X8Abyi BvPr4wcANIJKmQ63BdzFxVw7r5kgob7WpF10UWWQZDPPhIfEDW5XcKwdzwtGOZbnAM2K 4mpA== X-Forwarded-Encrypted: i=1; AJvYcCUvyUvI6R0ts4zX4CKVrjLi7sg4YO1Og60h3Dp4utRqrOo4mfLrf06m3NNTa/n6H9AR59770UWCJDRWooY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5FQ90+v2BvEIn7vb7vOMgJFD9YOtr2xpdERfne0wAd709lVMW P22ENl3tPBs+xxlaDRqLsuiuPZhCrCbpi6lVQ7FaMe6HepJVH0bJahXF453XpG90k0thAvBFqip 1dMad7j78DY4Z9ts7IyaRSANeFcl73Z0Vry0kf1OtAe8uCv2aHQY2kRdlmFTvW82MOA== X-Gm-Gg: AY/fxX5XaY/GOgZfwblyJIk4BUpmzLtBv7NshVk6TrXV3QX+RYPN6jqhdqz9EuOWFbP BcOhocd3xcusfhh8m5KNMbG9Z7Ccyf6m4Hyy7QixARqlxp5K01Ctkzaiu2N5SGJpQugeHxc4CPE KpONv5xJUbQ2/2qNs0k7/kABhYHElN0S+LR55ItEhiAjPOmodETqAVUht0Mg+wfvaADQBszo7V7 TjIQJHGW5lu6SEQpn58OPWnJjF6gfZ04mJtc4WWs3Dsxrk6H8zdFa5qwSHOZc84oxjc/L8bMbpu 3w9FYYcdVC5PmVT+8a7czwU9simLs0GFKG2TBWzXmzz95IT0pd/nthom9bLUHD57wvj+Vk/nubF NgJcXCgtCJ+csWpwTbT+K38V0RdzZqimH4TSXAPwlHOsv3io+WxOQwd3q8LrNmb4a/tHu28CxE6 dwgw== X-Received: by 2002:ad4:5d47:0:b0:882:3f45:c819 with SMTP id 6a1803df08f44-890842a26b0mr289707316d6.53.1768249498397; Mon, 12 Jan 2026 12:24:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3zFajB3/aY+UiopgOBI5CD0c+r+XVq0bnvAyZwWzkhQ2n7CYye6LaSk94UeTrl1wRZO91aw== X-Received: by 2002:ad4:5d47:0:b0:882:3f45:c819 with SMTP id 6a1803df08f44-890842a26b0mr289706906d6.53.1768249497865; Mon, 12 Jan 2026 12:24:57 -0800 (PST) Received: from thinkpad-p1.localdomain (pool-174-112-193-187.cpe.net.cable.rogers.com. [174.112.193.187]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ffb75d7916sm128452951cf.7.2026.01.12.12.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 12:24:57 -0800 (PST) Message-ID: <2105d279ce5df15bc15e29a5e21ab3c5b6e440a1.camel@redhat.com> Subject: Re: [PATCH] fixup! genirq: Add interrupt redirection infrastructure From: Radu Rendec To: Thomas Gleixner Cc: Manivannan Sadhasivam , Daniel Tsai , Marek =?ISO-8859-1?Q?Beh=FAn?= , Krishna Chaitanya Chundru , Bjorn Helgaas , Rob Herring , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , Jingoo Han , Brian Masney , Eric Chanudet , Alessandro Carminati , Jared Kangas , Jon Hunter , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-tegra@vger.kernel.org Date: Mon, 12 Jan 2026 15:24:56 -0500 In-Reply-To: <87fr8bg6lv.ffs@tglx> References: <20260109175227.1136782-1-rrendec@redhat.com> <87fr8bg6lv.ffs@tglx> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, Thomas! On Sun, 2026-01-11 at 22:52 +0100, Thomas Gleixner wrote: > Thanks for taking care of this, but this is not really the way how it > works. >=20 > $subject: fixup!.... is neither a valid nor a useful subject line. >=20 > $subject is documented to be a concise summary of the change at hand, so > in this case this should be something like: >=20 > =C2=A0=C2=A0 [PATCH] genirq: Update effective affinity for redirected int= errupts >=20 > [snip] >=20 > It also lacks a 'Fixes:' tag as the code is already merged, no? >=20 >=20 > [snip] Apologies, and thanks a lot for taking the time to provide such detailed feedback! I mistakenly assumed the original commit could still be *amended*, and the format I used was a (failed) attempt at asking that. I didn't realize the commit was immutable once included in the tip tree, and didn't pay much attention to the commit message because I thought it would be discarded anyway while amending. In my defense, $subject: "fixup! " is a format recognized by `git rebase` and used on some subsystems to fix already accepted patches *before* they are merged upstream. It just doesn't apply here. Lesson learned! I will re-send it using the standard format for fixing a commit that's already merged, and follow all the suggestions you made. --=20 Best regards, Radu