mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Sverdlin <alex@sverdlin.org>
To: Enzo Adriano <enzo.adriano.code@gmail.com>,
	andre.przywara@arm.com,  robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, wens@kernel.org,  jernej.skrabec@gmail.com,
	samuel@sholland.org
Cc: Maxime Ripard <mripard@kernel.org>,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev,  linux-kernel@vger.kernel.org,
	Junhui Liu <junhui.liu@pigmoral.tech>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Pablo Mazzini <pmazzini@gmail.com>,
	Vinicius Pedrosa	 <vinicius.eduardo.pedrosa@gmail.com>,
	Jun Yan <jerrysteve1101@gmail.com>,
	 Lukas Schmid <lukas.schmid@netcube.li>
Subject: Re: [PATCH v3 3/3] arm64: dts: allwinner: add Radxa Cubie A7S board
Date: Wed, 18 Nov 2026 19:03:59 +0100	[thread overview]
Message-ID: <2105df7b92b20c5268a9a32c202e1cd6c24a6b27.camel@sverdlin.org> (raw)
In-Reply-To: <0fe5938e04cc8a5af3825a0e01bd07b626a15b46.1794227241.git.enzo.adriano.code@gmail.com>

Hi Enzo,

On Mon, 2026-11-09 at 23:45 -0500, Enzo Adriano wrote:
> Enable the Cubie A7S serial console, PMIC and microSD slot to provide
> an initial usable board configuration. Supply the 26 MHz crystal and
> 32768 Hz RTC input, enable UART0 and the AXP318W on R-I2C0, and describe
> the PMIC input/output and CPU supply connections from the Radxa Cubie
> A7S schematic v1.10. Preserve firmware settings on rails whose working
> voltage is not established. BLDO2 has no programmed voltage constraint:
> its software 3.3 V selector does not establish its physical output with
> the schematic's nominal 2.4 V input.
> 
> Describe the card's SWOUT2 supply and PF6 active-high detect with an
> internal pull-down. Enable MMC0 at up to 50 MHz using 3.3 V signaling
> only. Its high-voltage path uses VCCIO; CLDO5 also feeds PC and the PF
> 1.8 V input and must not be raised for SD signaling. Firmware must
> select the 3.3 V PF path; dynamic voltage switching is not provided.
> Keep other storage off.
> 
> Connect the documented bank supplies. PL's self-supply phandle is
> omitted to avoid the PMIC/I2C/pinctrl bootstrap cycle, as on the
> upstream Cubie A5E; ALDO1 is retained always-on. The separate pinctrl
> voltage-mode fix is required for these bank-supply connections.
> 
> These board DTS bytes were RAM-booted on a Cubie A7S with vendor
> firmware on November 4: UART0, PMIC registration and MMC0 read-only
> transfers worked. Card writes, physical hotplug, 1.8 V signaling and
> physical BLDO2 voltage were not tested.

Should the history be moved below "---"?

> Signed-off-by: Enzo Adriano <enzo.adriano.code@gmail.com>
> ---
>  arch/arm64/boot/dts/allwinner/Makefile        |   1 +
>  .../dts/allwinner/sun60i-a733-cubie-a7s.dts   | 284 ++++++++++++++++++
>  2 files changed, 285 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts
> 
> diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> index d1f768dd6461..792152525b43 100644
> --- a/arch/arm64/boot/dts/allwinner/Makefile
> +++ b/arch/arm64/boot/dts/allwinner/Makefile
> @@ -68,3 +68,4 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun55i-a527-cubie-a5e.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun55i-h728-x96qpro+.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun55i-t527-avaota-a1.dtb
>  dtb-$(CONFIG_ARCH_SUNXI) += sun55i-t527-orangepi-4a.dtb
> +dtb-$(CONFIG_ARCH_SUNXI) += sun60i-a733-cubie-a7s.dtb
> diff --git a/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts
> new file mode 100644
> index 000000000000..341c24360ce2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts
> @@ -0,0 +1,284 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR MIT)
> +/dts-v1/;
> +
> +#include "sun60i-a733.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/ {
> +	model = "Radxa Cubie A7S";
> +	compatible = "radxa,cubie-a7s", "allwinner,sun60i-a733";
> +
> +	aliases {
> +		mmc0 = &mmc0;
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	reg_ps: regulator-system-power {
> +		compatible = "regulator-fixed";
> +		regulator-name = "ps";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		regulator-always-on;
> +	};
> +
> +	reg_ldo_input: regulator-ldo-input {
> +		compatible = "regulator-fixed";
> +		regulator-name = "ldo-input";
> +		/* ETA3521: 0.6 V * (1 + RP298 / RP299), 30k / 10k. */
> +		regulator-min-microvolt = <2400000>;
> +		regulator-max-microvolt = <2400000>;
> +		regulator-always-on;
> +		vin-supply = <&reg_ps>;
> +	};
> +
> +	osc32k: osc32k-clk {

Should two regulators and the clock have been sorted in the reverse order?

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <32768>;
> +	};
> +};
> +
> +&cpu0 {
> +	cpu-supply = <&reg_dcdc5>;
> +};
> +
> +&cpu1 {
> +	cpu-supply = <&reg_dcdc5>;
> +};
> +
> +&cpu2 {
> +	cpu-supply = <&reg_dcdc5>;
> +};
> +
> +&cpu3 {
> +	cpu-supply = <&reg_dcdc5>;
> +};
> +
> +&cpu4 {
> +	cpu-supply = <&reg_dcdc5>;
> +};
> +
> +&cpu5 {
> +	cpu-supply = <&reg_dcdc5>;
> +};
> +
> +&cpu6 {
> +	cpu-supply = <&reg_dcdc3>;
> +};
> +
> +&cpu7 {
> +	cpu-supply = <&reg_dcdc3>;
> +};
> +
> +&mmc0 {
> +	bus-width = <4>;
> +	cap-sd-highspeed;
> +	cd-gpios = <&pio 5 6 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>;
> +	disable-wp;
> +	max-frequency = <50000000>;
> +	no-1-8-v;
> +	vmmc-supply = <&reg_swout2>;
> +	/* The 3.3 V path uses VCC-IO; no Port F voltage switching yet. */
> +	vqmmc-supply = <&reg_swout2>;
> +	status = "okay";

see below...

> +};
> +
> +&osc {
> +	clock-frequency = <26000000>;
> +};
> +
> +&pio {
> +	vcc-pb-supply = <&reg_swout2>;
> +	vcc-pc-supply = <&reg_cldo5>;
> +	vcc-pd-supply = <&reg_swout1>;
> +	vcc-pe-supply = <&reg_bldo1>;
> +	vcc-pf-supply = <&reg_cldo5>;
> +	vcc-pg-supply = <&reg_aldo1>;
> +	vcc-ph-supply = <&reg_swout2>;
> +	vcc-pj-supply = <&reg_swout1>;
> +	vcc-pk-supply = <&reg_bldo1>;
> +};
> +
> +&r_i2c0 {
> +	status = "okay";

Should "status" have been last (preceded by a blank line)? (dts-coding-style.rst)

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&r_i2c0_pl_pins>;
> +
> +	axp318w: pmic@36 {
> +		compatible = "x-powers,axp318w";
> +		reg = <0x36>;
> +		interrupt-parent = <&nmi_intc>;
> +		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +		interrupt-controller;
> +		#interrupt-cells = <1>;
> +
> +		aldo156in-supply = <&reg_ps>;
> +		aldo234in-supply = <&reg_aldo1>;
> +		bldoin-supply = <&reg_ldo_input>;
> +		cldoin-supply = <&reg_ldo_input>;
> +		dldoin-supply = <&reg_ps>;
> +		eldoin-supply = <&reg_dcdc9>;
> +		ips-supply = <&reg_ps>;
> +		vin19-supply = <&reg_ps>;
> +		vin23-supply = <&reg_ps>;
> +		vin45-supply = <&reg_ps>;
> +		vin678-supply = <&reg_ps>;
> +
> +		regulators {
> +			reg_dcdc1: dcdc1 {
> +				regulator-name = "vcc-3v3";
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc2: dcdc2 {
> +				regulator-name = "vdd-sys";
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc3: dcdc3 {
> +				regulator-name = "vdd-cpub";
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc4: dcdc4 {
> +				regulator-name = "vdd-gpu";
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc5: dcdc5 {
> +				regulator-name = "vdd-cpul";
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc6: dcdc6 {
> +				regulator-name = "vcc-draml";
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc7: dcdc7 {
> +				regulator-name = "vcc-dram";
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc8: dcdc8 {
> +				regulator-name = "vcc-ufs-io";
> +				regulator-always-on;
> +			};
> +
> +			reg_dcdc9: dcdc9 {
> +				regulator-name = "eldo-input";
> +				regulator-always-on;
> +			};
> +
> +			reg_swout1: swout1 {
> +				regulator-name = "vcc33-lcd";
> +				regulator-always-on;
> +			};
> +
> +			reg_swout2: swout2 {
> +				regulator-name = "vcc-io-card";
> +				regulator-always-on;
> +			};
> +
> +			reg_aldo1: aldo1 {
> +				regulator-name = "vcc-pl";
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			reg_bldo1: bldo1 {
> +				regulator-name = "vcc-pe-pk-mcsi";
> +			};
> +
> +			reg_bldo2: bldo2 {
> +				regulator-name = "vcc-lvds0";
> +				regulator-always-on;
> +			};
> +
> +			reg_bldo4: bldo4 {
> +				regulator-name = "vcc18-codec";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +			};
> +
> +			reg_cldo1: cldo1 {
> +				regulator-name = "vcc33-18-usb";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
> +			};
> +
> +			reg_cldo2: cldo2 {
> +				regulator-name = "vcc18-hdmi";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +			};
> +
> +			reg_cldo3: cldo3 {
> +				regulator-name = "vcc-pll-dram";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
> +			};
> +
> +			reg_cldo5: cldo5 {
> +				regulator-name = "vcc18-pf-pc";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
> +			};
> +
> +			reg_dldo1: dldo1 {
> +				regulator-name = "vcc-efuse";
> +				regulator-always-on;
> +			};
> +
> +			reg_dldo6: dldo6 {
> +				regulator-name = "vcc-ufs";
> +				regulator-always-on;
> +			};
> +
> +			reg_eldo1: eldo1 {
> +				regulator-name = "vcc09-vdd2l";
> +				regulator-always-on;
> +			};
> +
> +			reg_eldo6: eldo6 {
> +				regulator-name = "vdd-cpus";
> +				regulator-always-on;
> +			};
> +
> +			reg_rtc_ldo: rtc-ldo {
> +				regulator-name = "vcc-rtc";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
> +			};
> +		};
> +	};
> +};
> +
> +&r_pio {
> +	/* PL powers the PMIC bus itself; firmware must keep ALDO1 enabled. */
> +	vcc-pm-supply = <&reg_aldo1>;
> +};
> +
> +&rtc {
> +	clocks = <&r_ccu CLK_BUS_R_RTC>, <&osc>, <&r_ccu CLK_R_AHB>,
> +		 <&osc32k>;
> +	clock-names = "bus", "hosc", "ahb", "ext-osc32k";
> +};
> +
> +&uart0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart0_pb_pins>;
> +	status = "okay";

see above...

> +};

  reply	other threads:[~2026-11-18 18:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  4:45 [PATCH v3 0/3] arm64: dts: allwinner: add A733/Cubie A7S support Enzo Adriano
2026-11-10  4:45 ` [PATCH v3 1/3] dt-bindings: arm: sunxi: document Radxa Cubie A7S Enzo Adriano
2026-11-17 23:24   ` Alexander Sverdlin
2026-11-10  4:45 ` [PATCH v3 2/3] arm64: dts: allwinner: add A733 SoC description Enzo Adriano
2026-11-11 12:02   ` Vinicius Pedrosa
2026-11-18 16:47   ` Alexander Sverdlin
2026-11-10  4:45 ` [PATCH v3 3/3] arm64: dts: allwinner: add Radxa Cubie A7S board Enzo Adriano
2026-11-18 18:03   ` Alexander Sverdlin [this message]
2026-11-11 12:09 ` [PATCH v3 0/3] arm64: dts: allwinner: add A733/Cubie A7S support Enzo Adriano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2105df7b92b20c5268a9a32c202e1cd6c24a6b27.camel@sverdlin.org \
    --to=alex@sverdlin.org \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=enzo.adriano.code@gmail.com \
    --cc=jbrunet@baylibre.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jerrysteve1101@gmail.com \
    --cc=junhui.liu@pigmoral.tech \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=lukas.schmid@netcube.li \
    --cc=mripard@kernel.org \
    --cc=pmazzini@gmail.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=vinicius.eduardo.pedrosa@gmail.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®