From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD04016DEC2; Mon, 1 Jul 2024 16:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719852582; cv=none; b=XCgLt75U9mUnW1dRKnioxywMIGPTFT3IwbRhIwO48sB9iaYa2EZRZUGU3tvkjZknpzG5xDCGJqb/gqOvRBP5YzSQu4msb2U+Qi9zt4w6gQ9yKsIzBsvvtSmBp4Anv1F68D+iSg67XlG7iKV/iwxoolZ5sWKezEfBrabzhCeABAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719852582; c=relaxed/simple; bh=2mzQChKJBEDOxYPL0UcHWBNArWKR33Oh6AobARyhyng=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dLK9Fs30FsSvaKZQSf8zsow2CZya43+8N0uvBt8VMIWZVGrMIJumRgIjtiiYNrQx/JPW8bl6rffz/pHNGuZ01ZbwHBDs2/Jtw/sWsa6OVQADB3e5kUDMI+0LTdTP8dIQofA2zdTsH2gVoCkosEGh12iv++L2UpAJIAkg8oYHf0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=qoebQFd4; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qoebQFd4" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=r0nb3H9c2I34kc6YVbbpxeTBYxeO3JBcLrwkJRtEGMI=; b=qoebQFd4z3LA+lu2Jl7LUTcVEw x/umcz3cJApJrjt7Dsm8c1UlkItdiodXhFCXwT/a8Q+RSlXAiYc9pPZsh5u23xyaHmbrg97JdlDlt kvUzvG22t3rOZxUP4l7vm2qAD8FoCWtcSmhFbFHCkf46TWV2eNdmFvlt8uah8Cvjo2cg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sOKDV-001Z1N-8p; Mon, 01 Jul 2024 18:49:25 +0200 Date: Mon, 1 Jul 2024 18:49:25 +0200 From: Andrew Lunn To: Romain Gantois Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/6] net: phy: dp83869: Support 1000Base-X and 100Base-FX SFP modules Message-ID: <21081e48-0f96-463f-a01a-959eb71bdb40@lunn.ch> References: <20240701-b4-dp83869-sfp-v1-0-a71d6d0ad5f8@bootlin.com> <20240701-b4-dp83869-sfp-v1-4-a71d6d0ad5f8@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240701-b4-dp83869-sfp-v1-4-a71d6d0ad5f8@bootlin.com> > + dev_info(&phydev->mdio.dev, "%s SFP compatible link mode: %s\n", __func__, > + phy_modes(interface)); Maybe phydev_debug(). > + > + dp83869 = phydev->priv; > + > + switch (interface) { > + case PHY_INTERFACE_MODE_100BASEX: > + dp83869->mode = DP83869_RGMII_100_BASE; > + phydev->port = PORT_FIBRE; > + break; > + case PHY_INTERFACE_MODE_1000BASEX: > + dp83869->mode = DP83869_RGMII_1000_BASE; > + phydev->port = PORT_FIBRE; > + break; > + default: > + dev_err(&phydev->mdio.dev, > + "incompatible PHY-to-SFP module link mode %s!\n", > + phy_modes(interface)); phydev_err()? Andrew --- pw-bot: cr