From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9A6A3DE449 for ; Tue, 31 Mar 2026 08:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774945382; cv=none; b=AQ9qenr170h+OLJfeM3JbiY0wuNc8P1498R441Lllu1Y1feIc1p2AHI75dc/dYGYDhKVWFDHjnlBrVOjQU+jwwmc66b0nkxdCd4ONm9mr7uXpEAfkz/QtuHaQ8o7ELAA9L8qgh85smlyrqtDeWyP7+5LD4kQHDNitJ6PWCX2GIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774945382; c=relaxed/simple; bh=8v+A7AQmb92O7SlStoMr11gQAb7+5U+SMRxrab0XdMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=csuOIzklQQ6nts/fvg7Z7EM/4/JTWJ/rnWa1laIpGseNH1GbAVn0RwCt1MWbhn3TprUvMfks4hJYo3DAbZvcOhiiRgOCwJFhTatKdskeP7vxBKEYiZIb34TgcCRkrRIRvg1uv8oAlGJty2pL5PwMP0ZHbn0IWvY+n4dxLw4yvNA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F+7bvyny; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cZt+Wazc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F+7bvyny"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cZt+Wazc" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V8Av7s058047 for ; Tue, 31 Mar 2026 08:22:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ty9ajhQdOOIwc79Wf8xk5txDu2PvCUdpTXfca71qAjU=; b=F+7bvynyr19IUZqn bG9LLBFKsQWN+ClFKtNxECjQmi2H3DaVvZOZn9uH6ocEmFgJNqKALpkOPFAFUWRs bSucBFqvewzjj+ZRjxRt1ki/mh76TVAwvLtShNuWwVIPSyNm9xtXMNzcdYP+pDvL GMGAiJKXlJbjgGyKU/sAWLyyz5X+cPLFkWrA76d19hY5BsAr/RvtafD9ACpdR5GR P+Evy/Fx8b5zF8u0iCHfMg0PpNkhV/haoVtgtaea/BopGnE9P2Z9DcSHik07pOjd KIbFqbVLEIK4xfHeM2Bg9GKNcaEyoJ4pL73IAMrorwK+Pa97R5GQ3K9uNcuuAWWd lVOc0w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8ahkr215-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 08:22:56 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8a18178713cso6966636d6.3 for ; Tue, 31 Mar 2026 01:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774945376; x=1775550176; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ty9ajhQdOOIwc79Wf8xk5txDu2PvCUdpTXfca71qAjU=; b=cZt+Wazc6vzjIwxV03myxQakKVM1NZsnmEwARj+dOQc+BAZPw9UsJkTe/UxvtiDr/V 57UYitRA78qis3NYEwZObpgK9WrNzkW+bblwHTWOoSn91nk3E/cAVPQP4ZXDo0UiR2Rv j12dp1I8dXoJ5DKQLK8ZppHe/UReyJe4Ff/qEPX+fFYDU5ji3/xnrnf2rkMyIhhOlOd3 WO0bVlsDGYDhtOUjxaXzETNeOZ+K3dtDNwcCfkS+q7Q28zTjLnsqIobFDnQwZYrna1vX Ko3X+4VBKK5lswcobE8+Fa07ACeZCJZcub3lfQ1dSmFE7zeWY4TxO7/ibPNnbe7JaX5X 3lXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774945376; x=1775550176; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ty9ajhQdOOIwc79Wf8xk5txDu2PvCUdpTXfca71qAjU=; b=peF7mklHi0jC3sa6PhVPM/AeGxsCY/MCxWdFwXlPsUpk4/ZTCw+82sedYm1IZCW+A+ RmY4qthX+XfW2IBE28VxsHtjPQbICgJDz/MPs5EEFrpu8vW8pskUeVhwQZxz+DwobKIS 005JzLJ9mGA3pna6YErEoEI1gQ6kPt3DC+8U9Mk7CR8SnpqiG3dYsxqjz2Kgwk512i4n XVCiLLcrTM0cBbcC6I8YlLuo9ohQR8M2R/60nBH+AMsPdEM/sUfHvVq4Z0OsemBKZZLb XzguDi3uYtT+hMEY9TlnTjTmloqyuCYd4rsKrmvo1zio6br58F7u6IlbuCuBf+2SLYsC 69Ig== X-Forwarded-Encrypted: i=1; AJvYcCXkTK3F/ynYJntx6tnsHwcIu1erDp5RpEA9gAgnA4kxge2RXTfgYE6bhhIJHkgvkiKmXYPV31UKdZqiSXk=@vger.kernel.org X-Gm-Message-State: AOJu0YxYXX83G8OjmE2Zsg8MGv2XaXq98cH17pPASxYVwcysTG8oNcoS 7mLe5At0M7PEBZFpyJgtYsHVNo6zkf5ac4srsuASUZ+Dlr2kVjbACRq9htYgq6bzlsDFikejJOM A8jCf6MrglI8EC8PF77K2BrSAUzVZ3AhCEguHse+ulwkf2Xb+2TeRneb/bOFsXyHl2Oc= X-Gm-Gg: ATEYQzzSBatESbELv1Gn0mQEXPMGbJoq9v5KJu2RrpVO6acxldJ4oBFZVZOoWhTwA72 vZQgwFESGgYUywDP/6DG25JGPnUAkHZ/NOaJmnDmois2UCwz2W29Evo1/om2bMHdAt8nxyosxIr d46ZD2pHoqjonkwS82B98b6GPIlkF9ErmrdHLXoNncNztAE2DF86eECC7ebWt9H2eUKEmzHRVnq BtNYYESgYPYtQ7N4vNYMeAZnwJ4MfZ6WfugZW7sWtUHfqudl6rWA2xsplbDltvIhVClu9kLxEnN 26lIQvuc9P4QWGElk3V6bjAcwj6ufVdoXYHuwmPJvX2BqRx2Q6wZJrztG5rNnZE5ANI62ZcwP3z BbSpKgV7Znnn0Hu14yAgfRb1sCsII8Bd31PzrCezS9JbJrATyZsYAMUuBd/lJznkfIx3oXGK0MT +s/z0= X-Received: by 2002:a05:6214:766:b0:89c:5fbe:cc5b with SMTP id 6a1803df08f44-89ce8b8423dmr160477556d6.0.1774945376393; Tue, 31 Mar 2026 01:22:56 -0700 (PDT) X-Received: by 2002:a05:6214:766:b0:89c:5fbe:cc5b with SMTP id 6a1803df08f44-89ce8b8423dmr160477306d6.0.1774945375960; Tue, 31 Mar 2026 01:22:55 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7ae522d4sm387153766b.22.2026.03.31.01.22.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 01:22:54 -0700 (PDT) Message-ID: <2108dfe4-bbe9-48b8-b77f-e7d2904f18b4@oss.qualcomm.com> Date: Tue, 31 Mar 2026 10:22:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/17] drm/msm/a6xx: Update HFI definitions To: Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> <20260327-a8xx-gpu-batch2-v2-10-2b53c38d2101@oss.qualcomm.com> <3465929e-262f-407e-bc3d-7564787bce3d@oss.qualcomm.com> <67cca0c6-669c-4dcf-be3f-76fc46d1e59f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <67cca0c6-669c-4dcf-be3f-76fc46d1e59f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA3OSBTYWx0ZWRfX9zykUOADtCwL ENsH4QgVyPtMxzDCb2YJL8xgJU9H0euRYQR0i07CPcuPyWrlHDsoEp+Cdo2u5e5w32JcQ/pRQAi TC1NvUslFXyoZIp8d31H2ifunbdyM4uv3ssrHyf2bjOJDvFaAqDqS1rp22mYFni/4xsx925ulA7 UtRSsyNL4w7z14U+qLjftrEEYs56x8QJIJz3fP/AtnV/08zVLTovFGWjMQuVCh4uuU6SR8OvR+S zHwGBiWW88GCZghg/7v+3L7la+hzyOBs6Cprt7AM0BqQ1nYQN376hv5NEGZrt8NdQAmFI12bg9l d1U8XhMmACmVA4qPTSNE367F98Y60rcRTDq6WTffL1g798ZPlMJUUq0XNk7l6HFtPgxeukFR6wk zX8tpw29zSjqJJbf8N+JvRjAz3NHvEygXxVPjW1qQz6Pwk7AXwxmC9ITQR6Sdmd7lAPA+nd7k8i +Z1zeSzlG/epbQI5AFQ== X-Authority-Analysis: v=2.4 cv=K4wv3iWI c=1 sm=1 tr=0 ts=69cb8461 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=xmSHU_qjkZn9DgC3Z3sA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: gKod7GIyJsgQaAYd_uRvBHO6H7Rl-Axp X-Proofpoint-GUID: gKod7GIyJsgQaAYd_uRvBHO6H7Rl-Axp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 impostorscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310079 On 3/30/26 10:27 PM, Akhil P Oommen wrote: > On 3/30/2026 4:45 PM, Konrad Dybcio wrote: >> On 3/27/26 1:13 AM, Akhil P Oommen wrote: >>> Update the HFI definitions to support additional GMU based power >>> features. >>> >>> Signed-off-by: Akhil P Oommen >>> --- >> >> Whether you want to proceed with bitfields or not: >> >> Reviewed-by: Konrad Dybcio > > Thanks. I still feel it is bitfield layout is a 'bit' complicated. > > I did an experiment: > > #include > #include > #include > > struct packed_u8 { > uint16_t mitigation_time; > uint8_t current_rating : 6; > uint8_t num_phases : 6; > uint8_t path_notification : 1; > uint8_t extra_features : 3; > } __packed; > > > void main() { > > struct packed_u8 data = { > .mitigation_time = 0xffff, > .current_rating = 0x3f, /* all 6 bits set */ > .num_phases = 0x3f, > .path_notification = 1, > .extra_features = 0x7, > }; > > printf("Akhil 0x%x\n", *((uint32_t *) &data)); > } > > The output I got in Kaanapali is: Akhil 0x7f3fffff > > This means that the compiler inserted a padding between current_rating > and num_phases. That's because __packed doesn't work outside the kernel - you're just creating a variable named __packed, so this is effectively the same as: struct foo { int a; int b; unsigned char c : 2; } __hotdog; int main () { printf("Akhil 0x%x\n", *((uint32_t *) &__hotdog)); } Outside the kernel tree, you need to use the full annoying __attribute__((foo)) syntax: include/linux/compiler_attributes.h:#define __packed __attribute__((__packed__)) with that changed, we get: Akhil 0xffffffff which is the expected behavior Konrad