From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753850AbdBUQ6B (ORCPT <rfc822;w@1wt.eu>);
        Tue, 21 Feb 2017 11:58:01 -0500
Received: from mail-qk0-f193.google.com ([209.85.220.193]:33785 "EHLO
        mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751555AbdBUQ5x (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Feb 2017 11:57:53 -0500
Date: Tue, 21 Feb 2017 13:56:41 -0300
User-Agent: K-9 Mail for Android
In-Reply-To: <1487693324.2885.17.camel@decadent.org.uk>
References: <20170216175259.514980415@linuxfoundation.org> <20170216175300.120096888@linuxfoundation.org> <1487693324.2885.17.camel@decadent.org.uk>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Subject: Re: [PATCH 4.4 14/20] sctp: avoid BUG_ON on sctp_wait_for_sndbuf
To: Ben Hutchings <ben@decadent.org.uk>,
        Alexander Popov <alex.popov@linux.com>,
        Xin Long <lucien.xin@gmail.com>
CC: stable@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
From: Marcelo <marcelo.leitner@gmail.com>
Message-ID: <210C5D26-C634-41E0-B744-1A7FA2AC157D@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1LGw5xu022572



Em 21 de fevereiro de 2017 13:08:44 BRT, Ben Hutchings <ben@decadent.org.uk> escreveu:
>On Thu, 2017-02-16 at 09:53 -0800, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me
>know.
>> 
>> ------------------
>> 
>> From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
>> 
>> 
>> [ Upstream commit 2dcab598484185dea7ec22219c76dcdd59e3cb90 ]
>[...]
>> --- a/net/sctp/socket.c
>> +++ b/net/sctp/socket.c
>> @@ -6960,7 +6960,8 @@ static int sctp_wait_for_sndbuf(struct s
>>  		 */
>>  		release_sock(sk);
>>  		current_timeo = schedule_timeout(current_timeo);
>> -		BUG_ON(sk != asoc->base.sk);
>> +		if (sk != asoc->base.sk)
>> +			goto do_error;
>
>This function normally returns with sk still locked, but in this case
>it returns with sk unlocked.  Perhaps this check should be moved after
>the lock_sock(sk)?
>

Looks like so. Will check more in a few. Thanks Ben

>Ben.
>
>>  		lock_sock(sk);
>>  
>>  		*timeo_p = current_timeo;
>> 
>> 

-- 
Enviado de meu dispositivo Android com K-9 mail. Desculpe-me pela brevidade.