From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD8032B119 for ; Wed, 3 Jun 2026 13:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780493544; cv=none; b=qmtsQzvoymdF+ob/QELs4P1Cmks2pdU87k1GhvK55TWmZBtYClXdSdjpbs6/4bkzBXmAaZv8VvjhS2EgFTN9zUB4IWD7CYg4+jqwcRZwcrotiWz1FtjIx86hBn8zXLT4Wrmp107MQtL9DiYOMQxn6gFoH0BghcMCjZn0o8jAuyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780493544; c=relaxed/simple; bh=nLwiq4xLtUJvJgZgyHsKU2B4tkPgwFhc/bYlFS6fzwU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dM6afpGh8Y7pxjVmw6sYhg8xJmEHS1l/KtPebkNi47vq6UPbeCDjbt/6ACYBCdxj8XIYNYSASXg3NPxVUYLFGau6z8IjPg2ZxlDKOAKE8hoVWSy5GF6jmI5bDQXKDuCeeKxGuKMK43a3du/j2cigWpDQ21sak0dOv8ifwUedVVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bDXvSyam; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FCdol5jx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bDXvSyam"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FCdol5jx" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 653D02LX1755366 for ; Wed, 3 Jun 2026 13:32:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SY9USAL7RV9vl/lzt+LH5AuybCAQ9ymalWYSS6pIv/E=; b=bDXvSyamrgGSWzjq AnXHZpkLtP5xQ0WFs3KZq34u7+xbgIp5xs7fceduy7C/Ira9gtuETM1tZHJ7DIVE IocjDuTDHEAYK+/XxCYmoLfKcbrZChLO8KWpbyeoTZnFdcwfsc69Xfw+xWkvai+Q fWueQkKDidvqCLYkcjH5lryxZmKoWgxFaEaHZgSN8FTpCZaw37S8XHrtNJseZOQt almutLV0AmsqcP0DEUo5WUBivWvde7KVLDSWq7tVkWBM+T3U8T6jng97p6X6Eh2f ajPBkdxVQXlW9JPbnBq70F4VJWaW/WgfxnYEJUgs0rW3IFRVGqWyfia/rNuIUYS7 fBXkog== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejff01ht6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 13:32:22 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c0bfcd629eso47020435ad.2 for ; Wed, 03 Jun 2026 06:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780493541; x=1781098341; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SY9USAL7RV9vl/lzt+LH5AuybCAQ9ymalWYSS6pIv/E=; b=FCdol5jxp+wct7bkM8LYT/MyZehr9HBaFio8V6aFHYn0Fz60DozNMyUAd06+wjmH7z U4jvd/NQ3k66fzXdbs0LcEEJURTd0tTyTAVMkLWRcH7iSFfdBRmpYVnxT4Z7hmSJSxzz pRwUixgb73pza8wZ9lkl2S/3vVxbsvN21w8QPFrcImDpQBE29BpdEIA/ayy/uFb/6Uyf VQ03FpTtog8aLnizvkgskuKp6tcZQHY2zcqzlV1B4EWy76z4vXs+zKBIwLzNTaK/CMiw KvwvZk3KQbrTMFhiWZgEO//P58N7ptc0rWdVe02A2HOkiv+x3Q3pT9hNWdsyqgiWt9Z+ f8rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780493541; x=1781098341; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SY9USAL7RV9vl/lzt+LH5AuybCAQ9ymalWYSS6pIv/E=; b=BTFQeQvOLXSf/cAcPm5w1OHgy/63v5Av67NB/APcPzdtY92HUHsGTdRE2CkvjG30Wc gvvYRCpd0ZhY2+jOtWh0wMqPK2OORoOAVa9hEx+WcriW96lIaCwzA2i+sIbFwMHuLd0v E//Lt2o/Hhssm5ZFAn2MfYtWu4v9R3p6uay8eV6I1wWZIKvGPLOFk/JAU2D0Mz2YB1X7 sSJiS0sjeiJJHM45BD88PPLo9tqurUyxOjuZgYNUzcIEE+sDzULjs7rVLDGTa7XHL23M K45ouQ6cLX4UBMw+Q0H1LDwfQYhT/1AaWQOWJxXVdFJT03P+Q91787z4QbU4+GG/mlPk yqIQ== X-Forwarded-Encrypted: i=1; AFNElJ8alxyUYkle3VwiYTd4Usi2G+GRrNEDmPZKtd29fULeOC8StGF2Sw4lz7sc9ky+9te9DqYOMfrJsipDBLA=@vger.kernel.org X-Gm-Message-State: AOJu0YyA3XDVVLHO/CLxwMQ55mt9kTb/xzELJAA2kaVvV/RBXU+wO2Cf d+ZWRFO9l1YaL0LviINsL1B6n3XdpuQCDbSSwbn9mPMCGuaxGs2pTTD/eVWTFI8bHdjlPuY0/ha cFawiJkRS0YqczpcypMhhOVOvCXB15YW0L+XNPV9aAHugnNZUfH3sOgujmYfCWCz62WZqedUiVM wGdA== X-Gm-Gg: Acq92OEaX2vHgaHnyT2Gg3r6HWA5OU1cR8bYubtDbBHaRMiZ0B1w7JgaowM7K+Vi2jS dCPxzola6+sFWlSQRRC/h8JSRZhyTGFxFr5gasRyWTqA6gra2sAFq+KzEqPk2U/a9HSDsvufYp9 nYOgCx70qkz42QHzf6O/5eWqbtarly+V/4hMc4LjMW8+ClLjCxMAFxqx4OcX5Myel1SzqKMEIS9 Fh/RPapmbV15A3yAmwS6dYCYWg+cTb4TYtHn6yt3eg7VqJIIi1qO62ei+YGtTskXpNeVWScyIZE nmgW3XTfBWO7+Sg1N/j4QZf8RwV+nx3IqbyL8xilXWaL7FDgPkwdhe1uGbJQ/KnMoaXIC+LYpFU DT1UtzU543zLEvx8GUYSsiSWBIyTI72vEBBL4hU2O2Vd+wZWcQjaLYoZVXJRL1g== X-Received: by 2002:a17:902:ce87:b0:2c0:d8ee:7d66 with SMTP id d9443c01a7336-2c1644cadb2mr32345475ad.36.1780493541376; Wed, 03 Jun 2026 06:32:21 -0700 (PDT) X-Received: by 2002:a17:902:ce87:b0:2c0:d8ee:7d66 with SMTP id d9443c01a7336-2c1644cadb2mr32345135ad.36.1780493540949; Wed, 03 Jun 2026 06:32:20 -0700 (PDT) Received: from [10.239.132.168] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f890b2sm26663615ad.26.2026.06.03.06.31.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 06:32:20 -0700 (PDT) Message-ID: <210cefc5-c9f2-49e2-b2f6-2a3c1a42218a@oss.qualcomm.com> Date: Wed, 3 Jun 2026 21:31:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] cpufreq: Documentation: fix freq_step description To: Pengjie Zhang , rafael@kernel.org, viresh.kumar@linaro.org, corbet@lwn.net, skhan@linuxfoundation.org Cc: linux-pm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, zhanjie9@hisilicon.com, prime.zeng@hisilicon.com, wanghuiqiang@huawei.com, xuwei5@huawei.com, lihuisong@huawei.com, zhenglifeng1@huawei.com, yubowen8@huawei.com, wangzhi12@huawei.com, zhongqiu.han@oss.qualcomm.com References: <20260603055635.1549943-1-zhangpengjie2@huawei.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <20260603055635.1549943-1-zhangpengjie2@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ba1xyMEfCkCasMgvWyxe6r-OUMNDfhXU X-Proofpoint-ORIG-GUID: ba1xyMEfCkCasMgvWyxe6r-OUMNDfhXU X-Authority-Analysis: v=2.4 cv=LYwMLDfi c=1 sm=1 tr=0 ts=6a202ce6 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=i0EeH86SAAAA:8 a=EUspDBNiAAAA:8 a=Zyhr3UL3YfEZVkCPdFoA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDEzMCBTYWx0ZWRfX1xeXXEEIFd71 O8vzzdPDyUTCo6S7aiMavfwmGFHROS0F1ZeOataM5bCAjGLn2oiFo442PbIZmVOD3FNNAbJt200 Q+W3wSIYdWiJe/LdPmWuazRG3M1+p1Zjdcaj06BgST5S0q5HLOoAzibGcGiNa2WOtPqvuX/eMar wAFQUA6JOpwDFEmTTVr4yaLaavrZ1iB3SsCZoV8B3MX6dtF5kT3zuuCsZBAapTRQhenVgrl07cr ko0cUC29W/0qKvApGNz8Ncql85Lbazm5XyY7NEeW2LNWe23scrESWJb+1uWMRmQHWsIrIKuU2OV UebGBkH/VBWX1J1ZENir3zSeq2s2mff53/a/MTu8q3x+W5o8zBtNuX+IW3As+gwhAl+eBIftOBn VuJfOh1cpUSn4J66smJGMK4J+6V5Kxolr53lgQjCil0fCCfNfHecizKqPNHZjqo09RnDnJusWy/ Vipnx75MkrEqnnqivAg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030130 On 6/3/2026 1:56 PM, Pengjie Zhang wrote: > The conservative governor documentation incorrectly states that setting > freq_step to 0 will use the default 5% frequency step. In reality, since > at least commit 8e677ce83bf4 ("[CPUFREQ] conservative: fixup governor to > function more like ondemand logic"), freq_step=0 has always caused the > governor to skip frequency updates entirely. > > Correct the documentation to reflect the actual behavior: freq_step=0 > disables frequency changes by the governor entirely. > > Fixes: 2a0e49279850 ("cpufreq: User/admin documentation update and consolidation") > Signed-off-by: Pengjie Zhang > --- > Changes in v2: > - Update commit message to reference the correct historical commit > 8e677ce83bf4 instead of b9170836d1aa, as the original implementation > had asymmetric behavior for freq_step=0 (suggested by Zhongqiu Han). > - Link to v1:https://lore.kernel.org/all/20260529111122.3321645-1-zhangpengjie2@huawei.com/ Looks good to me. Reviewed-by: Zhongqiu Han > --- > Documentation/admin-guide/pm/cpufreq.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/admin-guide/pm/cpufreq.rst b/Documentation/admin-guide/pm/cpufreq.rst > index dbe6d23a5d67..98c724d49047 100644 > --- a/Documentation/admin-guide/pm/cpufreq.rst > +++ b/Documentation/admin-guide/pm/cpufreq.rst > @@ -586,8 +586,8 @@ This governor exposes the following tunables: > 100 (5 by default). > > This is how much the frequency is allowed to change in one go. Setting > - it to 0 will cause the default frequency step (5 percent) to be used > - and setting it to 100 effectively causes the governor to periodically > + it to 0 disables frequency changes by the governor entirely and setting > + it to 100 effectively causes the governor to periodically > switch the frequency between the ``scaling_min_freq`` and > ``scaling_max_freq`` policy limits. > -- Thx and BRs, Zhongqiu Han