From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9223C3932FE for ; Wed, 4 Mar 2026 22:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772664946; cv=none; b=HMoNOGbfwSg3dEjFis8cTFY7p3J51XpiKVot5T8PtLyo5Lo4V4xVwSn+qJHbwjPZtIbOOymoHz4bvZTf62qS73v/f4yvxVd22Nmd/X3Y7IQqXRPx3N1x8K2/INGHiDVrI4S0Tl4LFxWLoTcEWhdGb38vADyY1tipkst4DirHqIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772664946; c=relaxed/simple; bh=8qlyvD5XDfMUAA6zmyrKLG7QhURU+8uccRHuRSqHzuI=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=ApZIbwLefepiLUcdSFhaTVAdPWobFe9+DfO9MZ19Amh362bpLQQ8iJke+8GW1ZUNKLRq2+iVtb1bt7ZrlYHkJ0VQYHUXKvoW/7i1flmB+ZeyR3yY+Onqk8RdoNt9YijR9gnk6/A9oDlZ/AErfE6KstM5QHGesmEaydpcXtp4Chs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=a5TzMh1M; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="a5TzMh1M" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-46392972257so5499165b6e.2 for ; Wed, 04 Mar 2026 14:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772664943; x=1773269743; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=b+2Q2TnBwC+gC1aFFNGwdS5pgVGKEvldXr6mdw0p25I=; b=a5TzMh1MBq5u/CaN3n7JZhnOAT/X4ZN2iUvlI6f+yxC43num+y1D3q7cDm5Liayqzi vWs+IuXATZdPGQnXtQYH5w/Si9mDm/zGBoJR0R/7FAA2QoiVnidoOvIW22fMS4zmgdLj wuhjNuOyPLrtbvw1G2z+tHyePr6lCR/DeYePzRizsUd+vLRixgwfBlF9iN317jhtglbQ wDMPF4KGbHrd0YCdeA8xt3sHXHW5WPi5a/iOp0qG+5ME0GNvii8QwH1RFpv4pFYss6Uq 3tNiwDGT7fNpmCfhPcGDvFHNk2XeKZaVzVkHQqO7XdadFCYyVUzpvsNkeRwquglb6v4l 2DQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772664943; x=1773269743; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b+2Q2TnBwC+gC1aFFNGwdS5pgVGKEvldXr6mdw0p25I=; b=ExhgNUWFpCHu+JdPD2s99RZS3v2uQgXfHFwgKJfUdn6DopdXBWhujsp9yKoBu5vbVK ZWSN1O8uiXEBXz9MlwkboEJWQVwK89Ubo4o3oMXREkT/kzThhcxnHHV+YBJG7gLw0V+E 7XITr+KVfaMaHZ1qWRn/Ee6x/n9bbKblGgBRM4t5SnSMep60WNj86AN1dDZfoZW1wAzG wwZG1uYszOBbyL514dFx1keZI3B+o+kibwh59D7Da2XRXbM3l4WOA2mNKzrEowh1n4+I scLzqxN55ZwerQ7jHleTO5JQbt/OqLgJWF/1pwSZWO+NvU52XrCAqGw6ukXf1G9Zc57b zOaA== X-Forwarded-Encrypted: i=1; AJvYcCVQ3R1zruB2zbyYE3GFBD3NKDl83PrivvdtFoup92kvYQVnveU7iYVmrlUQD5pUUxPc+I01NDidcWMoN0Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6L1CAHPsjER1ICZDjApycInji42yPlLZh3GGK14rZ8iN+gDOI vg4PDjBRaSBihT4rKOlZyzg2kiwj0YTW88au5L3tzJp0hDCaJWU7fxLv9Daz03qIcFY= X-Gm-Gg: ATEYQzyGeKls0KADs3c7U2sD8b1L8vQBEslEoIDzaMQEWvxGPhEC4ieTXVXZeONgoPX XhRS/W7LcPhThysbEADdE/VQnmG4kRTXh+Se5mW7QH3vME7XFdVTEVLAkHqVApnYpx0fOf6MgmA iku0R9YMoCFyCfc9eULY8hXtvqk8pbCv39gQD9mTFAcuWIHowWsSdovZWOacT5TLxnmak6BA/rx qUh8LleaknIGxJTguM+V+HCd6wAbW26e+QGogc311rbRTrIR/V1pdvEsahyW337sbwOWlXBZax9 x/Vdv8i2/Xr8DCEo+5T7Kq7OsCeaU86mI441SFu3/3Psq4+kxf3A2PDlPmI6TuR0kcAlYCFYpNu Qav93VrlD6th9s87QoA+l1+VlZ5TfTtWaKTCSksY6FNJ89oQPJ43vjItmmUS7xB6PrC7owtGQMz WQNqdJAp4cvWgJbSAIf9O2Vifmecp6Cp9BPZCswp5V2o0lrXQdXRYgX6Kck4UHKHbcw3nn6cjf3 iMxsFw8cbRE X-Received: by 2002:a05:6808:1693:b0:45e:e07d:4eff with SMTP id 5614622812f47-4651ab996camr1955205b6e.21.1772664943498; Wed, 04 Mar 2026 14:55:43 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:d719:8353:352f:b2e0? ([2600:8803:e7e4:500:d719:8353:352f:b2e0]) by smtp.gmail.com with ESMTPSA id 5614622812f47-464bb5e0b64sm12432933b6e.15.2026.03.04.14.55.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 14:55:43 -0800 (PST) Message-ID: <2110d3be-b55d-4b39-a8f4-ebf1312ada96@baylibre.com> Date: Wed, 4 Mar 2026 16:55:42 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/6] iio: Replace 'sign' field with union in struct iio_scan_type To: Francesco Lavra , Jonathan Corbet , Shuah Khan , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org References: <20260304080519.2844101-1-flavra@baylibre.com> <20260304080640.2844366-1-flavra@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260304080640.2844366-1-flavra@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/4/26 2:06 AM, Francesco Lavra wrote: > This field is used to differentiate between signed and unsigned integers. > A following commit will extend its use in order to add support for non- > integer scan elements; therefore, replace it with a union that contains a > more generic 'format' field. This union will be dropped when all drivers > are changed to use the format field. > > Signed-off-by: Francesco Lavra > --- > Documentation/driver-api/iio/buffers.rst | 4 ++-- > include/linux/iio/iio.h | 7 +++++-- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/Documentation/driver-api/iio/buffers.rst b/Documentation/driver-api/iio/buffers.rst > index 63f364e862d1..f36e6d00173f 100644 > --- a/Documentation/driver-api/iio/buffers.rst > +++ b/Documentation/driver-api/iio/buffers.rst > @@ -78,7 +78,7 @@ fields in iio_chan_spec definition:: > /* other members */ > int scan_index > struct { > - char sign; > + char format; > u8 realbits; > u8 storagebits; > u8 shift; > @@ -98,7 +98,7 @@ following channel definition:: > /* other stuff here */ > .scan_index = 0, > .scan_type = { > - .sign = 's', > + .format = 's', > .realbits = 12, > .storagebits = 16, > .shift = 4, > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h > index a9ecff191bd9..61f1dfc14e02 100644 > --- a/include/linux/iio/iio.h > +++ b/include/linux/iio/iio.h > @@ -178,7 +178,7 @@ struct iio_event_spec { > > /** > * struct iio_scan_type - specification for channel data format in buffer > - * @sign: 's' or 'u' to specify signed or unsigned > + * @format: (signed or unsigned) integer, or floating point We should keep the list of valid values here. > * @realbits: Number of valid bits of data > * @storagebits: Realbits + padding > * @shift: Shift right by this before masking out realbits. > @@ -189,7 +189,10 @@ struct iio_event_spec { > * @endianness: little or big endian > */ > struct iio_scan_type { > - char sign; > + union { > + char sign; > + char format; Could add some comments here to say that format should be used in new code and sign will be removed eventually. > + }; > u8 realbits; > u8 storagebits; > u8 shift;