From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933225AbbGUQjc (ORCPT ); Tue, 21 Jul 2015 12:39:32 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:54019 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755792AbbGUQj3 (ORCPT ); Tue, 21 Jul 2015 12:39:29 -0400 Date: Tue, 21 Jul 2015 18:38:44 +0200 (CEST) From: Stefan Wahren Reply-To: Stefan Wahren To: Srinivas Kandagatla , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org Cc: wxt@rock-chips.com, linux-api@vger.kernel.org, Rob Herring , sboyd@codeaurora.org, arnd@arndb.de, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, mporter@konsulko.com, linux-arm-msm@vger.kernel.org, Maxime Ripard , pantelis.antoniou@konsulko.com, Mark Brown , devicetree@vger.kernel.org Message-ID: <2114639619.71276.1437496724946.JavaMail.open-xchange@oxbsltgw08.schlund.de> In-Reply-To: <1437403462-4432-1-git-send-email-srinivas.kandagatla@linaro.org> References: <1437403352-4091-1-git-send-email-srinivas.kandagatla@linaro.org> <1437403462-4432-1-git-send-email-srinivas.kandagatla@linaro.org> Subject: Re: [PATCH v8 8/9] nvmem: sunxi: Move the SID driver to the nvmem framework MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.2-Rev24 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:ds75h4lRTXaiQDVMrcnfJVGV9uNzw2mIdU9CxrIxart6Zb19uFD TmnIjxPuKHrzw2LX+5yz14IGiKi3nr1spSyzdGw02Z80YLGwdqL+7MkfkI6bDFhIs6yi+TC lk8O7i4+OUE5P42LyLey43DNbXd0knFbwoC5+Y1ioEdQL2Hkjinog1iU3GEH+ewIchbw4hM PqkIpAYmxxQS5tg5JD9bQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:6rDkruLVqo8=:heuqR8RYaG3zUPPfaFhab+ chOxftUinighQQOpX/NL4M3NlqEU4x/89dyCKjIFPHP9yWZjj/mWCP7jgIt/aPqWig9+25aaF gWWsVFG1TdzQp+gkodA5Fub1kYrywxc+8jwd0KuFnzZq+i6nJGJbjZ6Nir1XW1TFtB8LswXql uu3+bn0MoFBXENzFV26C74bYqhbupksA8wkQ6jjb8JF5i2vL25gaM6qqEHN77mMoDe0xR9xdK gyI8bgCwUg4WmFLjLvLTfoC6H+oaZctSYdDemJ6LR60bQ+1whNi6hd5dmVJnPMQLiIMA+OmMc ne6tV0yv+qfVPTMJb+6ibLnfUvF86YkhTc/rHsazo1OWMb1NHwmhstrdh5UDqxC5E6XKC3sR3 SNivly4sXPAiJpYAdtS75IoktCEZKn0VUJDrAUDnNav6RG/Nqje8itZohu0GeGXasT1LIsa6b zkiY/4xeccVrep7DvvkgVtLQAMIJHlA6otBCUa9jMH6iDjZzgroQGaq152ke5ngccwz6fjYVd uq/7JeGof6ANPeKtcAn8vPSxxBFe+UUi3Jw2U2h5j5FREUNQX4UPcHl8n2zIeLJvolL88Sep2 3fBVhZ2aejTXP0lFJS1TJUCqTMJMNF0Mi92b2gwYTgLuikdD4wQhr/9FrCUfRoZKr/qbjc6Gn joUN+qFkf85fIe+RX0CwvYz4gxzaqxJhADEszp1J9xzzImg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Srinivas, > Srinivas Kandagatla hat am 20. Juli 2015 um > 16:44 geschrieben: > > > From: Maxime Ripard > > Now that we have the nvmem framework, we can consolidate the common > driver code. Move the driver to the framework, and hopefully, it will > fix the sysfs file creation race. > > Signed-off-by: Maxime Ripard > [srinivas.kandagatla: Moved to regmap based EEPROM framework] > Signed-off-by: Srinivas Kandagatla > --- > Documentation/ABI/testing/sysfs-driver-sunxi-sid | 22 --- > .../bindings/misc/allwinner,sunxi-sid.txt | 17 --- > .../bindings/nvmem/allwinner,sunxi-sid.txt | 21 +++ > drivers/misc/eeprom/Kconfig | 13 -- > drivers/misc/eeprom/Makefile | 1 - > drivers/misc/eeprom/sunxi_sid.c | 156 -------------------- > drivers/nvmem/Kconfig | 11 ++ > drivers/nvmem/Makefile | 2 + > drivers/nvmem/sunxi_sid.c | 159 +++++++++++++++++++++ > 9 files changed, 193 insertions(+), 209 deletions(-) > delete mode 100644 Documentation/ABI/testing/sysfs-driver-sunxi-sid > delete mode 100644 > Documentation/devicetree/bindings/misc/allwinner,sunxi-sid.txt > create mode 100644 > Documentation/devicetree/bindings/nvmem/allwinner,sunxi-sid.txt > delete mode 100644 drivers/misc/eeprom/sunxi_sid.c > create mode 100644 drivers/nvmem/sunxi_sid.c > > [...] > -static int sunxi_sid_probe(struct platform_device *pdev) > -{ > - struct sunxi_sid_data *sid_data; > - struct resource *res; > - const struct of_device_id *of_dev_id; > - u8 *entropy; > - unsigned int i; > - > - sid_data = devm_kzalloc(&pdev->dev, sizeof(struct sunxi_sid_data), > - GFP_KERNEL); > - if (!sid_data) > - return -ENOMEM; > - > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - sid_data->reg_base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(sid_data->reg_base)) > - return PTR_ERR(sid_data->reg_base); > - > - of_dev_id = of_match_device(sunxi_sid_of_match, &pdev->dev); > - if (!of_dev_id) > - return -ENODEV; > - sid_data->keysize = (int)of_dev_id->data; > - > - platform_set_drvdata(pdev, sid_data); > - > - sid_bin_attr.size = sid_data->keysize; > - if (device_create_bin_file(&pdev->dev, &sid_bin_attr)) > - return -ENODEV; > - > - entropy = kzalloc(sizeof(u8) * sid_data->keysize, GFP_KERNEL); > - for (i = 0; i < sid_data->keysize; i++) > - entropy[i] = sunxi_sid_read_byte(sid_data, i); > - add_device_randomness(entropy, sid_data->keysize); > - kfree(entropy); > - in case of porting a driver to a new framework, i would expect the same features. The ported driver do not add the Security ID to the device randomness. What's the reason for this difference? Regards Stefan