From: Dave Hansen <dave.hansen@intel.com>
To: Thomas Huth <thuth@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
Cc: Nicolas Schier <nicolas@fjasle.eu>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: Remove the arch_calc_vm_prot_bits() macro from the uapi
Date: Wed, 6 Sep 2023 10:01:20 -0700 [thread overview]
Message-ID: <2114d5c0-3903-f4be-795b-829c3a1e5f9f@intel.com> (raw)
In-Reply-To: <20230906162658.142511-1-thuth@redhat.com>
On 9/6/23 09:26, Thomas Huth wrote:
> The arch_calc_vm_prot_bits() macro uses VM_PKEY_BIT0 etc. which are
> not part of the uapi, so the macro is completely useless for userspace.
> It is also hidden behind the CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
> config switch which we shouldn't expose to userspace. Thus let's move
> this macro into a new internal header instead.
>
> Fixes: 8f62c883222c ("x86/mm/pkeys: Add arch-specific VMA protection bits")
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Gah, sorry this got dropped. I went to go throw it in my review queue
and saw your last version in there. I plan to apply it (this time)
shortly after we see -rc1.
In any case:
Acked-by: Dave Hansen <dave.hansen@intel.com>
next prev parent reply other threads:[~2023-09-06 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 16:26 Thomas Huth
2023-09-06 17:01 ` Dave Hansen [this message]
2023-09-06 21:57 ` [tip: x86/urgent] x86: Remove the arch_calc_vm_prot_bits() macro from the UAPI tip-bot2 for Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2114d5c0-3903-f4be-795b-829c3a1e5f9f@intel.com \
--to=dave.hansen@intel.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nicolas@fjasle.eu \
--cc=tglx@linutronix.de \
--cc=thuth@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®