From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D49C433FE for ; Thu, 23 Sep 2021 15:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19A9861019 for ; Thu, 23 Sep 2021 15:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241994AbhIWPgZ (ORCPT ); Thu, 23 Sep 2021 11:36:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36415 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241735AbhIWPgY (ORCPT ); Thu, 23 Sep 2021 11:36:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632411292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B6vU7I66Oh4IvVlNoUJK6FShhyszDTfSEBuK0IXxA/U=; b=IYxo3Y+iOYuE5tml4mU0gciEH4eHsQDvX45pUQswaxp++thszBWz9b6OkmcvcUmSA3VrLA izpc+yxLcpbSqBrNQJjHqNU/FB/gBxuqucPQ61Drplq7JDi02BfJ/lRUDDTB6iGST/SokF Q3g5BO1EtfnCZyCurAfSEkgiFAQVBRQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-b7CIvMhvNFKQwmWikgFKgg-1; Thu, 23 Sep 2021 11:34:50 -0400 X-MC-Unique: b7CIvMhvNFKQwmWikgFKgg-1 Received: by mail-wr1-f71.google.com with SMTP id f11-20020adfc98b000000b0015fedc2a8d4so5547431wrh.0 for ; Thu, 23 Sep 2021 08:34:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=B6vU7I66Oh4IvVlNoUJK6FShhyszDTfSEBuK0IXxA/U=; b=lymal6g1o9L/CK+QD/nw/Yy5LKceUXjP/Cu0Cf7gM4l5hMIPfYLDG0b1OcOI93Gdj/ cDEM3EF6KD+Wi2e24jeSPkFEuFYGqg+dcmEyXhXKY/fos1X6qEWcHsca7ekT6VDQajkS vpAFCngRgX1729XVM7cZ0xNLsBUZHD47Z8Xv/rOXuNOWVtJeo9ptgLM5DSfcLK5cyDpK Dc7XvLxUsaA4Q8TIa3UwoL2WY3v4MykdvX7MNt9E1lyMYoRmkNTSkPjUwzvAYri+87GD Y6A6w9xQLSzEjmiOeV3WHPpWgqLOxH67iqJnEABfuCFOCzyEc+4sTJ1j5ywBEx+CBI32 K35g== X-Gm-Message-State: AOAM5305tUMynEfDkdNNP5pQjb82dMnL/Eo+QHo5W9r3BuXRnKOgoejx ypPmFRtc0Rq4iAq9ZaBsnT083B0aMjow2NSoKNRXeaq677J8FzS9RibmdktD6vSnxH22xl6erBV /lGkH2FYvMutB9LNFSUlWU209 X-Received: by 2002:a05:600c:4a16:: with SMTP id c22mr16730727wmp.72.1632411289512; Thu, 23 Sep 2021 08:34:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBZhyVs/6Bg7XD0uHKGpE7WMvutAt47Dpksuv26PSDqXvvl4mTPp5CHm/1FAbKd+sEANHxSg== X-Received: by 2002:a05:600c:4a16:: with SMTP id c22mr16730710wmp.72.1632411289286; Thu, 23 Sep 2021 08:34:49 -0700 (PDT) Received: from [192.168.3.132] (p4ff23e5d.dip0.t-ipconnect.de. [79.242.62.93]) by smtp.gmail.com with ESMTPSA id b187sm9825989wmd.33.2021.09.23.08.34.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Sep 2021 08:34:48 -0700 (PDT) To: Kent Overstreet Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , Matthew Wilcox , Linus Torvalds , Andrew Morton , "Darrick J. Wong" , Christoph Hellwig , David Howells References: From: David Hildenbrand Organization: Red Hat Subject: Re: Struct page proposal Message-ID: <2116e35d-019d-67e3-e163-a0ef0a821a87@redhat.com> Date: Thu, 23 Sep 2021 17:34:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.09.21 17:22, Kent Overstreet wrote: > On Thu, Sep 23, 2021 at 11:03:44AM +0200, David Hildenbrand wrote: >> Don't get me wrong, but before there are answers to some of the >> very basic questions raised above (especially everything that lives >> in page->flags, which are not only page flags, refcount, ...) this >> isn't very tempting to spend more time on, from a reviewer >> perspective. > > Did you miss the part of the folios discussion where we were talking > about how acrimonious it had gotten and why, and talking about (Chris > Mason in particular) writing design docs up front and how they'd been > pretty successful in other places? > > We're trying something new here, and trying to give people an > opportunity to discussion what we're trying to do _before_ dumping > thousands and thousands of lines of refactoring patches on the list. > This here is different: the very basic questions haven't been solved. Folios compiled. Folios worked. I stopped following the discussion at one point, though. Again, don't get me wrong, but what I read in this mail was "I don't know how to solve most of this but this is what we could do.". Would we want to reduce the struct page size? Sure! Do we have a concrete plan on how all the corner cases would work? No. IIRC Windows uses exactly one pointer (8 bytes) to track the state of a physical page by linking it into the right list. So what would you say if I proposed that without tackling the hard cases? Corner cases is what make it hard. Memory holes. Memory hot(un)plug. Page isolation. Memory poisoning. Various memory allocators. Lock-free physical memory walkers. And that's all outside the scope of filesystems. -- Thanks, David / dhildenb