From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B15D5C433EF for ; Tue, 22 Feb 2022 17:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234509AbiBVRFp (ORCPT ); Tue, 22 Feb 2022 12:05:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232716AbiBVRFn (ORCPT ); Tue, 22 Feb 2022 12:05:43 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7A55D53B47; Tue, 22 Feb 2022 09:05:17 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2F9BB106F; Tue, 22 Feb 2022 09:05:17 -0800 (PST) Received: from [10.57.9.152] (unknown [10.57.9.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 144A33F70D; Tue, 22 Feb 2022 09:05:14 -0800 (PST) Message-ID: <211a3606-2f4c-227b-33aa-177ef68a49a3@arm.com> Date: Tue, 22 Feb 2022 17:05:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/2] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling Content-Language: en-US From: Lukasz Luba To: daniel.lezcano@linaro.org Cc: amit.kachhap@gmail.com, viresh.kumar@linaro.org, rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, dietmar.eggemann@arm.com, Pierre.Gondois@arm.com, Matthias Kaehlcke , Doug Anderson , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220207073036.14901-1-lukasz.luba@arm.com> <20220207073036.14901-2-lukasz.luba@arm.com> <4e090ffe-c19b-8e2c-0396-72dc33361f35@arm.com> In-Reply-To: <4e090ffe-c19b-8e2c-0396-72dc33361f35@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, gentle ping On 2/17/22 18:18, Lukasz Luba wrote: > Hi Daniel, > > > On 2/7/22 7:30 AM, Lukasz Luba wrote: >> The Energy Model supports power values either in Watts or in some >> abstract >> scale. When the 2nd option is in use, the thermal governor IPA should not >> be allowed to operate, since the relation between cooling devices is not >> properly defined. Thus, it might be possible that big GPU has lower power >> values in abstract scale than a Little CPU. To mitigate a misbehaviour >> of the thermal control algorithm, simply not register a cooling device >> capable of working with IPA. >> >> Signed-off-by: Lukasz Luba >> --- >>   drivers/thermal/cpufreq_cooling.c |  2 +- >>   drivers/thermal/devfreq_cooling.c | 16 +++++++++++++--- >>   2 files changed, 14 insertions(+), 4 deletions(-) > > The discussion in below this patch went slightly off-topic but it was > valuable. It clarified also there are no broken platforms with this > change. > > Could you take the patch into the thermal tree, please? > > Regards, > Lukasz