From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 785C1C433FE for ; Mon, 21 Feb 2022 13:43:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359300AbiBUNnX (ORCPT ); Mon, 21 Feb 2022 08:43:23 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359406AbiBUNlQ (ORCPT ); Mon, 21 Feb 2022 08:41:16 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB004220EE; Mon, 21 Feb 2022 05:40:52 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id A916B1F42EA1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1645450851; bh=+dtEQGc+iAoSujb9RCXxGPyqsje87DXa4PQPFCuMHGw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HXQCaEvDnJ7NxZe5NCiOQDyf1NUsnPaRQugb3WnTrumacN8l7UzYd0Z7qgwuQCi/U K39o8DEzFthVRDWbkZmBuUy7jwje8Sf20UjgI36pERPdJrJ7a2uJ+gpB3x6/VaLHJ0 HcnVCiu13CbeyZvR+Fc4UcHMmK+NKqITtiyMlYhNNkLvDiMZaw1pOjhrinAIiHdYzJ gheHCJMAgj9NpiWTP/YtNzz2JZrgmL61GSvSPUJfar52RExnaEjHokOaXpj3qzwy1o yBwDses2tMKGUrO5CdNEdA6WdiYQAKHH/RJDbxL8hBITdzdqAUzljuhRxJNvfB1Gtk OLao6gKl341Ug== Message-ID: <211bd3ca-f786-b161-6f3d-dc6b8471ffc7@collabora.com> Date: Mon, 21 Feb 2022 14:40:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 5/5] pinctrl: mediatek: common-v1: Commonize spec_ies_smt_set callback Content-Language: en-US To: Chen-Yu Tsai Cc: sean.wang@kernel.org, linus.walleij@linaro.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20220210141931.291712-1-angelogioacchino.delregno@collabora.com> <20220210141931.291712-6-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 21/02/22 10:58, Chen-Yu Tsai ha scritto: > On Thu, Feb 10, 2022 at 10:21 PM AngeloGioacchino Del Regno > wrote: >> >> All of the MediaTek pinctrl drivers registering with pinctrl-mtk-common >> that are offering a .spec_ies_smt_set() callback are declaring their >> own function which is doing exactly the same on all drivers: calling >> mtk_pconf_spec_set_ies_smt_range() with their struct and a simple check. >> >> Commonize this callback by adding the ies and smt structure pointers >> to struct mtk_pinctrl_devdata and changing the callback signature to >> take it. >> >> Removing the callback and checking for the existence of the spec_smt >> and/or spec_ies data would allow us to staticize the function >> mtk_pconf_spec_set_ies_smt_range(), but this solution was avoided as >> to keep flexibility, as some SoCs may need to perform a very different >> operation compared to what this commonized function is doing. >> >> Signed-off-by: AngeloGioacchino Del Regno > > Signed-off-by: Chen-Yu Tsai Hi Chen-Yu, did you mean Reviewed-by? :-)