mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpelinux@gmail.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Mikael Pettersson <mikpelinux@gmail.com>,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] ia64 ski emulator patches
Date: Sat, 25 Jan 2014 22:08:15 +0100	[thread overview]
Message-ID: <21220.10175.311714.796806@gargle.gargle.HOWL> (raw)
In-Reply-To: <alpine.LRH.2.02.1401251536550.27200@file01.intranet.prod.int.rdu2.redhat.com>

Mikulas Patocka writes:
 > 
 > 
 > On Sat, 25 Jan 2014, Mikael Pettersson wrote:
 > 
 > > My ski patches are in <http://user.it.uu.se/~mikpe/linux/patches/ia64/ski-1.3.2/>
 > > for now.  I'll post the kernel patches to linux-ia64 @ vger in a few minutes.
 > > 
 > > /Mikael
 > 
 > Thanks for the patches.
 > 
 > Isn't this subject to races? - could it lock up if the signal happens just 
 > before the pause syscall?
 > 
 > +    case SSC_HALT_LIGHT:
 > +      /* Sleep until SIGIO or SIGALRM is received; this relies on
 > +        keyboard/ethernet input being detected via SIGIO, and the
 > +        ITC now being emulated via setitimer() and SIGALRM.  */
 > +      pause ();
 > +      break;
 > +

Thanks for the review. You're right, the pause mustn't happen if
itc_itimer_fired == 1.  Let me ponder this for a while...

/Mikael

  reply	other threads:[~2014-01-25 21:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24  1:52 Mikulas Patocka
2014-01-24  1:52 ` [PATCH 1/5] ia64: limit stack size for the ski emulator Mikulas Patocka
2014-01-24  1:52   ` [PATCH 2/5] ia64 simeth: fix bugs in the ski emulator ethernet driver Mikulas Patocka
2014-01-24  1:53     ` [PATCH 3/5] ia64 simserial: fix sleeping with interrupts disabled Mikulas Patocka
2014-01-24  1:53       ` [PATCH 4/5] ia64 simscsi: fix race condition and simplify the code Mikulas Patocka
2014-01-24  1:53         ` [PATCH 5/5] ia64: fix warnings Mikulas Patocka
2014-01-24  2:07           ` [PATCH] ia64: validate user arguments in csum_partial_copy_from_user Mikulas Patocka
2014-02-07 16:05             ` Mikulas Patocka
2014-01-24 13:42 ` [PATCH 0/5] ia64 ski emulator patches Mikael Pettersson
2014-01-24 14:40   ` Mikulas Patocka
2014-01-25 17:51     ` Mikael Pettersson
2014-01-25 20:41       ` Mikulas Patocka
2014-01-25 21:08         ` Mikael Pettersson [this message]
2014-01-28 14:46           ` Mikael Pettersson
2014-01-24 17:33   ` Mikulas Patocka
2014-01-25 17:42     ` Mikael Pettersson
2014-01-24 22:59   ` Luck, Tony
2014-01-25 18:02     ` Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21220.10175.311714.796806@gargle.gargle.HOWL \
    --to=mikpelinux@gmail.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®