From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752717Ab3KYLXD (ORCPT ); Mon, 25 Nov 2013 06:23:03 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:49568 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751365Ab3KYLW6 (ORCPT ); Mon, 25 Nov 2013 06:22:58 -0500 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Lan Tianyu , Nishanth Menon , jinchoi@broadcom.com, Sebastian Capella , "Srivatsa S. Bhat" Subject: Re: [PATCH] cpufreq: suspend/resume governors with PM notifiers Date: Mon, 25 Nov 2013 12:35:44 +0100 Message-ID: <2123322.DfAe1RTUPo@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.12.0-rc6+; KDE/4.10.5; x86_64; ; ) In-Reply-To: References: <0e476d16e0ae4b001f5dd4f9ac191f899095928a.1384510171.git.viresh.kumar@linaro.org> <528F1FC9.4070306@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 25, 2013 09:55:19 AM Viresh Kumar wrote: > On 22 November 2013 14:41, viresh kumar wrote: > > So, what about something like this ? > > > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > > index f48370d..523c0bc 100644 > > --- a/drivers/base/cpu.c > > +++ b/drivers/base/cpu.c > > @@ -120,6 +120,45 @@ static DEVICE_ATTR(release, S_IWUSR, NULL, cpu_release_store); > > #endif /* CONFIG_ARCH_CPU_PROBE_RELEASE */ > > #endif /* CONFIG_HOTPLUG_CPU */ > > > > +int cpu_subsys_suspend_noirq(struct device *dev) > > +{ > > + struct bus_type *bus = dev->bus; > > + struct subsys_interface *sif; > > + int ret = 0; > > + > > + list_for_each_entry(sif, &bus->p->interfaces, node) { > > + if (sif->pm && sif->pm->suspend_noirq) { > > + ret = sif->suspend_noirq(dev); > > + if (ret) > > + break; > > + } > > + } > > + > > + return ret; > > +} > > + > > +int cpu_subsys_resume_noirq(struct device *dev) > > +{ > > + struct bus_type *bus = dev->bus; > > + struct subsys_interface *sif; > > + int ret = 0; > > + > > + list_for_each_entry(sif, &bus->p->interfaces, node) { > > + if (sif->pm && sif->pm->resume_noirq) { > > + ret = sif->resume_noirq(dev); > > + if (ret) > > + break; > > + } > > + } > > + > > + return ret; > > +} > > + > > +static const struct dev_pm_ops cpu_subsys_pm_ops = { > > + .suspend_noirq = cpu_subsys_suspend_noirq, > > + .resume_noirq = cpu_subsys_resume_noirq, > > +}; > > + > > struct bus_type cpu_subsys = { > > .name = "cpu", > > .dev_name = "cpu", > > @@ -128,6 +167,7 @@ struct bus_type cpu_subsys = { > > .online = cpu_subsys_online, > > .offline = cpu_subsys_offline, > > #endif > > + .pm = &cpu_subsys_pm_ops, > > }; > > EXPORT_SYMBOL_GPL(cpu_subsys); > > > > diff --git a/include/linux/device.h b/include/linux/device.h > > index b025925..fa01273 100644 > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -298,11 +298,16 @@ struct device *driver_find_device(struct device_driver *drv, > > * @node: the list of functions registered at the subsystem > > * @add_dev: device hookup to device function handler > > * @remove_dev: device hookup to device function handler > > + * @pm: Power management operations of this interface. > > * > > * Simple interfaces attached to a subsystem. Multiple interfaces can > > * attach to a subsystem and its devices. Unlike drivers, they do not > > * exclusively claim or control devices. Interfaces usually represent > > * a specific functionality of a subsystem/class of devices. > > + * > > + * PM callbacks are called from individual subsystems instead of PM core. And > > + * hence might not be available for all subsystems. Currently present for: > > + * cpu_subsys. > > */ > > struct subsys_interface { > > const char *name; > > @@ -310,6 +315,7 @@ struct subsys_interface { > > struct list_head node; > > int (*add_dev)(struct device *dev, struct subsys_interface *sif); > > int (*remove_dev)(struct device *dev, struct subsys_interface *sif); > > + const struct dev_pm_ops *pm; > > }; > > > > int subsys_interface_register(struct subsys_interface *sif); > > Any inputs? Please give me some more time, this suretly is not urgent? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.