From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757441AbbEVNWB (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 May 2015 09:22:01 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:65282 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757258AbbEVNV6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 May 2015 09:21:58 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Patrick Lai <plai@codeaurora.org>, Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Banajit Goswami <bgoswami@codeaurora.org>,
        Kenneth Westfield <kwestfie@codeaurora.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF
Date: Fri, 22 May 2015 15:21:49 +0200
Message-ID: <2125335.kSmCnV68xe@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <555F18C8.8090902@linaro.org>
References: <1432245125-8939-1-git-send-email-srinivas.kandagatla@linaro.org> <2534276.hIjFJK74Zh@wuerfel> <555F18C8.8090902@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:8L4NLtdgMby8hQ9VboLXEy5MYJAXwt1GuMZmkeKBDO9dpWGMPDL
 ZPeOi7FZ7983jLxHPnMBVkpgI/22lDKEoTV6HBXfJXoeeZwD5wMyMFpa5gjy6ScXGrITiGj
 LNuVLdj/7JGiTaljGTwEZ5HDoy3Rnyw1hly86XqW92GC7SfX0J3MR7KL/uCNhpohAYFyjpx
 FjgPj93iBOXsocQX0pxoA==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 22 May 2015 12:53:44 Srinivas Kandagatla wrote:
> Thanks for looking at this patch.
> 
> On 22/05/15 08:24, Arnd Bergmann wrote:
> > On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote:
> >>
> >>   config SND_SOC_LPASS_CPU
> >>          tristate
> >> +       depends on OF
> >>          select REGMAP_MMIO
> >>
> >>   config SND_SOC_LPASS_PLATFORM
> >>          tristate
> >> +       depends on OF
> >>          select REGMAP_MMIO
> >>
> >>   config SND_SOC_LPASS_IPQ806X
> >>
> >
> > Could you instead make the drivers compile without OF being set?
> >
> > I see that patch 7 and 8 introduces another two options doing
> >
> >
> > +config SND_SOC_LPASS_APQ8016
> > +       tristate
> > +       depends on SND_SOC_QCOM
> > +       select SND_SOC_LPASS_CPU
> > +       select SND_SOC_LPASS_PLATFORM
> > +
> >
> > +config SND_SOC_APQ8016_SBC
> > +       tristate "SoC Audio support for APQ8016 SBC platforms"
> > +       depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
> > +       select SND_SOC_LPASS_APQ8016
> > +       help
> >
> > so you get an obvious build failure here when SND_SOC_APQ8016_SBC
> > gets selected with COMPILE_TEST on a platform that does not support OF.
> >
> 
> Yes, this would fail.
> I think moving of_device_id structures in drivers under #ifdef CONFIG_OF 
> and removing the depends on OF would fix it.
> 

Why?

	Arnd