From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751647Ab3A2VoV (ORCPT ); Tue, 29 Jan 2013 16:44:21 -0500 Received: from hydra.sisk.pl ([212.160.235.94]:59444 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751155Ab3A2VoU (ORCPT ); Tue, 29 Jan 2013 16:44:20 -0500 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: inderpal.singh@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com Subject: Re: [PATCH 1/2] cpufreq: Set policy->related_cpus to atleast policy->cpus Date: Tue, 29 Jan 2013 22:50:30 +0100 Message-ID: <21265323.IYDsrYoA7t@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.8.0-rc5; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <2215618.GPIWS1OcnB@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 29, 2013 08:00:23 PM Viresh Kumar wrote: > On 29 January 2013 17:21, Rafael J. Wysocki wrote: > > On Tuesday, January 29, 2013 10:09:59 AM Viresh Kumar wrote: > >> With the addition of following patch, related_cpus is required to be set by > >> cpufreq platform drivers: > >> > >> commit c1070fd743533efb54e98142252283583f379190 > >> Author: Viresh Kumar > >> Date: Mon Jan 14 13:23:04 2013 +0000 > >> > >> cpufreq: Simplify cpufreq_add_dev() > >> > > > > I've dropped this one in the meantime. > > > > Can you please fold the $subject patch into "cpufreq: Simplify cpufreq_add_dev()" > > and post the result instead? That surely will be less confusing? > > Okay. I will squash this one with cpufreq_add_dev() one + following line: > > diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c > index 8ff26af..fc714a6 100644 > --- a/drivers/cpufreq/spear-cpufreq.c > +++ b/drivers/cpufreq/spear-cpufreq.c > @@ -189,7 +189,6 @@ static int spear_cpufreq_init(struct cpufreq_policy *policy) > policy->cur = spear_cpufreq_get(0); > > cpumask_copy(policy->cpus, topology_core_cpumask(policy->cpu)); > - cpumask_copy(policy->related_cpus, policy->cpus); > > return 0; > } > > > Also, because you are happy loosing your commit history in linux-next, > you can drop > the patch that i have reverted as 2/2 of this set. Well, I'm not attached to the linux-next commit history, but also it's a pain to change it too oftern. :-) I generally avoid changing it unless there are build issues and such that would cause pain to people doing bisection, for example. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.