From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751276AbaHMGkz (ORCPT ); Wed, 13 Aug 2014 02:40:55 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:50220 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbaHMGkx (ORCPT ); Wed, 13 Aug 2014 02:40:53 -0400 X-AuditID: cbfee61b-f79f86d00000144c-96-53eb08723c9c From: Bartlomiej Zolnierkiewicz To: Daniel Lezcano Cc: Kukjin Kim , Tomasz Figa , Marek Szyprowski , Krzysztof Kozlowski , Sachin Kamat , Kyungmin Park , Olof Johansson , Russell King , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] ARM: EXYNOS: Fix build with PM_SLEEP=n and ARM_EXYNOS_CPUIDLE=n Date: Wed, 13 Aug 2014 08:40:47 +0200 Message-id: <2126575.mQYDXuNU1Q@amdc1032> User-Agent: KMail/4.8.4 (Linux/3.2.0-54-generic-pae; KDE/4.8.5; i686; ; ) In-reply-to: <53EA7DC8.6040801@linaro.org> References: <1407856317-2457-1-git-send-email-b.zolnierkie@samsung.com> <1407856317-2457-2-git-send-email-b.zolnierkie@samsung.com> <53EA7DC8.6040801@linaro.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=UTF-8 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t9jQd0ijtfBBjsuyVjM+yxr8fqFoUXv gqtsFmeb3rBbbHp8jdXi8q45bBYzzu9jslh75C67xanrn9ksNn94yWZx5dIpNov1M16zOPB4 tDT3sHncubaHzWPzknqPKyeaWD36tqxi9Pi8SS6ALYrLJiU1J7MstUjfLoEr42LTTdaC9bwV +06lNDBe4+pi5OSQEDCR2Nf6lxXCFpO4cG89WxcjF4eQwHRGiW2fD7NAOC1MEuuXz2IDqWIT sJKY2L6KEcQWEdCTaHzfxgRiMwvsYJZ48iwcxBYWiJV4/mAOWA2LgKpE15VNLCA2r4CmxI+P 78DqRQU8JXZsXwk2k1NAS2LC/F9Qm5cySjTc/M8K0SAo8WPyPRaIBfIS+/ZPZYWw1SUmzVvE PIFRYBaSsllIymYhKVvAyLyKUTS1ILmgOCk910ivODG3uDQvXS85P3cTIzg6nknvYFzVYHGI UYCDUYmHd4frq2Ah1sSy4srcQ4wSHMxKIrwOW4BCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeQ+2 WgcKCaQnlqRmp6YWpBbBZJk4OKUaGKUsftVc6Wa+db1AKfTe8YdfMhenyn1V0f2pHjF5kkhc +Enlq2XlO+aYeuQKzBYQclzz7pmmN+uShXH+EV4Pm1/8kv16wkn+xI2qRqfi8tNRRXW3jwTO X27KEx5cKJX9fC9fSuP25I1H4pZbN6qpHZqXGnNFzaMt/OWLI1YXlDZ1zZ609bHQQyWW4oxE Qy3mouJEACkmqg2KAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, August 12, 2014 10:49:12 PM Daniel Lezcano wrote: > On 08/12/2014 05:11 PM, Bartlomiej Zolnierkiewicz wrote: > > Fix building of exynos_defconfig with disabled CONFIG_PM_SLEEP by > > adding checking whether Exynos cpuidle support is enabled before > > accessing exynos_enter_aftr. > > > > The build error message: > > arch/arm/mach-exynos/built-in.o:(.data+0x74): undefined reference to `exynos_enter_aftr' > > make: *** [vmlinux] Error 1 > > > > This patch has been tested on Exynos4210 based Origen board. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > Acked-by: Kyungmin Park > > --- > > arch/arm/mach-exynos/exynos.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > > index 6a24e11..d57f136 100644 > > --- a/arch/arm/mach-exynos/exynos.c > > +++ b/arch/arm/mach-exynos/exynos.c > > @@ -161,7 +161,9 @@ static void exynos_restart(enum reboot_mode mode, const char *cmd) > > > > static struct platform_device exynos_cpuidle = { > > .name = "exynos_cpuidle", > > +#ifdef CONFIG_ARM_EXYNOS_CPUIDLE > > .dev.platform_data = exynos_enter_aftr, > > +#endif > > .id = -1, > > }; > > This patch does not address the real issue of the compilation error. The > cpuidle driver needs the exynos_enter_aftr function in order to work > correctly. Hence the Makefile should be fixed in order to compile pm.o > if cpuidle or pm_sleep are set. Please take a look at patch #3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics