From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755664AbcEEN5T (ORCPT ); Thu, 5 May 2016 09:57:19 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:43011 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752377AbcEEN5R (ORCPT ); Thu, 5 May 2016 09:57:17 -0400 From: "Rafael J. Wysocki" To: Stephen Boyd , Viresh Kumar Cc: Viresh Kumar , Nishanth Menon , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, Marc Gonzalez , linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM / OPP: Remove useless check Date: Thu, 05 May 2016 16:00:29 +0200 Message-ID: <2129933.pyMPGBNMHq@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160504182127.GR3492@codeaurora.org> References: <080908c24c189b44442b2fee7be83e760a6dac49.1462367990.git.viresh.kumar@linaro.org> <20160504182127.GR3492@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, May 04, 2016 11:21:27 AM Stephen Boyd wrote: > On 05/04, Viresh Kumar wrote: > > Regulators are optional for devices using OPPs and the OPP core > > shouldn't be printing any errors for such missing regulators. > > > > It was fine before the commit 0c717d0f9cb4, but that failed to update > > this part of the code to remove an 'always true' check and an extra > > unwanted print message. > > > > Fix that now. > > > > Fixes: 0c717d0f9cb4 ("PM / OPP: Initialize regulator pointer to an error value") > > Reported-by: Marc Gonzalez > > Signed-off-by: Viresh Kumar > > --- > > Reviewed-by: Stephen Boyd Applied, thanks!