From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA1812D2384 for ; Fri, 19 Dec 2025 08:08:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766131700; cv=none; b=CttRODla0vmgOvYXzkA9DB2O4cuEpfw7LyEZcY/BIV3sZdimpokn0dHP3ee2LJWHL+gxmOzUqzA/W3L4YTqi9n7vxB/8j76yCwMRsFDvfiv8dR2XiR4VgNes+kRY3Co9TFx9A/1rfHPmPPFupaa6dAtuJd8dXSDC7hiPnWjUpjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766131700; c=relaxed/simple; bh=8udCBDJHixWYZ9BHIHwvKAqzaP5NF/DkqRjG+1eXjBI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i9Q93Q6dWdl8H6qjuc++JZAq8sRjBbyBQlwKJ3lr6YkRag4sd0hedlpdarxgjOT8Cmv/bqslvfYxN+Xya/Vo1/uHOs4pDPE4qLjJL0nFXB64xtfClGGIXVpzOjSkIO+oizL+KO96Z+ylQxKJ6DJql6qDZmd4RQx00X/J2LoqTSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=lMO9chE9; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="lMO9chE9" Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DD5F83FCC7 for ; Fri, 19 Dec 2025 08:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1766131690; bh=EaxKPv8EzMQw4Q+d/tnNq9TX6lEJW/rr1OxXypt8e2A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lMO9chE9CcnVozxEYLHoj4xFpT1kl3IskAJ3/7366fiBllXxh85PbwM5l0L21nAxi kveo6QHHrBaaNckQ9Bi8YvvjL8P9o+j793sFO3xmBJbT59h86Z+VDZq+ElTmgcJfuz 68tR5M1xM5GiUqaXs277UbQkeWZfb1/qJCrkQJXSvGBFJLP7dSqQ/pHx6FJM0j8RP+ /+WmTHSF844Wh7jvZxoUDTHq5E43NVLDyHYl/0epFZmfS9bcH+HvQxWPTIa/Bv1kEB ZmPudXl3Of8tNNpQ4DfmeygGGuidzoUl/Gk57i0o62qRxymPATEqaQ7Irgoe3oXziE 8MCss7G3kAQ7B5FiinJt62iv+RWAOVmeedSFHfhifI/Vn9eLBgWuRRuaKx7P4v/xf7 lveNktI8e0G8AyZJMbU+djvve4d6KXQmeIMEHEuYfDD6fAhqQB1O57JhAgb8h6jsWJ 44ZVR2GxTTl0jWh1YakMkXlxgAQDw+iFL3vd0EvBmzNNSfNYD5SfD9o0jll/LgCIR+ Ne4ZbQ++AsjXQ05i+ooBqv4i6ENQ9D7o9Ra8nmkCKeffO/IsXmSzKDCpoTXu9mKZhf Aeie9E8yHXg6uBmx69uN2jtnDu1PjhPicgX4OJfE5O5WSeMnkx1lNKtIAKVGMKLy/+ sDa+8XYzY1uiRoa5xUabefr4= Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-430fd96b440so725022f8f.1 for ; Fri, 19 Dec 2025 00:08:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766131690; x=1766736490; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EaxKPv8EzMQw4Q+d/tnNq9TX6lEJW/rr1OxXypt8e2A=; b=CF9LDG/SMd8ec4dMVlzn++Jp3N4ykYvBeLO5Je3B6WVk3zpUQqbNcGH9zyTwTCtU8s /lB6lU/pxbnyuZ21DopS0LIhIJUAEL1KvB/DTNUP1UYIzvOFWEWyNZpYXPy5Zk+kDMwM o1BlKb6Be+aTG/VGKTMwHHf0WliBUmTm4WG+XOGCKsVGNCMfxPAbiT/mEAwJG0+70qt1 InZ7CApfbn8RM8Y/VQTkuAPckY1WO2AK327YQKQpP4oY+PWuPf8wZb0CdevxNZpAp6eM DcqrZUJ0n+292rUCwcX5X169Yhs9UYeKem2S4u/rYD5bV/tcS3TxYtzrdKmWP5NaLUZP A6tw== X-Forwarded-Encrypted: i=1; AJvYcCXxamq8s1gqZ/puM8ycNRBQcZ2DKGkLFCRR5viuEVyTh6E8lsplyk4nTUin25CCbnyF16NcYN0azU7K9v4=@vger.kernel.org X-Gm-Message-State: AOJu0YzPAB18r+kb637hDFz/Qqup6ymZA2QXlNmefKTLCKtCpg0uE9YF 9luENGA3LTH1h+JnI+ppUNDZaP6S/TBXAxaAyhR5QzllxBCjhjjM6BJZ9dauqtrQlfxb5T4fiWw c0AdV2sRVzk1Xu1sRgy+hnshrYntDjPdRLNnSDVjSoZdghsE+xGUqvKuYvOVhpWGlUDQGVdfKaX tZRqv67Q== X-Gm-Gg: AY/fxX7kr+PsVyug04okoGOfkIk1v4PMAL4vqdeeQSEmGBvj0enljX1LLVRBeFjc/VY EO3Sq0UbrPkIbXtXEWbXVV3Z90JMaIBK0cBnPDEQ460uocV5+dr94K5DceR+LO5x0cqDL1TvBbI wOpMLVG8c38S2dpJGH92B2+dPFLdeN6BcR2jgOtv9g79cnP2WWLqtniF3025ZGQRtcALN2bTLSV LuCO2daum6KO1+9aua7hk/WfiflW237LSoRPtJRi2vd93+aF0NyXgw33gD5a8PsX2t+Ku+zi0xF 2T6kKwcJvPN9+wrUEzv6Iz94qzYrYwWw6WEealvqfLN+FTps+U9Wdu4q0HNYMGg5g6fq/NDfXpi Nd69YWJjPFQJRUR/jC5G6HL95+tbQaN8upNg1i65elR4HgkqUfWTm7JVItgJAH8XK/6NNnc2eRR V9ezx66RE= X-Received: by 2002:a05:6000:1a8d:b0:430:f6ad:1814 with SMTP id ffacd0b85a97d-4324e7045eemr2091913f8f.58.1766131689914; Fri, 19 Dec 2025 00:08:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+g+eItW+D6N0t8wn4CUhhQAlan/FWbDAzi/nwqnnLL5ClhWb3g9EwyncInKQ4MUzOoaMdTA== X-Received: by 2002:a05:6000:1a8d:b0:430:f6ad:1814 with SMTP id ffacd0b85a97d-4324e7045eemr2091855f8f.58.1766131689463; Fri, 19 Dec 2025 00:08:09 -0800 (PST) Received: from [192.168.123.154] (ip-005-147-080-091.um06.pools.vodafone-ip.de. [5.147.80.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea2267fsm3416457f8f.12.2025.12.19.00.08.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 00:08:08 -0800 (PST) Message-ID: <212e6371-245e-4f44-98a0-5e1db47222a1@canonical.com> Date: Fri, 19 Dec 2025 09:08:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] riscv: dts: spacemit: add initial device tree of SpacemiT K3 SoC To: Guodong Xu , Conor Dooley Cc: Paul Walmsley , Palmer Dabbelt , Kevin Meng Zhang , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev, linux-serial@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , Daniel Lezcano , Thomas Gleixner , Samuel Holland , Anup Patel , Greg Kroah-Hartman , Jiri Slaby , Lubomir Rintel , Yangyu Chen References: <20251216-k3-basic-dt-v1-0-a0d256c9dc92@riscstar.com> <20251216-k3-basic-dt-v1-7-a0d256c9dc92@riscstar.com> <60948ca2-ed3d-485b-9b11-15df7ef8791d@canonical.com> <20251218-basil-quantum-225ce16e4699@spud> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/19/25 03:03, Guodong Xu wrote: > Hi, Conor and Heinrich > > On Thu, Dec 18, 2025 at 8:56 AM Conor Dooley wrote: >> >> On Wed, Dec 17, 2025 at 09:07:14AM +0100, Heinrich Schuchardt wrote: >>> On 12/17/25 08:11, Guodong Xu wrote: >> >>>> Specifically, I must adhere to >>>> Documentation/devicetree/bindings/riscv/extensions.yaml (and cpus.yaml for >>>> properties like 'riscv,sv39' which stands for the extension Sv39). If I >>>> add extension strings that are not yet defined in these schemas, such as >>>> supm, running 'make dtbs_check W=3' fails with: 'supm' is not one of >>>> ['i', 'm', 'a', ...], followed by "Unevaluated properties are not allowed." >>> >>> If Documentation/devicetree/bindings/riscv/extensions.yaml is incomplete >>> with respect to ratified extensions, I guess the right approach is to amend >>> it and not to curtail the CPU description. >> >> Absolutely. If the cpu supports something that is not documented, then >> please document it rather than omit from the devicetree. > > Thanks for the review. May I clarify one thing? Both of you mentioned > document them, given the amount of missing extensions, is it acceptable if > I submit a prerequisite patch that only documents these strings in > riscv/extensions.yaml plus the necessary hwprobe export? Leaving the actual > usage of these extensions (named features) to the future patches. Adding the missing extensions to Documentation/devicetree/bindings/riscv/extensions.yaml is what it takes to describe the K100 cores in the device-tree. Discovering the new extensions as CPU features and exposing them via hwprobe is probably best handled in a separate patch series. Best regards Heinrich > > To provide some context on why I ask: I've investigated the commits & lkml > history of RISC-V extensions since v6.5, and I summarized the current status > regarding the RVA23 profile here: > [1] status in v6.18 (inc. v6.19-rc1): > https://docularxu.github.io/rva23/linux-kernel-coverage.html > [2] support evolution since v6.5: > https://docularxu.github.io/rva23/rva23-kernel-support-evolution.html > > Strictly describing the SpacemiT X100/K3 (or any core) as RVA23-compliant > requires adding these extensions that are currently missing from > the kernel bindings: > RVA23U64: Ziccif, Ziccamoa, Zicclsm, Za64rs > RVA23S64: Ss1p13, Ssccptr, Sstvecd, Sstvala, Sscounterenw, Ssu64xl, > Sha, Shcounterenw, Shvstvala, Shtvala, Shvstvecd, Shvsatpa, Shgatpa > Plus 'Supm', 'Zic64b', 'Ssstateen', 'B' where the kernel supports them but > they are not literally documented in yaml. > > Is this approach acceptable to you? If so, I will proceed with submitting them. > > Thank you very much. > > Best regards, > Guodong Xu