From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: valdis.kletnieks@vt.edu, artem.savkov@gmail.com,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
robin.randhawa@arm.com, Steve.Bannister@arm.com,
Liviu.Dudau@arm.com
Subject: Re: [PATCH 0/4] CPUFreq Fixes for 3.9
Date: Fri, 08 Feb 2013 13:32:39 +0100 [thread overview]
Message-ID: <2130803.VQA31hf2jE@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpomrLAQiP58+OVBrm3jb8rd5DK3z+7_kyB_MsKM7UyyWRw@mail.gmail.com>
On Friday, February 08, 2013 08:20:55 AM Viresh Kumar wrote:
> On 8 February 2013 05:03, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > I should have done that before, sorry about it.
> >
> > Can you please rework this series on top of linux-pm.git/pm-cpufreq and
> > try to avoid introducing new issues this time?
>
> Even i want to do that, but when i fetch your repo i don't see all applied
> patches in this branch.
The top-most commit in that branch is
commit 73bf0fc2b03d1f4fdada0ec430dc20bfb089cfd5
Author: Viresh Kumar <viresh.kumar@linaro.org>
Date: Tue Feb 5 22:21:14 2013 +0100
cpufreq: Don't remove sysfs link for policy->cpu
because that's when the locking problems were first reported and I stopped
putting new commits into that branch. And since the locking problems were
introduced by b8eed8a "cpufreq: Simplify __cpufreq_remove_dev()" I want them
to be fixed on top of pm-cpufreq rather than on top of more new stuff that
very well may introduce *more* problems.
So as I said, please rework the fixes on top of linux-pm.git/pm-cpufreq.
Moreover, I'd very much prefer it if you fixed the problems introduced by
b8eed8a "cpufreq: Simplify __cpufreq_remove_dev()" separately and *then* any
other locking problems you're seeing in the code, although people are not
reporting them.
You seem to have a clear picture of how the code should work now, so that
won't be a big trouble I guess.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-02-08 12:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 10:27 Viresh Kumar
2013-02-07 10:27 ` [PATCH 1/4] cpufreq: governors: Fix WARN_ON() for multi-policy platforms Viresh Kumar
2013-02-07 10:27 ` [PATCH 2/4] cpufreq: Remove unused HOTPLUG_CPU code Viresh Kumar
2013-02-07 10:27 ` [PATCH 3/4] cpufreq: Create a macro for unlock_policy_rwsem{read,write} Viresh Kumar
2013-02-07 10:27 ` [PATCH 4/4] cpufreq: Fix locking issues Viresh Kumar
2013-02-07 13:05 ` [PATCH 0/4] CPUFreq Fixes for 3.9 Rafael J. Wysocki
2013-02-07 13:22 ` Viresh Kumar
2013-02-07 23:07 ` Rafael J. Wysocki
2013-02-08 2:49 ` Viresh Kumar
2013-02-08 5:09 ` Viresh Kumar
2013-02-08 6:27 ` Artem Savkov
2013-02-07 19:39 ` Artem Savkov
2013-02-08 2:52 ` Viresh Kumar
2013-02-07 23:33 ` Rafael J. Wysocki
2013-02-07 23:48 ` Rafael J. Wysocki
2013-02-08 2:50 ` Viresh Kumar
2013-02-08 12:32 ` Rafael J. Wysocki [this message]
2013-02-08 14:36 ` Viresh Kumar
2013-02-08 20:02 ` Rafael J. Wysocki
2013-02-08 23:56 ` Rafael J. Wysocki
2013-02-09 0:08 ` Dirk Brandewie
2013-02-09 0:21 ` Rafael J. Wysocki
2013-02-09 2:10 ` Viresh Kumar
2013-02-09 11:44 ` Rafael J. Wysocki
2013-02-08 5:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2130803.VQA31hf2jE@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=artem.savkov@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robin.randhawa@arm.com \
--cc=valdis.kletnieks@vt.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®