From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932866AbdK2OEj (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 09:04:39 -0500
Received: from mout.web.de ([217.72.192.78]:50614 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752559AbdK2OEh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 09:04:37 -0500
Subject: Re: [3/3] pinctrl: mcp23s08: Combine two function calls in
 mcp23s08_dbg_show()
To: Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <ca1c3c19-7e8c-90f0-493c-b6fae04e6a03@users.sourceforge.net>
 <0510a811-e653-6310-5c7f-8d6434efca2a@users.sourceforge.net>
 <CACRpkdaoUad0i3Kddyp0aJRJ46frHMY9_57mwM3iXAhqL5V3aA@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <2132d281-c4da-81b0-6dc7-4b42807cebf0@users.sourceforge.net>
Date: Wed, 29 Nov 2017 15:04:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CACRpkdaoUad0i3Kddyp0aJRJ46frHMY9_57mwM3iXAhqL5V3aA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:cf+5V7RKdILMxwzhqDREGSUQivR/YlytfE6QVmygPQkqjb7YJYH
 sfpB+oCYr+IT+2RNZlrx7/sdkbI8f477RIcEQkXk2Vsl0NgDXQtraP3RFT8CtmS4IzdV+oF
 uexc92waQkvlueQHnzoWBeLHDZ9ZIci6T4iiuAHdEAibhmWlEus7zMgt5KfshnSHNcHuqmX
 RCRIH0f4sSGCSvNLnzQcg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:1TRUIGECU5A=:J8wlPqd5zq0b62msDRAy4m
 XC6yPUV7PCxv2dZusIPZL4o7aowd9obooIa1qUWkcOItnYXP3TMyXbG5zgeDrGf+CF/17aoXh
 c//FYNrTMxo5g+3LZoZx4wDpZBpY52on/6AredKgqHBHEl/2ShHiF6LFDlAjG0RWjABckBaUs
 nrKm2M25Zdd0ckBs1fMCTkKb/B0Alvp2bP+rNIjwj4uIHyT522lYkc+QW/BKcDnq7bRFGXc46
 pLFv3CnAklJQoaLF2kKUua8MSTWh6Bjwg7f36uHO/+HJYmiNVUl5WPn1NvJVzgj7YRpBYvtxs
 nOuqmeSyQ3GffoUUSOA2QuGNe0zYtlPv2dDTCo+BFkQf/dH4xLFL2fxUdVkGLnPaEunQ/mpzQ
 +msXibo+hj81GmiG7zO2UhIpos4h7T2aN6yxd2T7uGiW+3v6dgOSo1rZnhnTiWhDdPdq5Fgm7
 zWrYpWH7aPP8WReovvYKV2Fm2kCpCEzt6MevobfhVuMpntRmWpbUtLKRHSWfnsCEgGl81s84Y
 WU9gkYZPBYCabi/HBbMVYDsRUNqTwjqdkQapZw8YfR7C+aJdhRk88siZ91PD6Xee+8KNscRix
 M/phr7Ow0lyf+SAcOLi4H679/GXLTh8xoN7iscjPUiJILIYoQTMu1Sfq7QB2eGRzCWp9Y57pf
 +FQFTGBZHzdgymxi58iQnK0uwMbXbQssiYeyjSQiy+H3i6tAG2rFElkOVxhgdI2wjrPF7LyRS
 ySzPlu7Ym9Kw4ryhUfqsaOyxGFDCuJ+9v+cLSK+hKqFnVdxSEXH8QlV9Bvo83z4cqyqlH6TE6
 z9XUykH/XLp4Csi9vkzxfkYDrOlVTw7K3BCf+bVp8grJhpyv0A=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> * Print a line break together with other data in a single function call.
>>
>> * Adjust indentation.
…
> 
> This does not apply.
> Possibly depends on 2/3.

Partly, yes.


How do you think about the following possibilities?

* Omit two context lines at the end from this update step.
  or
* Refer to the jump label “done” (instead of renaming it to “unlock” before).


Would you try once more to integrate the shown small change?

Regards,
Markus