From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932685AbcHKL4E (ORCPT ); Thu, 11 Aug 2016 07:56:04 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:53762 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932369AbcHKLz5 (ORCPT ); Thu, 11 Aug 2016 07:55:57 -0400 From: Arnd Bergmann To: Johannes Berg Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-sparse@vger.kernel.org, Johannes Berg Subject: Re: [PATCH] byteswap: don't use __builtin_bswap*() with sparse Date: Thu, 11 Aug 2016 13:55:48 +0200 Message-ID: <2133648.lb1RCaYlXp@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1470914102-26389-1-git-send-email-johannes@sipsolutions.net> References: <1470914102-26389-1-git-send-email-johannes@sipsolutions.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:sS46KYEm9holrl51Emh17IVkrr/a/aDd9FAUENkbUbErdyg/IrT aZ4Vbupr8aePml16MWSMdtPDNK/UjhiTZbqiQNFPVSe7XtQ8iFz9qQnLmefGaoCQMZgD8x9 WZmujaPABFlt84nO5pmPdNfJYtAtzZNMa5BXp9VjWVJjho4DMjuM+ASO8PFTgpJpsgTHFXu MSnSr97EN7KPNT8RtRsVQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZQD7qC1A0QA=:PADU1/nmpRBO9R9BWlBUkG bLHhXPyo1MKpxnmliOX8K6A5MoXqDFo04IVjwItg2h7CBRWg5nQpTscpYzbDY9dwhnYHOnD/f qBVWAZzGoINd4Jh76ZXvYcnLB3DUnGysR4M+MDHCmzMgpiw5u6jH/Zyu41aT6aHBbANg7UKHj ZdRS7yCUAndINvpYzhtDu+wkO/4+vLFGMbjO4ZJcly3hu9AgYmFDOj7/qbyJeCpAi2Wl9wxIR aGzbLVP/0Mk1+8OoC+nuibLCud3cPuOGRPwPLGgyyw/2ZUplCWb2yQ/8WiQG9TDFcgPIs1WT/ O7AvKYXYwnjXFEF0PXFFCu2d/x/JORLQoaZ+0tzzWikfoJDceT55mW51blU388aKmBYDc6Coj p5XQC7nZZABZ6HSjbBH8dWOJnyyqnFoweLVvYT+brOZAaI/8nBtfib0moSCcXBstlGY2RGAIr /WbofCfWoQrMssxrc4G3Jyr5TGgUkFtN3B2hCYbeLgEd5OfxwWn1NPigxLmGRljMj8uFo5VJe 0ss9LHQa6p4eGtC49UoSZnwH4E4LdRNwFa6mJ7giRDLjETY/041iotUKWS7QVb0/oc6M/Ld5w hQgLu41kYsgz62GhDGvTzvPB5L/cAGW/RHvB0+jqLmmQ2PVNl/JHnJLIb2QwBg9vQQB0vjhD1 ONOWOWBnypW9JX3SbolwJSToso8LhBCzqISuvQ60pP/x/Yuxe6ghScXrPAW+Z6BClJEJhZWyF mkqJrGMvU1RyMMbL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 11, 2016 1:15:02 PM CEST Johannes Berg wrote: > From: Johannes Berg > > Although sparse declares __builtin_bswap*(), it can't actually > do constant folding inside them (yet). As such, things like > > switch (protocol) { > case htons(ETH_P_IP): > break; > } > > which we do all over the place cause sparse to warn that it > expects a constant instead of a function call. > > Disable __HAVE_BUILTIN_BSWAP*__ if __CHECKER__ is defined to > avoid this. > > Cc: Arnd Bergmann > Fixes: 7322dd755e7d ("byteswap: try to avoid __builtin_constant_p gcc bug") > Signed-off-by: Johannes Berg Looks good, thanks for addressing this! Acked-by: Arnd Bergmann