From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751169AbcGWMgr (ORCPT ); Sat, 23 Jul 2016 08:36:47 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:47447 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750786AbcGWMgq (ORCPT ); Sat, 23 Jul 2016 08:36:46 -0400 From: "Rafael J. Wysocki" To: Doug Smythies Cc: "'Srinivas Pandruvada'" , "'Linux Kernel Mailing List'" , "'Linux PM list'" Subject: Re: [PATCH] intel_pstate: Update cpu_frequency tracepoint every time Date: Sat, 23 Jul 2016 14:41:43 +0200 Message-ID: <2133928.8B42yOlnv2@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <001a01d1e234$e33ce290$a9b6a7b0$@net> References: <3678564.0E838ntcHL@vostro.rjw.lan> <1468967958.2125.2.camel@linux.intel.com> <001a01d1e234$e33ce290$a9b6a7b0$@net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, July 19, 2016 08:14:53 PM Doug Smythies wrote: > On 2016.07.19 15:10 Srinivas Pandruvada wrote: > > On Tue, 2016-07-19 at 15:10 +0200, Rafael J. Wysocki wrote: > >> From: Rafael J. Wysocki > >> > >> Currently, intel_pstate only updates the cpu_frequency tracepoint > >> if the new P-state to set is different from the current one, but > >> that causes powertop to report 100% idle on an 100% loaded system > >> sometimes. > >> > >> Prevent that from happening by updating the cpu_frequency tracepoint > >> every time intel_pstate_update_pstate() is called. > >> > >> Signed-off-by: Rafael J. Wysocki > > > > Acked-by: Srinivas Pandruvada - > > Shouldn't this patch refer to: > > commit fdfdb2b1301670a69195ba1e5666df4a7f02eb46 > Author: Rafael J. Wysocki > Date: Fri Mar 18 23:20:02 2016 +0100 > > intel_pstate: Do not call wrmsrl_on_cpu() with disabled interrupts > > which is the patch that introduced the regression? The logic changed by the $subject patch was there before the above commit, so I don't think the issue at hand really is a regression introduced by it Thanks, Rafael