From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752948AbbEDU60 (ORCPT ); Mon, 4 May 2015 16:58:26 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:49220 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752369AbbEDU6W (ORCPT ); Mon, 4 May 2015 16:58:22 -0400 From: "Rafael J. Wysocki" To: Peter Zijlstra Cc: Linux PM list , Linux Kernel Mailing List , Daniel Lezcano Subject: Re: [PATCH 0/4] sched / idle: Reduce the number of branches in the idle loop Date: Mon, 04 May 2015 23:23:22 +0200 Message-ID: <21372869.SeRj1zt7yN@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.0.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150504142505.GM23123@twins.programming.kicks-ass.net> References: <3084951.QaIkFrZ3VU@vostro.rjw.lan> <20150504142505.GM23123@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, May 04, 2015 04:25:05 PM Peter Zijlstra wrote: > On Mon, May 04, 2015 at 03:54:43PM +0200, Rafael J. Wysocki wrote: > > Hi, > > > > The "reflect" variable that had to be added to cpuidle_idle_call() to fix a > > regression during the 4.0 cycle has bothered me a bit since then and guess > > what? It is not necessary. > > > > After the last regression fix related to tick_broadcast_exit() I realized > > that it should be possible to eliminate this variable by splitting > > cpuidle_idle_call() into smaller routines and reordering the code in > > question which is done by this patch series. > > > > It also gets rid of one more redundant check while at it. > > > Ooh nice! Yes that thing bothered me too. > > Once you fix that one weird opening bracket: > > Acked-by: Peter Zijlstra (Intel) Fixed and queued up as 4.2 material, thanks!