From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbcD3XZc (ORCPT ); Sat, 30 Apr 2016 19:25:32 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:59822 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbcD3XZa (ORCPT ); Sat, 30 Apr 2016 19:25:30 -0400 From: Arnd Bergmann To: Matt Fleming Cc: "Compostella, Jeremy" , Ingo Molnar , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] efibc: avoid stack overflow warning Date: Sun, 01 May 2016 01:25:12 +0200 Message-ID: <2137916.p0oDBh93bk@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160430224641.GQ2839@codeblueprint.co.uk> References: <1461952128-2135409-1-git-send-email-arnd@arndb.de> <18565207.dPI1UNgYiO@wuerfel> <20160430224641.GQ2839@codeblueprint.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Ej2rYx4wD2QGk0ObqY2N4/STOEa70/QKDN/4AnbI9G7+fFSm6cg sh+jJd9zhZJhoSDRT5CcnNxIohRtGZOIFjr2RoHcYLxWFBMx1OxHqUwzBWVJrJ8oUb10IOc 3FmOUGq5NUfXaVac4NOPhMFcaFXjdHUYDlRtkX4dBtPm5oLBJ5yD0XaiMuPkXzMrfwZr8ZQ 99CetsqWt61m5jYULwAJw== X-UI-Out-Filterresults: notjunk:1;V01:K0:QTPrd0J1lWs=:vjDE2Y7X2oSKs6Og7Il1WB rDOVETg0z00oCVKURKCcmy5U7lxArSB4OPqCkJWHPscBcTZ02Je/BW9k2vtPYbniEep0xD6IN 31HK06Fqx22S++xocKLECGsal1ulh8AWSahzUnWSU1PtKm6OBkdT0mnWU5YDseldfM7ZRR5Nq cEx2ZhEvkDV9XicYdDUfojTmDTAtVox0JA6Fy07np+pUeDUWtBHgYEB+C8/JofEn5A8hxCHpJ 6md8HqvAWYdnLK/RwBgKX9AthnF5eeBrZB6ZdLDKK8xTj+ca1gc6OVjPjpXmD01rqiu5N+Wpm adi4wZ1eWrRPhIxbOt9QieC7JnZ4C95uiV7wueAGX7dxnh5Ex7Z3JhxGy1lhyb+1qwhK0KzdW ErLKluua5YljpYpyOnHJyNN8p2tD+u3o5qxrd+ugxHg+Q/SEPIYqzLZVjpJUdZxcHdjvkZ8IQ Pjm9TLl6lV0o7391fnJOD9wySeZf5+vsDU0p9vfJkCqOm9dC9PP/67EqiKpKTqGTQGJ9pvok1 AezK2zP6JlKtTOGyM3LNGXu7YgtlHUfkac3+RZescViBJhOiG0NbUSRDgDLY9EkYuKXUsMcUs wiNlq+o2BPPo9PhBwA7iUC/cRtgB7zSHRdP74ORzak6kQPcLw02qSic/oZVoFZz/mlaooQn7f t6JiFTVP+TZh3EoSf2vr5nXjTvQFYyuHHK7J0O62tZm7bO1HdjTZr5R8Yvhg7BrB/S5JpoM5F MJ2rLw7SBVyWEiFW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 30 April 2016 23:46:41 Matt Fleming wrote: > > > It's not something we'd have to worry about in practice, but it does > > make my patch incorrect. Should we come up with a different way to > > do it? > > Jeremy proposed a patch to dynamically allocate the memory, which I > think is the correct way to go given that our (reasonable) assumptions > about reboot notifier concurrency are not guaranteed, > > https://lkml.kernel.org/r/87h9eked24.fsf@jcompost-MOBL1.tl.intel.com Sure, that works. I considered doing it that way but it seemed more complicated. Please use that patch instead of mine. Arnd