From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756004AbcCQKbK (ORCPT ); Thu, 17 Mar 2016 06:31:10 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:50478 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbcCQKbI (ORCPT ); Thu, 17 Mar 2016 06:31:08 -0400 From: Arnd Bergmann To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , Sekhar Nori , Kevin Hilman , Andrew Lunn , Wolfram Sang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: davinci: only use NVMEM when available Date: Thu, 17 Mar 2016 11:30:17 +0100 Message-ID: <2137949.xUV6PQJbIO@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56EA8654.5070100@linaro.org> References: <1458077705-408437-1-git-send-email-arnd@arndb.de> <56EA8654.5070100@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:cDI7g9KEEFtGQ296sQvuaOd/UeuoKBpIaFPRuUtp9TaZL3F3oGv /gqGlK1AlLZ+q7rBubsD4uF7CESYgsn8EXihK4siNawUAarIdfjEPRnyFkd3YXkzMPHcaML dQbANjj/nSx+6PuPcy4FjnVbf3Urs5Af9vEzJligMBL/qvHj3yfjHV0snUPPiyxln/7sLhT S3Jsq6SbEvVY6XvdfIhDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:/x5SYpvlSbk=:YeHBqfdmp6/Ur+4U+WgkOs xLwZ4X7Gce9XabaObHc7fxxhY/PI6Aj8LVCJVNRmN2o0rISc1MlVAraeuNMsg8U8uM/UI3jSW qY0AdnjFVdVsfMJNjMx7Qawzc0TMdoH+/qlLXLLt/qaYpzZX9nJHWpJ6AgEyNDZ7aCShMenBD cSzfYZBTqAmxnUMKMq3PdCF88lC9fKWSFuX9gnzSh0GPePzw5k8cJnx/79jmcdExQnBBKf6l6 Q036xfQGSXKwzDlT+Pjp6ar9ykzPYkY6mFv0MPQ6wJHs3JmmRiosf0807oe16hcW7KgYuyXAi 8QQpUdwSJyLLzzbFdIJi0iRD4LEnNc7UFtkLoA0fLVJjj623jkQ5JkyVMfa+iRO6JYpouVHsZ /DVRdMx++wY7XCPK72A+0CAzz896iMHmaTk5xks2bAZvt7Lj8NQ6tiGYhV696981vhitv2nCc /YwsEwJHqLXbmGOw2PwskCoFFARlcAi8kbHPg9bX3uQ+hhq7N0y3sJ+6YriLIpAII7EGfPTFH nl7Jcp8PXkJBG+/gzhqvY459zsisKvuxzr5MowuuF4IlPw7GN2ps3cyKtzYu2ax1Bkq5jz9oo MFcECiqumNrHfzow9KKjt15U9FmrC3KC1Idb6+upMeVc9IHRYlVTADCZP5fLNVfrnfIzfZYUy 8vGedio9zUNeqHJJBkjMg7ZEPfL/ShVuZNBwsCspvvUZReZHCPpmkngYEENfegV3bLTPSQh0A X8068p2BFACfGeyS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 17 March 2016 10:26:28 Srinivas Kandagatla wrote: > Thanks for the patch, > > On 15/03/16 21:34, Arnd Bergmann wrote: > > The davinci platform contains code that calls into the nvmem > > subsystem, but that might be a loadable module, causing a > > link error: > > > > arch/arm/mach-davinci/built-in.o: In function `davinci_get_mac_addr': > > :(.text+0x1088): undefined reference to `nvmem_device_read' > > arch/arm/mach-davinci/built-in.o: In function `read_factory_config': > > :(.text+0x214c): undefined reference to `nvmem_device_read' > > > This fix does not look correct to me. > > IMO, This is a issue with incorrect dependencies in the Kconfig, we > should not attempt to fix it in the code, rather fix the kconfig > dependencies in the mach-davnici or the EEPROM_AT24 kconfig itself. one > of them should select the NVMEM. Those 'select' statements are an endless source of trouble. The code already builds fine if NVMEM is disabled (falling back to inline stub calls), or if NVMEM is built-in and AT24 is not present (leading to the call failing later), and that seems to be a reasonable fallback for users that really don't want those drivers. Arnd