From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 666BE33E377 for ; Mon, 17 Nov 2025 18:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763405722; cv=none; b=UR08ac/Ebp3EjJkGv7zb3/PZgYalHDDlyMhixWYtQxPShwI+nADDTiPj3sPtI0yRRNxlBC4OFq9YCC+59Q2QDsBprcQWosWY2mZtLuqk6s/31BdhvlFSiTUUZrgvH8ixBtXGBUk1Ykc3O0gakkw/xNfXL/qvIAAZbi0NJ8lnF3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763405722; c=relaxed/simple; bh=OGAw5VyJ/VVawn5+6Eh3pRnn2NNR9asc4x9Ln6gSzYA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jpg3ZwzTjJahfXpuS9zi5DW/b9BnHAj11s1j4kJlTRZfHC45y7CRAf9U/XbzNm2D7bHRt0JVOpdS4nbVvnTpgXsRW/hVi2Ddew3WkOVmPpoVMcNiyhpBNuNvTEe8VWUdJPbmV8ozi/Pk8ETUdSvsKX3wBP9IDuqJQwZcNCF6eSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PPBuYuFq; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PPBuYuFq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763405719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I4saTekz2qSp4ayUKrRPAgd+eGcPNxQ+jxmXq5BkA8E=; b=PPBuYuFqA6VKKgWG9LY7LBH9B0XufpXKhGqMSaVx7G54hxK4aRIUojlVWPxvxZHPbzq/4u YHLsM0FEyZQX8GAdgInvF4DUHjVE7mJI0Pj1Lu1ioNVjimIB+B7fF2SdYWU1MjT4h0LumH ptmbxYdorrl34CnLrm5sYFfXFF8VMWE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-QNtedgBfOz2LUZxVYxsQjw-1; Mon, 17 Nov 2025 13:55:18 -0500 X-MC-Unique: QNtedgBfOz2LUZxVYxsQjw-1 X-Mimecast-MFC-AGG-ID: QNtedgBfOz2LUZxVYxsQjw_1763405718 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b2e19c8558so615539685a.2 for ; Mon, 17 Nov 2025 10:55:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763405717; x=1764010517; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I4saTekz2qSp4ayUKrRPAgd+eGcPNxQ+jxmXq5BkA8E=; b=TdxtPl90wQ8C1w+uwTSEbbmX82bY3oaUs6B+yhcqLRCTy9r240gs2IYY3ZcNIbUpXC gLNtBFKMGVeRwJylpyFLoo23LeU6XlqLUy/OJe6slSweFosJSa/GEWTp3FbYn4ALRvrI efPkqUPD5g4b1Q4p3Um9bctS+Qsj9Vxh1uGM5gKqi/E1kyNLXg/5NKIvMj53H4TCJlnT w5uurmlEuKohCfwrvnxG0QXSZ1PZDeKRUjzpdWmc+2YJ4GB2fMRNiPCu0T6TyFfmbwjG f+c4Z2nRGF1909VLfS88c/dn3Voa/326QSkdwDTud3/5kky3nNCwHPFYA6wr5Xyzpwd1 GCsg== X-Forwarded-Encrypted: i=1; AJvYcCXwYfw5knjKzscLV4HmNnLuAsRiyMKQu1RMOKm1OsfctGWakd5RHPd9MP5qKOs5Sz2ht6FDQRgpCtSUyHY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0b0MixUB4yRLIcbheTuZeoQMeVRldzWEEWfNUV+41UGBtWJGs yYsisjv9h/TkSo6wCD/VapcxVsDTyRPrufyBIKNgzki273806tUifP8J2XCpGsFQ7BcPK60yJAh qcBgZ2mdGeLyngr5lNbiwy6nut+5AH75HJ0NL/G119pMIJcQFHUZ6PKcgD36LKgqfS758pu+wCg == X-Gm-Gg: ASbGncuY0UVgo8ZY2Zy5a1BGxskR7iy9zzrvnrJukvDWBim8Bdcok5QM4GcKfO6/Q4o +Zd1cvaIY7uH65LSUQDo8LHPDLKkJWoxDvMat3VFdo18ef+XKP/Ay/dTAuBQ6fs0/f5yXmZidRt UH5cJJ75Sthv35uoOtUUqlozaSOhonLB7uqnJmMUBnHFGVxCbdHcen7s3b5zTkVeqv2XpcCFRkI 5HqdnMEJ3uI45WZ1tj9ZPJFfg3VKGMMq0tQE0jykT/AG2RMR9xIOjgIWuiYetTYOOnlH/ar5kPX 0vO3D343IFGYB6R0lMd4PCKphPCY9hg7AbRISvrAhIP9wLLxIqUkfNJmNvsFJBb8DQGfr4Z1mx9 q7CCYEZOvqXFttW9s5/0IZ4FtAjfb0vPcFkD3y6LoIloZBlo9BUUutcuK0shVecOCGqfqArSLoA == X-Received: by 2002:ac8:7e86:0:b0:4ec:f1a4:5511 with SMTP id d75a77b69052e-4edf2160d82mr167691191cf.65.1763405717496; Mon, 17 Nov 2025 10:55:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IEtMZVukIyibHwI+DRiA0waOmzoGwweTf0fxlTZly2n4z7oX2AtJ/FaMOEx0rAxWMSYW/OLag== X-Received: by 2002:ac8:7e86:0:b0:4ec:f1a4:5511 with SMTP id d75a77b69052e-4edf2160d82mr167690911cf.65.1763405717057; Mon, 17 Nov 2025 10:55:17 -0800 (PST) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-48-76-65-77-217.dsl.bell.ca. [76.65.77.217]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ee0bcfdedfsm50628441cf.16.2025.11.17.10.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 10:55:16 -0800 (PST) Message-ID: <21386400-9a67-4fcf-b686-1e7c9678d123@redhat.com> Date: Mon, 17 Nov 2025 13:55:15 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 04/10] drivers: i915 selftest: use pgtable_has_pmd_leaves() To: "David Hildenbrand (Red Hat)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com References: <297c6fa3dfc50c28c05c0974c86a205984d752ed.1762464515.git.luizcap@redhat.com> <8c745e54-1cb1-44d4-abc3-00e6511cf67c@kernel.org> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <8c745e54-1cb1-44d4-abc3-00e6511cf67c@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-11-17 12:30, David Hildenbrand (Red Hat) wrote: > On 06.11.25 22:28, Luiz Capitulino wrote: >> igt_can_allocate_thp() uses has_transparente_hugepage() to check if >> PMD-sized pages are supported, use pgtable_has_pmd_leaves() instead. >> >> Signed-off-by: Luiz Capitulino >> --- >> drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c >> index bd08605a1611..c76aafa36d2b 100644 >> --- a/drivers/gpu/drm/i915/gem/selftests/huge_pages.c >> +++ b/drivers/gpu/drm/i915/gem/selftests/huge_pages.c >> @@ -1316,7 +1316,7 @@ typedef struct drm_i915_gem_object * >> static inline bool igt_can_allocate_thp(struct drm_i915_private *i915) >> { >> - return i915->mm.gemfs && has_transparent_hugepage(); >> + return i915->mm.gemfs && pgtable_has_pmd_leaves(); > > On second thought, is it problematic that we might be losing the CONFIG_TRANSPARENT_HUGEPAGE check? Should we check for that separately? That's a good point. In this RFC, pgtable_has_pmd_leaves() should be functionally equivalent to has_transparent_hugepage() so I think we're good. That beind said, I also think that we should disentangle pgtable_has_pmd_leaves() from THP now or in the future. When we do this the breakage you're spotting will happen. What about adding thp_has_pmd_support() which does: return IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && pgtable_has_pmd_leaves(); Then I can convert all the cases you spotted to thp_has_pmd_support().