From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756869AbcILV5e (ORCPT ); Mon, 12 Sep 2016 17:57:34 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:43345 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752078AbcILV5c (ORCPT ); Mon, 12 Sep 2016 17:57:32 -0400 From: "Rafael J. Wysocki" To: Lukas Wunner Cc: linux-efi@vger.kernel.org, Matt Fleming , linux-kernel@vger.kernel.org, Andreas Noever , Pierre Moreau , "Rafael J. Wysocki" , Mika Westerberg , Andy Shevchenko , Greg Kroah-Hartman , linux-acpi@vger.kernel.org Subject: Re: [PATCH 4/6] driver core: Don't leak secondary fwnode on device removal Date: Tue, 13 Sep 2016 00:03:38 +0200 Message-ID: <2138721.OSYGqcTspe@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.8.0-rc2+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160830090325.GA25024@wunner.de> References: <6868582.iUcUV1Tb36@vostro.rjw.lan> <20160830090325.GA25024@wunner.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, August 30, 2016 11:03:25 AM Lukas Wunner wrote: > On Wed, Aug 17, 2016 at 02:38:50AM +0200, Rafael J. Wysocki wrote: > > On Thursday, July 28, 2016 02:25:41 AM Lukas Wunner wrote: > > > If device_add_property_set() is called for a device, a secondary fwnode > > > is allocated and assigned to the device but currently not freed once the > > > device is removed. > > > > > > This can be triggered on Apple Macs if a Thunderbolt device is plugged > > > in on boot since Apple's NHI EFI driver sets a number of properties for > > > that device which are leaked on unplug. > > > > > > Cc: Greg Kroah-Hartman > > > Cc: Rafael J. Wysocki > > > Cc: Mika Westerberg > > > Cc: Andy Shevchenko > > > Cc: Andreas Noever > > > Signed-off-by: Lukas Wunner > > > > ACK, or I can apply it directly if you want me to do that. > > Yes, if you could apply it directly I'd be grateful. Applied. Thanks, Rafael