From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 301943009E4 for ; Wed, 7 Jan 2026 10:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767781618; cv=none; b=c2/1RO291LsRZ1Ckdw6NxYXPu7KR4ATMjXgRuWclr/fDBZXrWP7VLWzpuw1uqBXhdXXtjhWkOuOx5Jp04gJQkwWBpWSf76pM8XdmrIHhIVDEaYXPqXiZCvXlJ1UyabvkOjY7o7DJh7fr+Me+dwvuHBLO3hyVJF1CqLJP3oa9bfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767781618; c=relaxed/simple; bh=kCkyO7ZW9t+qcbk65u5Flb7txWs1td1WoAG30xCd4BY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pyGum+C2NDHhC+/7SuYHiJYJ5bCMUntqSQe4SC0R1Iw2RfEfyQwALrMWAYLHISSs26M/lpAdoPwY2LXIzYKxtdAobLs+vt57x47nI8pINuqCIndgXWI/QBxf2aJK/qEiFJbwOTp0fzHkNkoCE2o+61sP81iKEsziiv2at8jZrgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j3B06h3T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W2XZHh1p; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j3B06h3T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W2XZHh1p" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6079efVL2988464 for ; Wed, 7 Jan 2026 10:26:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PUdwhvEuKw8923YOv3Z4Z8UpmCvZRzAuTlyICRNQGSU=; b=j3B06h3TV5GMMdRG xOEF1wtUAPnYU/5bSziir0tdEV8z1FPy6YpWx8eNDHoDi6vgelq8Z7T6DAXKuc8+ lhrGCPbpsJaWchAS+AQ0TRTkhl9b3XxFIpgEkc0QLAE+NV3q25z4e7UyIp21yVeh rd1sSh9+M2VsFfEsEsL84icuL8oHYoJJxbEOGfuR+B5pbgehuhg+eQNvD8uwfLLw Qzb9PWbdJSg1XJzoaA+JfbrH8kWwwZpq2cMPE3FzeQUu9Hj8w1T/oVvwSyiyrChB 9i0otZXQRz2PkXOhtfnhV+9m4TFBJ0oFnpOGm0thraoazKtlIQXb8Vr9aARm7D4O XSL2OQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhn2nr4xc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Jan 2026 10:26:55 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b99f6516262so4216159a12.3 for ; Wed, 07 Jan 2026 02:26:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767781615; x=1768386415; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PUdwhvEuKw8923YOv3Z4Z8UpmCvZRzAuTlyICRNQGSU=; b=W2XZHh1pHi28eq+6FglyOVxS3zvK2ojiKV77WkjXPAqL9WPzQ6dG3vT7EiF2Bm5JpX jqi15sOf0Dtfgq57dZhbWQ78yGG6CjQj09DHEH3yiHo6BJr6OsUbXlvDJASLhDWBoX5x twShroHb+7EHgsRwgh8CZMsk+l0zGo6QmrMG22a2GoXamZReLSSaId2Ki/52X2hUu/G5 Je/KmF3co6CGDhXjt1lMmbvBsUtAaaotufB0JSEhTXQVmGR6Fyn2BUFKj0RW/NeBzcnf ciGjpdmkSMthd3uZw593T8k5+Zd5ZTRNrCAqcozxyywOcdTNA7sxWUbs52WQzCRCkex6 IQeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767781615; x=1768386415; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PUdwhvEuKw8923YOv3Z4Z8UpmCvZRzAuTlyICRNQGSU=; b=JSk5X7gf3hSoJPOK3S1R4d8nHXAIu6RqEsaVdSB55BmOTv/SW5RIejFvyCvpYO6MUI SO844bCJtUCQ3f7H4hd/KXpzUj46PU5hV3OBa/jBeT28fSvL+D3t2Ui8xl3r0vVehum9 xUwcfOZ2PZ984TIsa56thZxti/0PIHw4VlN9fYW2Wa9GVafSLfoQaectKTUclrjeSbwS nJp68oKNT6fTE1duNM74ANbvAsHy2vP39YdQ6Y6wub0trWlCcSwLPuFdt3cA5ZLfk5B5 pt3mpxgaVaPGZaBXw+9IFhcQV5++MU7siFYoYDK7exqCLIxf9cZ0LqVenvmKFBzSgzgN Z7vw== X-Forwarded-Encrypted: i=1; AJvYcCXcpLuguKtmQ4Q5oYpZNLQIcBwT4TJb/zJMO4exK+TM7+JWTSVbr5X2V1heQOY/693hnzJuunta5Hykhz4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9mTMlzXIJY+9/xbGJDdGzGFsFzP254g6wa10qN3hCu/mboxSh 382TCOaGrwhCf0yHhMgLXEw7Ba2ELimfmqLmOYXX8LIdBQX2ZrlMij/ju/kHICBkOMZRByDDFn3 n6vxgmBvzJpCltQkM3GEUcbz4xoLb/pnWZJKQlUm6XquXkRgZ8REKLGGWZomTt1GSn3A= X-Gm-Gg: AY/fxX5B43RHETbk8ENvss1I5nADVRL1T7CTgBJF/Q7VG/b+JStAagfz/+GNvF0zWM4 REC2MT+S/S7NcEKFSeJxgHCwYyP1Z+CoAuUc/aSF+vncmGMnbBTLAzCBA4utT1YNmCzGFLWKK0H kSDy3tTe6w+B2eGakOeO56BPD23C/uTjH+tiqvS4/vXIOFhx4o6+FWvYVl12aqjQDQ/68zp3yYJ 8B+tGwKuLjb+InMYXfEHKbYAonIRPmpy40nwhn0iw/rOP9MZhl0CZBoU7iLXKO2SkJDiEgWLbC/ dg9RsoHlbXDQe4boJC0AHHDL5dKE+Ke8ni1Q2/isySSo/8Yz7osYscVEmyvqDq6R2uNEAWMHJrp WZ834frIUiOdHYmWa/CcjP0WWYVhyeBEvY8cG+WKlxw== X-Received: by 2002:a05:6a00:300a:b0:81b:23ac:6986 with SMTP id d2e1a72fcca58-81b7fcc7c8amr2112835b3a.49.1767781614962; Wed, 07 Jan 2026 02:26:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHHpF4MeWQ9U4cwi7ICO6lAUI8vZB2PUCcqI1qsE1NPEMnksXVEJvE4gZcpvlriuftxL+9MPg== X-Received: by 2002:a05:6a00:300a:b0:81b:23ac:6986 with SMTP id d2e1a72fcca58-81b7fcc7c8amr2112816b3a.49.1767781614472; Wed, 07 Jan 2026 02:26:54 -0800 (PST) Received: from [10.206.101.19] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c5edd921sm4583028b3a.69.2026.01.07.02.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 02:26:53 -0800 (PST) Message-ID: <213aca21-a337-4a98-b634-b2e5f76bd9c2@oss.qualcomm.com> Date: Wed, 7 Jan 2026 15:56:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] media: iris: Add buffer to list only after successful allocation To: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> <20251229-iris-fixes-v2-1-6dce2063d782@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20251229-iris-fixes-v2-1-6dce2063d782@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA3MDA4NSBTYWx0ZWRfXz+CqgHCZFa3r eJT5cpSr89ixZ1hdHdm6LOYE9KmUKKzTME/yKnrTTwgOxkoSemVFGjCtMN/w2765g6CeEuCxg6J gCnsr9VNZ0WsnGt/oY6IoX6jDkDkB2PkXKI4QmluWEfiUYbvl9k6aFVHq847ShfXxJQVp6m6s+S sJIVJuRWUklT0795rbSYf8I54u66gFiAFwivM5JFHyjyYyqvT5g9gqi9i4nBr+U9bJduPVbObNL agvpyb1fy/xMWHjuQutfQF0FAzP1EscrkYPT1dsYaUSghzKiGDKJ7rwsqOu44pCkeNj7UwssMiJ NsVofAlaHEG3xJJrNMkDbuFAncDVhhijfssIDMgm84v+taPfBRYSwdbCAmnYK/Nvq4TaU9zajwQ GkZWm7YhRLx8JY+XJOl4Uf+nUaOVEVCK/ktjrMcPZ/gdlcwQGUVP9BVEFAlVZD0bUgklkLEbRx7 t1jLkPAocsELyodmeww== X-Authority-Analysis: v=2.4 cv=CYEFJbrl c=1 sm=1 tr=0 ts=695e34f0 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Ir1fGBQ6tmwodNh8ZXAA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: C2_U0E9AbhAfN0Z2cefJ56KPA7s1ceAJ X-Proofpoint-ORIG-GUID: C2_U0E9AbhAfN0Z2cefJ56KPA7s1ceAJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-07_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601070085 On 12/29/2025 12:01 PM, Dikshita Agarwal wrote: > Move `list_add_tail()` to after `dma_alloc_attrs()` succeeds when creating > internal buffers. Previously, the buffer was enqueued in `buffers->list` > before the DMA allocation. If the allocation failed, the function returned > `-ENOMEM` while leaving a partially initialized buffer in the list, which > could lead to inconsistent state and potential leaks. > > By adding the buffer to the list only after `dma_alloc_attrs()` succeeds, > we ensure the list contains only valid, fully initialized buffers. > > Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal buffers") > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_buffer.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c > index b89b1ee06cce151e7c04a80956380d154643c116..f1f003a787bf22db6f048c9e682ba8ed2f39bc21 100644 > --- a/drivers/media/platform/qcom/iris/iris_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_buffer.c > @@ -351,12 +351,15 @@ static int iris_create_internal_buffer(struct iris_inst *inst, > buffer->index = index; > buffer->buffer_size = buffers->size; > buffer->dma_attrs = DMA_ATTR_WRITE_COMBINE | DMA_ATTR_NO_KERNEL_MAPPING; > - list_add_tail(&buffer->list, &buffers->list); > > buffer->kvaddr = dma_alloc_attrs(core->dev, buffer->buffer_size, > &buffer->device_addr, GFP_KERNEL, buffer->dma_attrs); > - if (!buffer->kvaddr) > + if (!buffer->kvaddr) { > + kfree(buffer); > return -ENOMEM; > + } > + > + list_add_tail(&buffer->list, &buffers->list); > > return 0; > } > Reviewed-by: Vikash Garodia