From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbdK0GxZ (ORCPT ); Mon, 27 Nov 2017 01:53:25 -0500 Received: from ale.deltatee.com ([207.54.116.67]:53858 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbdK0GxX (ORCPT ); Mon, 27 Nov 2017 01:53:23 -0500 To: Julia Lawall , Joe Perches Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Whitcroft References: <20171126054037.9743-1-logang@deltatee.com> <85bdbab8-8b7e-91a9-7199-a0e39041aef1@deltatee.com> <3fc88c02-b9b6-80a3-0c41-63e0806d34aa@deltatee.com> <1511746526.20482.38.camel@perches.com> From: Logan Gunthorpe Message-ID: <214bd4fd-7074-8af7-2993-a11b2605346f@deltatee.com> Date: Sun, 26 Nov 2017 23:53:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 68.147.191.165 X-SA-Exim-Rcpt-To: apw@canonical.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, joe@perches.com, julia.lawall@lip6.fr X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/11/17 11:42 PM, Julia Lawall wrote: > Although I guess that in that case the whole exercise is pointless? > Because every print will at runtime be followed by another print, which > will add either the newline or a continuation. Yes, in practice the '\n' at the end of every log line is optional based on what the code actually does. Nothing bad happens if you omit one. But reviewers still point out that they are required. (That's what started me on this mess -- because I'd rather know what the correct thing is before I commit the code for the first time, and not months after the code reached mainline.) The reviewers have a really good point though: if a significant fraction of the log calls have no new line and a majority have them, then making any kind of change in this area could break things. Not to mention the ugliness of the inconsistencies everywhere. Also, the more cases that are "wrong" that get into the kernel the more it confuses people trying to learn what the "right" thing is. Honestly, though, I have no dog in this race. I just thought it would be useful. Logan