From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbdKUVg7 (ORCPT ); Tue, 21 Nov 2017 16:36:59 -0500 Received: from mga11.intel.com ([192.55.52.93]:13271 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbdKUVg6 (ORCPT ); Tue, 21 Nov 2017 16:36:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,432,1505804400"; d="scan'208";a="4407457" Subject: Re: [alsa-devel] [RFC PATCH 0/7] Fix Intel audio Kconfig issues To: Takashi Iwai Cc: alsa-devel@alsa-project.org, arnd@arndb.de, vinod.koul@intel.com, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, broonie@kernel.org, andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <214d3637-1b5f-caa2-8d36-de451cdb7959@linux.intel.com> Date: Tue, 21 Nov 2017 15:36:56 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/17 11:10 AM, Takashi Iwai wrote: > On Sat, 18 Nov 2017 10:25:28 +0100, > Takashi Iwai wrote: >> >> On Sat, 18 Nov 2017 01:01:55 +0100, >> Pierre-Louis Bossart wrote: >>> >>> At the risk of being scolded for the third time in two days by >>> Linux overlords (no hard feelings), here's an attempt to clean >>> things up. >>> >>> The first patch *should* implement what Linus, Takashi and Mark >>> tried to explain by email. There should be no functionality change >>> and could be merged if deemed ok. >>> >>> The rest of the patch series does a more in-depth cleanup and should not >>> be merged without more testing (hence the RFC). >>> >>> The 4th patch is really the most important one, there were nested >>> configs which made no sense to me. I don't know the history which led >>> to such complicated stuff but simpler is better. >>> >>> The last 3 patches are just clean-ups of the machine driver configs, >>> for some reason there is no consistency in the settings so I tried to >>> apply common sense. There might be additional cleanup needed since I >>> don't really get why we need references to LPSS or DESIGNWARE for things >>> which are not visible to a machine driver, we should only depend on IC2 or >>> SPI in my opinion - depending on what the control interface is. >>> >>> I tried to keep things to a minimum in each patch to make the reviews >>> easier, if people want them squashed that's fine by me. >>> >>> I'll do some more testing on my side but I could use feedback. Thanks! >> >> FYI, I've put these to a test branch, test/asoc-intel-kconfig, so that >> 0day bot can catch issues. Let's see. > > No news is a good news, it seems that your patchset doesn't break > builds, at least. Let's go ahead! There is additional testing being done at Intel on Skylake platforms, let's see after the Turkey break if additional fixes are needed. I also need to spend a bit more time on PCI platforms and SOF - those two were the main source of comments. Thanks for the feedback and comments everyone, much appreciated.