From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45BBE1AB52D for ; Thu, 24 Oct 2024 08:36:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729759018; cv=none; b=k1ntUE8SComxRh6mjv3nb1DTqG1AVisivGm7LY/gbuoCvnPIelfEQSeX9GxM3Rt4t4xRxbg/otYmkPJrcaQ8AmxsmZ1LjuaIuARQtnxXWWyADB4KWNPtCWuamm+kriZoSdBci2EDTNZVkB8UcxJU0pq7/pc6Dhs/W2yTBTGXk4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729759018; c=relaxed/simple; bh=k2MmQUlbmKg5pfXrWwba7RLrW+gbXDhqcwKxhuulIyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nxtdVA8TS2H5gVhWULhDlO9+D2uH6lqnK1Ef8th13GkDkf/57tR5Pik8QAQgznghchk4RHvLfUJnm4yqFuzmjWHj6I6lIVIO+qDIJ183vMtXDeQH9GNKqqK5XqWGwhCG7+uFHPlDhmSn9S6efr8a9VjXwYQXEwf5OHjZn2127iU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=B2+DmbQY; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B2+DmbQY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729759011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bV9TQmFfSs8yLsU7QCmDt4U0aRRMcN9r5MoA2ahCdZ0=; b=B2+DmbQYRA6uLWzQEvAoD1JmuHljwhpyHQX0C9yB1VcrduFR6sZcNV0R2pFhaT9msxdpC/ SQQ+fWRoLkoV2ZyAQBalYj0IVYl9VaE0FQ4h5s0bKAGQJmfWe777nN7rk0Q1JIf3VOSf0V y5YNBDJxHcmV3G+A/Z8ioajsSzcIu64= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-5GpkkiceNL-C9wBsmd__UQ-1; Thu, 24 Oct 2024 04:36:49 -0400 X-MC-Unique: 5GpkkiceNL-C9wBsmd__UQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4314a22ed8bso4606745e9.1 for ; Thu, 24 Oct 2024 01:36:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729759008; x=1730363808; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bV9TQmFfSs8yLsU7QCmDt4U0aRRMcN9r5MoA2ahCdZ0=; b=OGCUzBNwoQAsWJT+sSDkufd5u05/pnMK861RNR+8p3TSgEpfSl34obFRYuefzwmaS7 4w0F/ScUN0sfyWUmh1NYyMMuHic907zZA0Ueg8I0xhKx5AZ4oMWlYaiw34KQno0NlAPa nwz7lQ8a9PG608+OgaWl/Mfj+J0UsAhIYZi/B2kAejf+2x1/7M9YyRRlYBxnVlxsJyTU DBTVYXdEqwjOWineobXyNaNrR/PhthPFLeccFBw100FjKGSwstfwK5OxhPTCaYF7pTpP mg2zDrgQS/3xkyiMvmgPVdhlZlnJjSd0uSbhlUVv+jWbDVXc2O7mcjKGW/A/ShTarC8Z qSrw== X-Forwarded-Encrypted: i=1; AJvYcCXJl8jphUJQZECTWF+0sW6awkFoIFwKiAHZ29wl57J1l8v/X4jfpzK6p0hmkjSgMe9RWjhy/bJen1rnXTE=@vger.kernel.org X-Gm-Message-State: AOJu0YyhwXlv+wEO7gAnXRttPMHRhs3qJGdfVeKsV1nUnjihpI95arJj mAAhXd1YEvQJmmmyl9gZ28A4Uu5QSXbPpIxFj7gXxH2yR4+ZWnN62iEBdlO/oxtd1grQKdWfeb9 vxGrvTYA+u4MC12E3v1OEMYsO8Amcdh/C5t2xaxPm9MO9pDTU/lO7kOKUCZxiAw== X-Received: by 2002:a05:600c:4708:b0:431:55af:a22f with SMTP id 5b1f17b1804b1-4318413f05amr48109395e9.13.1729759007806; Thu, 24 Oct 2024 01:36:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/jQmgjcxFF+0jPxIt8I7wIYJFqljK4xsgl4yRw+G3zf82LoQ8Um3/a9/gCesPsa8XUy9BUQ== X-Received: by 2002:a05:600c:4708:b0:431:55af:a22f with SMTP id 5b1f17b1804b1-4318413f05amr48109195e9.13.1729759007442; Thu, 24 Oct 2024 01:36:47 -0700 (PDT) Received: from ?IPV6:2a0d:3344:1b73:a910::f71? ([2a0d:3344:1b73:a910::f71]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186bd6894sm38675655e9.10.2024.10.24.01.36.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2024 01:36:47 -0700 (PDT) Message-ID: <214d37cc-96c0-4d47-bea0-3985e920d88c@redhat.com> Date: Thu, 24 Oct 2024 10:36:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 net 2/9] net: hns3: add sync command to sync io-pgtable To: Jijie Shao , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, shenjian15@huawei.com, salil.mehta@huawei.com Cc: liuyonglong@huawei.com, wangpeiyang1@huawei.com, lanhao@huawei.com, chenhao418@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241018101059.1718375-1-shaojijie@huawei.com> <20241018101059.1718375-3-shaojijie@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20241018101059.1718375-3-shaojijie@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/18/24 12:10, Jijie Shao wrote: > From: Jian Shen > > To avoid errors in pgtable prefectch, add a sync command to sync > io-pagtable. > > In the case of large traffic, the TX bounce buffer may be used up. It's unclear to me what do you mean for large traffic. Is that large packets instead? Skimming over the previous patch, it looks like the for the bugger H/W driver will use the bounce buffer for all packets with len < 64K. As this driver does not support big tcp, such condition means all packets. So its not clear to me the 'may' part - it looks like the critical path will always happen on the bugged H/W > At this point, we go to mapping/unmapping on TX path again. > So we added the sync command in driver to avoid hardware issue. I thought the goal of the previous patch was to avoid such sync-up. So I don't understand why it's there. A more verbose explanation will help. > Signed-off-by: Jian Shen > Signed-off-by: Peiyang Wang > Signed-off-by: Jijie Shao Also we need a fixes tag. Thanks, Paolo