From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C43C433EF for ; Tue, 17 May 2022 15:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349747AbiEQPNT (ORCPT ); Tue, 17 May 2022 11:13:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348507AbiEQPNP (ORCPT ); Tue, 17 May 2022 11:13:15 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46A7D47563 for ; Tue, 17 May 2022 08:13:14 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id m6so1592405ljb.2 for ; Tue, 17 May 2022 08:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=BBebJTiHodUV9ldblV55ft742UQ2rJkdufcTm5gvCtQ=; b=hxn7iaw4tq1xquaVPp0wxTjPeUgyEjfBAuck6J2NXlhakNKBfax9mn1vWTz3pwIIFf BdZzItsrBjAP9KNSFu6ndW5TMq5YBKZ/H0Dm0l/hhDk/qTwDwUpfnaMClKpDboIpBl5m fJP1wK1ceEuDB1btr5FDLLm1q/UWCDO2Mm6II78Vsa3EnfYmXPShujbHI6HvFjDD0Fsi dvIuEtg78RaO2LdZoOAc4RVGzvfLQ94CBi607FpbvTda2+4L0K0QMwUWZYMzgux+P/4f OEafD68znM0NFnN0paWta3ykmhAUhtPbomvzEZxzCmwKuEaNuI2qNipxoIX6/7bhVLUX Wsvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=BBebJTiHodUV9ldblV55ft742UQ2rJkdufcTm5gvCtQ=; b=bCEOAGArzULbCKt6hs30FxVgTsZhhEUb75Y5bUEqUXn7R33gx+NbziLXNbC8WOtIcv D8wSst3LwYjEGgjZGFN2/NXlZjs0m+kCwlLn/YAzvIt77XjZ/yA1ln3HvqLPPEXt7U8e UBN9UQp5goX5oq2/bnudq6B5yjr6Eobm9KWpAIjsnBSX6fiERpJQt8SyADR6m8gAIkpI 5JHl4hZqhHEmPxgGYApXei6h2+aBk/V8nUTwRYtNiDYaHU2garHOYkC4/fOYrOIIJb/W jHU6plOU5gYC2BjQzi+3KqKsJCQY+e23mIhBFexpEj+JinW9YvhlkxJgpjwpuS5CZGPX q6Rw== X-Gm-Message-State: AOAM533JvMkqYi/qgQy0hmfFfSeYj0sOP7+YTeHbRhoUMl9snqeNYTaL zA/JJ+EKmJQGb4Y6p5xCFVsLWQ== X-Google-Smtp-Source: ABdhPJzOLuMhp4MaQ12VNGb4UETImwpwiY6962rbziwYorAUl57YU9brLcb2V6S9vS2EmzYb5gBFKQ== X-Received: by 2002:a05:651c:893:b0:249:4023:3818 with SMTP id d19-20020a05651c089300b0024940233818mr15205604ljq.44.1652800392596; Tue, 17 May 2022 08:13:12 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id m20-20020a2e9114000000b0024f3d1daeb5sm1851049ljg.61.2022.05.17.08.13.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 08:13:12 -0700 (PDT) Message-ID: <214de163-d576-d9be-76f2-3b70eefd6e68@linaro.org> Date: Tue, 17 May 2022 17:13:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/4] dmaengine: sprd-dma: Remove unneeded ERROR check before clk_disable_unprepare Content-Language: en-US To: Wan Jiabing , Vinod Koul , Orson Zhai , Baolin Wang , Chunyan Zhang , Linus Walleij , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220516084139.8864-1-wanjiabing@vivo.com> <20220516084139.8864-3-wanjiabing@vivo.com> From: Krzysztof Kozlowski In-Reply-To: <20220516084139.8864-3-wanjiabing@vivo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/2022 10:41, Wan Jiabing wrote: > clk_disable_unprepare() already checks ERROR by using IS_ERR_OR_NULL. Hmm, maybe I am looking at different sources, but which commit introduced IS_ERR_OR_NULL() check? Where is it in the sources? Best regards, Krzysztof