From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793872411; b=UIijqkr37gagRI1krZ2aCk8UsA2r8HpZP0+WliNbnssWvuMcqgMZmZRkydC+s0C5evRs 9uXd06ImX0vo6XCjBdj4i7mQoq//8Ps/u6i1B5dJ8OXcBUu4KVjDoJo1ruSEhNT55K2aO Q5RcNuS2d0Bejl46ubhIibDXpJ3+SsWlm+0jxEupSH5DjOCDer5BlznDaGC7Noc2w32Iv fxM3LE62naxxFcLiBswDSp2HCizsvx1U+Wq5aCm+F/srHscGO1oi0O/Ewrf021u9I7pf9 bhWQxrkut/+AC4PomEvWTR6MPXAzldSUSyEUue7W5094TT6ya5Edg/I58Tk9Q7KJ2gQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793872411; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=MqP9VAl2M+HKyxx6eNykqH5O6VAgeEFbQ04dXIcL6Fo=; b=be5ZUFDH4KOm7jD5rMVN9qrNMmQbKWHgT8BCQychXo+5BEWs3B5T/BW6wgy9uotwzNrp O9Ui310mhKkfkV75U7/TjQ1Z5pGjAqqmJkNppduHYljWi/nmK7m/qx70XVbAtFCawK3Nr dKHh3U/QulKrkPFvxiWeBUR/tCFmNUrGs7JddP94yYSiv4uTcF+VWkZBdjpPxEO8lZqPk jHLrs0iWFtilyd9z6ERBpajIksI2Qmbz2ybt0PB/w3a9/9R15brNdfFqTGq2JC3w2xeE2 sAYc2Ky8YW3d008Shb6BQuaOSPv1e6BEJ8JanNHvG/5+8wMDGnAbRxOnqclFNHt7B4g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=0M+GuEew; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F17A606A329; Thu, 5 Nov 2026 09:53:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6F17A606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=0M+GuEew DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=MqP9VAl2M+HKyxx6eNykqH5O6VAgeEFbQ04dXIcL6Fo=; b=0M+GuEewUIj5GPHIXeBPBAoW3i zXgPfn+4LRyxdrZX5AnFP0236jDmDcidoXjDIeK5la4bnSWlwP/aZUzh9u1vohdQc4sRqo5M9FiTZ XsKFcdvzK7qt8QEdsQSylM11AZnu4iPDITkQcjUn4zfIfcds/OLMyweROsbCE3fQAk1jwgK8PO7GC r/MMyfZXSnibjvKjuIl8o5UMF1xPT+WnfymrPAY8YvXlVRSPCk8iEnYhtKgHuTwij4n4Cfw4THGOi /JXgecGtiDWVrFC7I7GPBbxIJf/5GkIcvvbxDrRFBoSJ0R4DwsK1IZQlgJFaEAyXpaPB2c3cJR+sS 7ddGpAsA==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Mark Brown , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Radu Pirea , CL Wang , Ryan Wanner , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vladimir Oltean , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Han Xu , Haibo Chen , Linus Walleij , Andy Shevchenko , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Fabrizio Castro , Andi Shyti , Tudor Ambarus , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Yixun Lan , Troy Mitchell , Maxime Coquelin , Alexandre Torgue , Alain Volmat , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Kunihiko Hayashi , Masami Hiramatsu , "open list:SPI SUBSYSTEM" , "moderated list:ARM/Microchip (AT91) SoC support" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:FREESCALE DSPI DRIVER" , "open list:ARM/QUALCOMM MAILING LIST" , "open list:ARM/Rockchip SoC support" , "open list:RENESAS RZ/V2H(P) RSPI DRIVER" , "open list:SAMSUNG SPI DRIVERS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:ARM/Allwinner sunXi SoC support" , "open list:TEGRA ARCHITECTURE SUPPORT" , Frank.Li@oss.nxp.com Cc: imx@lists.linux.dev, vkoul@kernel.org Subject: Re: [PATCH 1/1] spi: use dmaengine_desc_set_callback() Date: Thu, 05 Nov 2026 10:52:38 +0100 Message-ID: <2154003.0S5aU1g85B@diego> In-Reply-To: <20261102174005.3933649-1-Frank.Li@oss.nxp.com> References: <20261102174005.3933649-1-Frank.Li@oss.nxp.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Montag, 2. November 2026, 18:39:58 Mitteleurop=C3=A4ische Normalzeit sch= rieb Frank.Li@oss.nxp.com: > From: Frank Li >=20 > Replace open-coded assignments to callback and callback_param fields > of struct dma_async_tx_descriptor with calls to the > dmaengine_desc_set_callback() helper across SPI bus drivers. >=20 > No functional change intended. Prepare make to struct > dma_async_tx_descriptor private to the DMA engine. >=20 > Signed-off-by: Frank Li [...] > diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c > index 1a81fd94b4396..f8d6cea2f3dad 100644 > --- a/drivers/spi/spi-rockchip.c > +++ b/drivers/spi/spi-rockchip.c > @@ -475,8 +475,7 @@ static int rockchip_spi_prepare_dma(struct rockchip_s= pi *rs, > if (!rxdesc) > return -EINVAL; > =20 > - rxdesc->callback =3D rockchip_spi_dma_rxcb; > - rxdesc->callback_param =3D ctlr; > + dmaengine_desc_set_callback(rxdesc, rockchip_spi_dma_rxcb, NULL, ctlr); > } > =20 > txdesc =3D NULL; > @@ -500,8 +499,7 @@ static int rockchip_spi_prepare_dma(struct rockchip_s= pi *rs, > return -EINVAL; > } > =20 > - txdesc->callback =3D rockchip_spi_dma_txcb; > - txdesc->callback_param =3D ctlr; > + dmaengine_desc_set_callback(txdesc, rockchip_spi_dma_txcb, NULL, ctlr); > } > =20 > /* rx must be started before tx due to spi instinct */ Reviewed-by: Heiko Stuebner