From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Benjamin Bara <bbara93@gmail.com>, Wolfram Sang <wsa@kernel.org>,
Lee Jones <lee@kernel.org>,
rafael.j.wysocki@intel.com,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: peterz@infradead.org, jonathanh@nvidia.com,
richard.leitner@linux.dev, treding@nvidia.com,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-tegra@vger.kernel.org,
Benjamin Bara <benjamin.bara@skidata.com>
Subject: Re: [PATCH v7 5/5] mfd: tps6586x: register restart handler
Date: Tue, 18 Jul 2023 07:46:47 +0300 [thread overview]
Message-ID: <215679f1-a866-1e92-1bab-9c80918927a6@collabora.com> (raw)
In-Reply-To: <20230327-tegra-pmic-reboot-v7-5-18699d5dcd76@skidata.com>
15.07.2023 10:53, Benjamin Bara пишет:
> From: Benjamin Bara <benjamin.bara@skidata.com>
>
> There are a couple of boards which use a tps6586x as
> "ti,system-power-controller", e.g. the tegra20-tamonten.dtsi.
> For these, the only registered restart handler is the warm reboot via
> tegra's PMC. As the bootloader of the tegra20 requires the VDE, it must
> be ensured that VDE is enabled (which is the case after a cold reboot).
> For the "normal reboot", this is basically the case since 8f0c714ad9be.
> However, this workaround is not executed in case of an emergency restart.
> In case of an emergency restart, the system now simply hangs in the
> bootloader, as VDE is not enabled (because it is not used).
>
> The TPS658629-Q1 provides a SOFT RST bit in the SUPPLYENE reg to request
> a (cold) reboot, which takes at least 20ms (as the data sheet states).
> This avoids the hang-up.
>
> Tested on a TPS658640.
>
> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Acked-for-MFD-by: Lee Jones <lee@kernel.org>
Acked-for-MFD-by isn't a valid tag, scripts/checkpatch.pl should tell
you about it.
In general you may add a comment to a tag, like this:
Acked-by: Lee Jones <lee@kernel.org> # for MFD
In this particular case, the comment is unnecessary because Lee is the
MFD maintainer, hence his ack itself implies the MFD subsys.
--
Best regards,
Dmitry
next prev parent reply other threads:[~2023-07-18 4:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 7:53 [PATCH v7 0/5] " Benjamin Bara
2023-07-15 7:53 ` [PATCH v7 1/5] kernel/reboot: emergency_restart: set correct system_state Benjamin Bara
2023-07-15 7:53 ` [PATCH v7 2/5] i2c: core: run atomic i2c xfer when !preemptible Benjamin Bara
2023-11-13 1:12 ` Chris Morgan
2023-11-13 3:46 ` Dmitry Osipenko
2023-11-13 14:54 ` Chris Morgan
2023-11-13 15:48 ` Benjamin Bara
2023-11-14 18:43 ` Chris Morgan
2023-11-15 6:00 ` Dmitry Osipenko
2024-01-02 15:03 ` [PATCH v7 2/5] " Michael Walle
2024-01-02 21:02 ` Benjamin Bara
2024-01-03 9:20 ` Michael Walle
2024-01-03 12:49 ` Benjamin Bara
2024-01-03 15:07 ` Michael Walle
2023-07-15 7:53 ` [PATCH v7 3/5] kernel/reboot: add device to sys_off_handler Benjamin Bara
2023-07-15 7:53 ` [PATCH v7 4/5] mfd: tps6586x: use devm-based power off handler Benjamin Bara
2023-07-15 7:53 ` [PATCH v7 5/5] mfd: tps6586x: register restart handler Benjamin Bara
2023-07-18 4:46 ` Dmitry Osipenko [this message]
2023-07-19 8:22 ` Benjamin Bara
2023-07-19 8:44 ` Lee Jones
2023-07-19 18:22 ` Konstantin Ryabitsev
2023-07-28 10:33 ` [PATCH v7 0/5] " Lee Jones
2023-07-28 10:34 ` Lee Jones
2023-09-07 8:20 ` Benjamin Bara
2023-09-14 10:17 ` Lee Jones
2023-09-19 14:46 ` [GIT PULL] Immutable branch between MFD, I2C and Reboot due for the v6.7 merge window Lee Jones
2023-09-19 14:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=215679f1-a866-1e92-1bab-9c80918927a6@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=jonathanh@nvidia.com \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard.leitner@linux.dev \
--cc=treding@nvidia.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®