From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794386917; b=LNUm0GPFYPGmMI0x5js6/43623yFF6tbidHUjz2Rma9aYPsBtsR/xm3pYwLfalMkO4lj ZDawEjlaImcK4jTtzJw7h9RjG1dX8VtOpAC7Nn/QM4EVxPzHq7XlK4cvtNtfGZgjH1i7+ uLcYa5K+XxNngksT6YppR0+/CuSxHXVuzjvjnyLX5l7BQKtbt+ebFd9dwkoL/1zyKkWvy d+eVUnD1buMHaoWm6LtDPSnIkWiaG99PtDzbccXc4kJQkG+SmD9CHgCQMN+l7ifVEgohI 5nTs4/QgqsQecdfR27a7eQtKh5ZK58YDjGAr0clJh9k8yZdVcb9UDWyvMPVbLnigvJQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794386917; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:Autocrypt: In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Rspamd-Queue-Id: X-Spam-Level:X-Rspamd-Server:X-Rspamd-Action:X-Spam-Flag: X-Spamd-Result:X-Spam-Score; bh=QgoDMIFKi2tNr/3v23RGwhfeA7KQRN4J36T+PlHbRqY=; b=b4E8pPv+DKcCEw99emXsh9do2R3D5SRCuityWs4vfEMGX+1LzHORcjrjJfCaaEGDZGY5 thXQuuL0lLylyk0uiGiOLi4F7CkghQg6Ih79o2eWM9ea97nhXT5MGimkVzpE5QtEioX+0 KzFW1VlKyYfjTHYYe4l8FozQZMjyya12CS8fBWFSzrwJCUolirOwbUiHR5Y57zJAExCxP FrcYeLigKhrQleuvt/fIAEZsQH21WPpsY+lCozMzeIcmxp5Yg9G9RsR2msy88ccvhYbXj z0JHMHSvcSOtbVNiChrOgAmqEDDMiBJic4YwO/+eaQr67rvzoXR0L6ibM56xhzPGdHw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e6GlG5TO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pz6+SvTe; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e6GlG5TO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pz6+SvTe; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4252606A31C for ; Wed, 11 Nov 2026 08:48:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B4252606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e6GlG5TO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pz6+SvTe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e6GlG5TO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pz6+SvTe Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8975321D9B; Wed, 11 Nov 2026 08:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794386914; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QgoDMIFKi2tNr/3v23RGwhfeA7KQRN4J36T+PlHbRqY=; b=e6GlG5TOKRAzZovD2QKdoASLxw1J+FFJ1pTDyh2EYO5mVXtqabZedyO0pJm6RYMnqkH00V 95cWn52LuV0nQHjq9BJ3LznpRLfQijloJfjJ7UaSJMML7LBWtVIXNi26IIme5odVia2dfU 0lCxNbcHV1qTUwwRptvCgByTtJKLWX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794386914; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QgoDMIFKi2tNr/3v23RGwhfeA7KQRN4J36T+PlHbRqY=; b=pz6+SvTeWWrY4+Gw3pVy1I235ejePnS09tnwZjC0xKtBQYJTQbQGE3JWrNPguu18TVM223 94x7LHI1jEMG1MCg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=e6GlG5TO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=pz6+SvTe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794386914; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QgoDMIFKi2tNr/3v23RGwhfeA7KQRN4J36T+PlHbRqY=; b=e6GlG5TOKRAzZovD2QKdoASLxw1J+FFJ1pTDyh2EYO5mVXtqabZedyO0pJm6RYMnqkH00V 95cWn52LuV0nQHjq9BJ3LznpRLfQijloJfjJ7UaSJMML7LBWtVIXNi26IIme5odVia2dfU 0lCxNbcHV1qTUwwRptvCgByTtJKLWX8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794386914; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QgoDMIFKi2tNr/3v23RGwhfeA7KQRN4J36T+PlHbRqY=; b=pz6+SvTeWWrY4+Gw3pVy1I235ejePnS09tnwZjC0xKtBQYJTQbQGE3JWrNPguu18TVM223 94x7LHI1jEMG1MCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2D149134E5; Wed, 11 Nov 2026 08:48:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LcxxO+Er9GqbKgAAD6G6ig (envelope-from ); Wed, 11 Nov 2026 08:48:34 +0000 Message-ID: <215852e9-aafb-4ad2-93e8-afbadfd91fed@suse.de> Date: Wed, 11 Nov 2026 09:48:33 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] drm/sysfb: Copy damage outside the DIRTYFB ioctl To: Joseph Telaak , Javier Martinez Canillas Cc: Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20261110-sysfb-dirtyfb-v1-1-8571d455ccbe@telaak.dev> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20261110-sysfb-dirtyfb-v1-1-8571d455ccbe@telaak.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8975321D9B X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Flag: NO X-Spamd-Result: default: False [-13.50 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; XM_UA_NO_VERSION(0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_CC(0.00)[linux.intel.com,kernel.org,gmail.com,ffwll.ch,lists.freedesktop.org,vger.kernel.org]; DKIM_TRACE(0.00)[suse.de:+]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,telaak.dev:email,suse.com:url] X-Spam-Score: -13.50 Hi Am 11.11.26 um 02:37 schrieb Joseph Telaak: > The sysfb drivers implement DIRTYFB with drm_atomic_helper_dirtyfb(), > which runs a blocking commit. The commit waits for the framebuffer's > fences, so the ioctl doesn't return until the GPU has finished > rendering into the framebuffer. Yes, that's a requirement. > > Xorg's modesetting driver calls DIRTYFB from its main thread after > every frame. When a separate GPU renders for a sysfb display, X then > blocks for as long as the GPU takes to render the client's frame. With > a game running, X took a median of 1.85 s to answer a pointer query. > > Queue the damage instead and copy it from a worker. The worker still > waits for the fences, so nothing unfinished reaches the screen, and > damage that arrives while a copy is pending is merged into it. Pushing out work from the display update into a worker breaks feedback from driver back to compositors. Your compositor/Xorg/whatever needs to adapt to and deal with slow framerates. > > With this change, X answers in a median of 23 ms and the game's frame > rate is unchanged. Fix X if you really care. Best regards Thomas > > Signed-off-by: Joseph Telaak > --- > This is an RFC because I'm not sure DIRTYFB may return before the copy > is done. The fbdev emulation already defers its damage to a worker, > but userspace might rely on DIRTYFB being synchronous. If the approach > is fine, would you rather have it as a nonblocking mode of > drm_atomic_helper_dirtyfb() for all drivers instead of in sysfb? > > I hit this on an Intel Atom CE5300 board, where simpledrm drives the > display and the SoC's PowerVR SGX545 GPU renders with a driver I'm > writing (not upstream yet). I haven't reproduced it with an upstream > GPU driver, but nothing in the stall is specific to the GPU. > --- > drivers/gpu/drm/sysfb/corebootdrm.c | 3 + > drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 15 ++- > drivers/gpu/drm/sysfb/drm_sysfb_modeset.c | 154 ++++++++++++++++++++++++++++++ > drivers/gpu/drm/sysfb/efidrm.c | 3 + > drivers/gpu/drm/sysfb/ofdrm.c | 3 + > drivers/gpu/drm/sysfb/simpledrm.c | 3 + > drivers/gpu/drm/sysfb/vesadrm.c | 3 + > 7 files changed, 183 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sysfb/corebootdrm.c b/drivers/gpu/drm/sysfb/corebootdrm.c > index 853da9a..4ca359b 100644 > --- a/drivers/gpu/drm/sysfb/corebootdrm.c > +++ b/drivers/gpu/drm/sysfb/corebootdrm.c > @@ -206,6 +206,9 @@ static int corebootdrm_mode_config_init(struct corebootdrm_device *cdev, > int ret; > > ret = drmm_mode_config_init(dev); > + if (ret) > + return ret; > + ret = drm_sysfb_damage_init(sysfb); > if (ret) > return ret; > > diff --git a/drivers/gpu/drm/sysfb/drm_sysfb_helper.h b/drivers/gpu/drm/sysfb/drm_sysfb_helper.h > index 6dab27b..59c4064 100644 > --- a/drivers/gpu/drm/sysfb/drm_sysfb_helper.h > +++ b/drivers/gpu/drm/sysfb/drm_sysfb_helper.h > @@ -5,6 +5,8 @@ > > #include > #include > +#include > +#include > > #include