From: Arnd Bergmann <arnd@arndb.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Pravin Shelar <pshelar@nicira.com>,
"David S. Miller" <davem@davemloft.net>,
Thomas Graf <tgraf@suug.ch>,
Joe Stringer <joestringer@nicira.com>,
Paolo Abeni <pabeni@redhat.com>, Jarno Rajahalme <jarno@ovn.org>,
netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] openvswitch: call only into reachable nf-nat code
Date: Wed, 16 Mar 2016 14:56:51 +0100 [thread overview]
Message-ID: <2159518.ilphXU8bxQ@wuerfel> (raw)
In-Reply-To: <20160316132536.GA29550@salvia>
On Wednesday 16 March 2016 14:25:36 Pablo Neira Ayuso wrote:
> Not related with this patch, just a side note/recommendation.
>
> I understand this code just got into tree, and that this needs a bit
> work/iterations but this thing above is ugly, I wonder if there is a
> better way to avoid this.
>
> Probably with some modularization of the openvswitch code this will
> look better, I mean:
>
> 1) adding Kconfig switches to enable conntrack and NAT support to
> net/openvswitch/Kconfig.
>
> 2) Move the NAT code to the corresponding openvswitch/nat.c file.
>
> Just my two cents.
Yes, I think that would be good too. I also found that the driver
used to look like that but it was changed as part of f88f69dd17f1
("openvswitch: Remove conntrack Kconfig option.").
Arnd
next prev parent reply other threads:[~2016-03-16 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 12:47 Arnd Bergmann
2016-03-16 13:25 ` Pablo Neira Ayuso
2016-03-16 13:56 ` Arnd Bergmann [this message]
2016-03-17 2:54 ` [ovs-dev] " Joe Stringer
2016-03-17 3:09 ` Joe Stringer
2016-03-18 12:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2159518.ilphXU8bxQ@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=jarno@ovn.org \
--cc=joestringer@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=pshelar@nicira.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®