From: Randy Dunlap <rdunlap@infradead.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Akash Asthana <akashast@codeaurora.org>
Subject: Re: [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error
Date: Fri, 10 Jul 2020 16:40:03 -0700 [thread overview]
Message-ID: <215c3c59-e6f7-1721-76ca-993bbaf91356@infradead.org> (raw)
In-Reply-To: <CAL_Jsq+AWo6xP1vC1NubFcdWzoX4hVvSW4KGry1NhOXUieDrSA@mail.gmail.com>
On 7/10/20 8:28 AM, Rob Herring wrote:
> On Mon, Jun 29, 2020 at 10:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
>> by adding a stub for of_get_next_parent().
>>
>> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
>> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>
>
> Fixes tag?
Are linux-next hashes/tags stable?
Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Frank Rowand <frowand.list@gmail.com>
>> Cc: devicetree@vger.kernel.org
>> Cc: Andy Gross <agross@kernel.org>
>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Cc: linux-arm-msm@vger.kernel.org
>> ---
>> include/linux/of.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>
> I'm assuming this will be applied to the tree that introduced the problem.
>
> Acked-by: Rob Herring <robh@kernel.org>
>
Hi Akash,
Can you add this patch to your tree, as Rob indicated above?
thanks.
--
~Randy
next prev parent reply other threads:[~2020-07-10 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 16:43 Randy Dunlap
2020-06-29 19:25 ` Bjorn Andersson
2020-07-10 15:28 ` Rob Herring
2020-07-10 23:40 ` Randy Dunlap [this message]
2020-07-11 1:59 ` Stephen Rothwell
2020-07-11 19:41 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=215c3c59-e6f7-1721-76ca-993bbaf91356@infradead.org \
--to=rdunlap@infradead.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®