From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 580273264D4 for ; Tue, 19 May 2026 07:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175666; cv=none; b=UUX6Wwlnkw1kFauwAmsleVW8ldvLEpidAqUUYoz5rjDyp9XU6siRFuy0lMN0xpTHUMguixWODltzsJrWaSTQraE7azHF/OVIwpDkZDfg+urvyUAXnTasENAN7ttkCHXKLEzwk5V5DlJUHyJcYge7ecfm3Pq6RHxaJGaUxkh0T+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175666; c=relaxed/simple; bh=LhOb/VhVtbT23vwWG/Ihy9aq1QMQNsiWil+nFxjZD8o=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=mSJdo3ZuLGAPACT6VWYRzlm2oPb4/RXgW0z7+/zWyZe56C5IZs8MiZtu5eI2ddRDYSkt+drDKIxrOi0+4xxkac9Mk6YFTqKKUP6Slf835BWaOFNEUHMpyurwsHjtTXfz5/iC0UYiAP3lnCFAwnjfgbVaUHgDirUnbGYCnILNVbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g62S+Bko; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g62S+Bko" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488af96f6b2so34763995e9.0 for ; Tue, 19 May 2026 00:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779175664; x=1779780464; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=3zpUdooh7j5y1dGwvoNb/vpfm79eAZcPY2dZ8iHzeV8=; b=g62S+BkoH1tjxr67XbQ5ZmXFCKOQgyWS3JF32NDL4S624YxdM3eTseBZvJ/ZYruB4B ujlhfsvUlXyLPSZYoEmFlzpZIl8rZ1r2S8EBcIZJdEUfynZNF7az4s105TMtxRl4dWpI zB7UYXA3wIbzaM0bVvRFaiabcMuFvZle6uQ7h+JqL6kNM9a1NNoD4+vULGw0vaZMnakF 0MsfU24vbuJt1CuYiM35OR4zdvzpRGVDPrePmTpUMfbLLjy77G+lhD55vNGjuQEPPOvT goaoemXCGmC4QyUo3dmK0wukV6wxnPsSiQrG8Bcuxq4aTegvBOMofeI1POLKHuRkGkPa mc/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779175664; x=1779780464; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3zpUdooh7j5y1dGwvoNb/vpfm79eAZcPY2dZ8iHzeV8=; b=YAI/TjBzXU65R9YI7TC0hghBXla6R5p4nLFvZ4Kcfhnn/1uVMMvpxShnBqXbuQB+jP mxIQ/Sa7q/ZeLO0vDZg7m004z24bkUm+UXrqMd9xAIko9M83gyjS1ouluPSstcnDgYET K5j2m5bkWjW/AWCSnc4U/sWx18ZQ/Mh5Wu4QBRl6iALO3gmUNwvvMwVTkmiDqDoEZLGo Vmdcewr4XMgXSWsuQJTPAc6W3tA4xxbzoKiSGML0RL5WieNsW3EzKELNjhPdwfZRMOZA Jv9hnQwvyUDXuNpNaKnz5j4nXUCRZu7KWNN5qbNGY6PXGYGINg27gvqj7PbfiEf5cVaZ XCjQ== X-Forwarded-Encrypted: i=1; AFNElJ+WvbBvNDvJIYllSdTdv+krmxWG+VtU0d0XdIgCl5KoOCJV6mY/Dn7aS74zLlYv7hRjBeCsWpPu2LA72eA=@vger.kernel.org X-Gm-Message-State: AOJu0YwJMMTKtltBzcbWiCVyB2QxW8k0wdqNRKatb8RvUEPnQlUgZN+C Uzpw/Z65dAl8yGXo7tPUcmKUXLH2mI43yHX40m8y2K4UdaC1FbnB3c1NXudNbX6D/fk= X-Gm-Gg: Acq92OHfU5zoFT3IA4SvBPmKEzTdZhX4glzD9TnWTPHV9ejAHVUC7zXU247gSCirLMR 9oMHvyfUQt9KR5aeuIgYJouLC+cMI6cqrrRyhZVWZUTzX1/so1avSYIyVCleO5DiU2m3B+Ilurc ucZ1/fv2j7NfuKdgJxDJayrNNdBQid80hBTWOY0uefnEF+h37wyQqmD3gdW73Yaliq7LxBy/5MP dKyPgxNLja3WToP8lPg8IO0cyxgs6J0ImsVNDR/kuj5xbWFZgh0pPTiJLsi0ZMjTK368AWr6lC9 sTnmadWtMaz7o5jaY/l8Ua2N0ATh0eja7oFbTCMssIjqHxD4+Xna8rD5fRcSVTTriel4p/gkQHO UqP3B5GIR82m2cJpv+sPonVUCnmZoUHs/QoVjOd2lYGshXZtoQNeUHxDNmfYp9oskLQ3U0+rB7F DDfpG6LFTtQ+K5VPbu3KLJ6MtR8oSZxWD1ZStXnZLgEibcIY21FnAFjbHJkXLdo5JKSYPlDgOqs Qjq X-Received: by 2002:a05:600c:a406:b0:489:e126:b757 with SMTP id 5b1f17b1804b1-48fe63297b9mr233398525e9.25.1779175663120; Tue, 19 May 2026 00:27:43 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4c88495sm299805555e9.4.2026.05.19.00.27.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:27:42 -0700 (PDT) Message-ID: <21609bd9-7a94-41cc-bbe2-2478278b0497@linaro.org> Date: Tue, 19 May 2026 09:27:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 05/13] drm/meson: encoder_hdmi: Use CEC phys addr from display_info To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-6-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-6-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/18/26 21:47, Jonas Karlman wrote: > The dw-hdmi bridge detect() func now updates EDID for the connector. > Something that ensures that display_info.source_physical_address has an > updated CEC phys addr when the hpd_notify() func is called. > > Change to use display_info source_physical_address directly instead of > re-reading EDID to set the CEC phys addr at HPD interrupt. > > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_encoder_hdmi.c | 26 ++++------------------ > 1 file changed, 4 insertions(+), 22 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c > index 55c0601df3c6..1b9a1d9ed3d3 100644 > --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c > @@ -330,28 +330,10 @@ static void meson_encoder_hdmi_hpd_notify(struct drm_bridge *bridge, > if (!encoder_hdmi->cec_notifier) > return; > > - if (status == connector_status_connected) { > - const struct drm_edid *drm_edid; > - const struct edid *edid; > - > - drm_edid = drm_bridge_edid_read(encoder_hdmi->bridge.next_bridge, > - encoder_hdmi->connector); > - if (!drm_edid) > - return; > - > - /* > - * FIXME: The CEC physical address should be set using > - * cec_notifier_set_phys_addr(encoder_hdmi->cec_notifier, > - * connector->display_info.source_physical_address) from a path > - * that has read the EDID and called > - * drm_edid_connector_update(). > - */ > - edid = drm_edid_raw(drm_edid); > - > - cec_notifier_set_phys_addr_from_edid(encoder_hdmi->cec_notifier, edid); > - > - drm_edid_free(drm_edid); > - } else > + if (status == connector_status_connected) > + cec_notifier_set_phys_addr(encoder_hdmi->cec_notifier, > + connector->display_info.source_physical_address); > + else > cec_notifier_phys_addr_invalidate(encoder_hdmi->cec_notifier); > } > Reviewed-by: Neil Armstrong Thanks, Neil