From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbbJTJus (ORCPT ); Tue, 20 Oct 2015 05:50:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44389 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbbJTJup (ORCPT ); Tue, 20 Oct 2015 05:50:45 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <288f39ff7c8b0bc60693e338fc8f6cea9008d443.1445286755.git.sowmini.varadhan@oracle.com> References: <288f39ff7c8b0bc60693e338fc8f6cea9008d443.1445286755.git.sowmini.varadhan@oracle.com> To: Sowmini Varadhan Cc: dhowells@redhat.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, zohar@linux.vnet.ibm.com, David.Woodhouse@intel.com, steffen.klassert@secunet.com Subject: Re: [PATCH 1/2] crypto/x509: Fix unaligned access in x509_get_sig_params() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <21609.1445334638.1@warthog.procyon.org.uk> Date: Tue, 20 Oct 2015 10:50:38 +0100 Message-ID: <21610.1445334638@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sowmini Varadhan wrote: > x509_get_sig_params() has the same code pattern as the one in > pkcs7_verify() that is fixed by commit 62f57d05e287 ("crypto: pkcs7 - Fix > unaligned access in pkcs7_verify()") so apply a similar fix here: make > sure that desc is pointing at an algined value past the digest_size, > and take alignment values into consideration when doing kzalloc() > > Signed-off-by: Sowmini Varadhan Acked-by: David Howells