mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: 梁礼学 <lianglixuehao@126.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	David Miller <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Netdev <netdev@vger.kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v7] igb: Assign random MAC address instead of fail in case of invalid one
Date: Wed, 14 Dec 2022 18:02:53 +0800	[thread overview]
Message-ID: <216119AA-C362-445D-9F04-47AC2A15EC11@126.com> (raw)
In-Reply-To: <Y5l5pUKBW9DvHJAW@unreal>

hi Leon,

Currently this module parameter is only used for igb.
Is the more user-friendly way not to use module parameters?
just like other network card drivers, use random MAC. 
As I submitted [patch v3] before, link: 
https://lore.kernel.org/netdev/20220530105834.97175-1-lianglixuehao@126.com/

Or, can you suggest me how to do it more reasonable?

Thanks

> 2022年12月14日 15:22，Leon Romanovsky <leon@kernel.org> 写道：
> 
> On Tue, Dec 13, 2022 at 07:47:26AM +0000, Lixue Liang wrote:
>> From: Lixue Liang <lianglixue@greatwall.com.cn>
>> 
>> Add the module parameter "allow_invalid_mac_address" to control the
>> behavior. When set to true, a random MAC address is assigned, and the
>> driver can be loaded, allowing the user to correct the invalid MAC address.
>> 
>> Signed-off-by: Lixue Liang <lianglixue@greatwall.com.cn>
> 
> 
> I'm amused that we are in v7 version of module parameter.
> 
> NAK to any module driver parameter. If it is applicable to all drivers,
> please find a way to configure it to more user-friendly. If it is not,
> try to do the same as other drivers do.
> 
> Thanks


  reply	other threads:[~2022-12-14 10:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13  7:47 Lixue Liang
2022-12-13 19:22 ` Tony Nguyen
2022-12-14  7:22 ` Leon Romanovsky
2022-12-14 10:02   ` 梁礼学 [this message]
2022-12-14 16:51   ` Jakub Kicinski
2022-12-14 18:53     ` Leon Romanovsky
2022-12-14 20:50       ` Jakub Kicinski
2022-12-14 21:43         ` Heiner Kallweit
2022-12-14 23:17           ` Alexander Duyck
2022-12-15  3:24             ` 梁礼学
2022-12-15 15:49               ` Alexander H Duyck
2022-12-19 18:25             ` Jacob Keller
2022-12-18  8:41         ` Leon Romanovsky
2022-12-19 15:30           ` Alexander Duyck
2022-12-28  9:15             ` Leon Romanovsky
2022-12-30 16:17               ` Andrew Lunn
2022-12-14  1:12 Lixue Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=216119AA-C362-445D-9F04-47AC2A15EC11@126.com \
    --to=lianglixuehao@126.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®