From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA71C04A6A for ; Wed, 9 Aug 2023 13:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232831AbjHIN57 (ORCPT ); Wed, 9 Aug 2023 09:57:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232820AbjHIN55 (ORCPT ); Wed, 9 Aug 2023 09:57:57 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FD5D1BF2; Wed, 9 Aug 2023 06:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691589476; x=1723125476; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=CwDGqwd88thCoGdpEJAkv19uKXNI4W3xi+umzrTKwhQ=; b=DEO3aC09uiyK08Y+8JAClHNkzBSEvz8aflRxdfJ2oCZhrQovQNmdH1Kp hobjUymjzOYX99joPNXFwWcGgvXxvWhDf+y1JqU6DMp1IWskynOJUrILI luj6pW3TAEV5IwtTlLFRsOjIIRC56DIG51QpzB2QAYu9YqvFlfda+wBSI HNjv+Qo8ZYvmSgLTTmIlBrxlbPi6UPWAvshZQJaNuS28ymrKu+C2YT++X vpDLXDYjC3hdPUJuhsyPtYil1ro1Xt7MymBkJSWjxPsHqX0IzfDFTv3lV dbiKhzLGIy+w5MC58FKxZ8iKjfsSUasXmZj4AtCZgehI9cpA0KUxkwh4Y A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="373908212" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="373908212" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2023 06:57:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="761389587" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="761389587" Received: from cvogler-mobl1.ger.corp.intel.com ([10.252.40.229]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2023 06:57:53 -0700 Date: Wed, 9 Aug 2023 16:57:50 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Sui Jingfeng cc: Bjorn Helgaas , Dave Airlie , Daniel Vetter , linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org, LKML , Sui Jingfeng , Andi Shyti Subject: Re: [PATCH v2 01/11] PCI/VGA: Use unsigned type for the io_state variable In-Reply-To: <20230808223412.1743176-2-sui.jingfeng@linux.dev> Message-ID: <216235c1-d578-8f35-1f2-7f8ce59d2d7a@linux.intel.com> References: <20230808223412.1743176-1-sui.jingfeng@linux.dev> <20230808223412.1743176-2-sui.jingfeng@linux.dev> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-939066835-1691589475=:1846" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-939066835-1691589475=:1846 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Wed, 9 Aug 2023, Sui Jingfeng wrote: > From: Sui Jingfeng > > The io_state variable in the vga_arb_write() function is declared with > unsigned int type, while the vga_str_to_iostate() function takes 'int *' > type. To keep them consistent, this patch replaceis the third argument of > vga_str_to_iostate() function with 'unsigned int *' type. > > Reviewed-by: Andi Shyti > Signed-off-by: Sui Jingfeng > --- > drivers/pci/vgaarb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c > index 5a696078b382..c1bc6c983932 100644 > --- a/drivers/pci/vgaarb.c > +++ b/drivers/pci/vgaarb.c > @@ -77,7 +77,7 @@ static const char *vga_iostate_to_str(unsigned int iostate) > return "none"; > } > > -static int vga_str_to_iostate(char *buf, int str_size, int *io_state) > +static int vga_str_to_iostate(char *buf, int str_size, unsigned int *io_state) > { > /* we could in theory hand out locks on IO and mem > * separately to userspace but it can cause deadlocks */ Reviewed-by: Ilpo Järvinen -- i. --8323329-939066835-1691589475=:1846--