From: Evgeniy Polyakov <zbr@ioremap.net>
To: Levente Kurusa <levex@linux.com>, LKML <linux-kernel@vger.kernel.org>
Cc: GregKH <greg@kroah.com>
Subject: Re: [PATCH 4/4] w1: call put_device if device_register fails
Date: Sat, 14 Dec 2013 19:17:09 +0400 [thread overview]
Message-ID: <216611387034229@web23g.yandex.ru> (raw)
In-Reply-To: <1386962557-8899-5-git-send-email-levex@linux.com>
Hi
13.12.2013, 23:23, "Levente Kurusa" <levex@linux.com>:
> Currently, memsetting and kfreeing the device is bad behaviour.
> The device will have a reference count of 1 and hence can cause trouble
> because it has kfree'd. Proper way to handle a failed device_register
> is to call put_device right after it fails.
Looks good to me, thank you
Greg, please pull it into your treee
> Signed-off-by: Levente Kurusa <levex@linux.com>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
next prev parent reply other threads:[~2013-12-14 15:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 19:22 [PATCH 0/4] treewide: add missing put_device calls Levente Kurusa
2013-12-13 19:22 ` [PATCH 1/4] net: phy: call put_device on device_register() failure Levente Kurusa
2013-12-13 19:22 ` [PATCH 2/4] eisa: call put_device if device_register fails Levente Kurusa
2013-12-13 19:22 ` [PATCH 3/4] backlight: lcd: " Levente Kurusa
2013-12-13 19:22 ` [PATCH 4/4] w1: " Levente Kurusa
2013-12-14 15:17 ` Evgeniy Polyakov [this message]
2013-12-18 23:47 ` Greg KH
2013-12-23 15:37 ` Джамурахметов Рустафа
2013-12-23 15:38 ` Evgeniy Polyakov
2013-12-13 20:42 ` [PATCH 0/4] treewide: add missing put_device calls Bjorn Helgaas
2013-12-14 17:24 ` Greg Kroah-Hartman
2013-12-15 7:55 ` Levente Kurusa
2013-12-15 17:03 ` Greg Kroah-Hartman
2013-12-16 17:18 ` Levente Kurusa
2013-12-16 17:58 ` Greg Kroah-Hartman
2013-12-16 18:11 ` Levente Kurusa
2013-12-16 18:18 ` Greg Kroah-Hartman
2013-12-16 18:24 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=216611387034229@web23g.yandex.ru \
--to=zbr@ioremap.net \
--cc=greg@kroah.com \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome