From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752509AbbHMMhu (ORCPT ); Thu, 13 Aug 2015 08:37:50 -0400 Received: from gloria.sntech.de ([95.129.55.99]:52279 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbbHMMht (ORCPT ); Thu, 13 Aug 2015 08:37:49 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Linus Walleij Cc: Lin Huang , Doug Anderson , "open list:ARM/Rockchip SoC..." , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 2/2] pinctrl: rockchip: only enable gpio clock when it setting Date: Thu, 13 Aug 2015 14:37:36 +0200 Message-ID: <2167165.ooWgarx4Ov@diego> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <1439287924-6988-1-git-send-email-hl@rock-chips.com> <1439287924-6988-2-git-send-email-hl@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, Am Donnerstag, 13. August 2015, 14:24:28 schrieb Linus Walleij: > On Tue, Aug 11, 2015 at 12:12 PM, Lin Huang wrote: > > gpio can keep state even the clock disable, for save power > > consumption, only enable gpio clock when it setting > > > > Signed-off-by: Lin Huang > > Reviewed-by: Heiko Stuebner > > --- > > Changes in v5: > > -rebase patch > > Patch applied with Doug's test tags etc. did you also take the first patch? Aka bot should probably stay together (hence Stephen's Ack for the clock change), as the dynamically controlling the gpio clocks exposes the pclk_pd_pmu. Heiko