From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F553C352A1 for ; Mon, 4 Apr 2022 22:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382537AbiDDWJh (ORCPT ); Mon, 4 Apr 2022 18:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378948AbiDDQHQ (ORCPT ); Mon, 4 Apr 2022 12:07:16 -0400 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA75E13F42; Mon, 4 Apr 2022 09:05:16 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 8A62D41F28; Mon, 4 Apr 2022 16:05:11 +0000 (UTC) Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver To: Christoph Hellwig Cc: Sven Peter , Keith Busch , Jens Axboe , Sagi Grimberg , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> <20220324061620.GA12330@lst.de> <18f3a7e6-16d1-2037-90e7-1c0b1b2fbb1c@marcan.st> <20220404155924.GA9764@lst.de> From: Hector Martin Message-ID: <216d4bde-9463-a7c7-7d0a-57ea157aa280@marcan.st> Date: Tue, 5 Apr 2022 01:05:09 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20220404155924.GA9764@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: es-ES Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/04/2022 00.59, Christoph Hellwig wrote: > On Tue, Apr 05, 2022 at 12:57:33AM +0900, Hector Martin wrote: >> The kernel hard limit is 100-character lines, not 80-character lines. >> Maintainers for existing drivers are certainly free to stick to 80 chars >> if they like it that way, but I don't see why we should still be >> enforcing that for new code. See bdc48fa11e46. > > Because 100 is completely utterly unreadable if is not for individual > lines like strings, and that is actually how Linus stated it in CodingStyle. > > Your code as-is is completely unreadable and will not go into > drivers/nvme/ in that form. That line is 81 characters. I'm sure Sven doesn't mind fixing it, but "your code as-is is completely unreadable" seems uncalled for here, and rather unreasonable. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub