From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E838EC4167B for ; Wed, 6 Dec 2023 17:22:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378105AbjLFRW2 (ORCPT ); Wed, 6 Dec 2023 12:22:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjLFRW1 (ORCPT ); Wed, 6 Dec 2023 12:22:27 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FBE5D3; Wed, 6 Dec 2023 09:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=IkWMgsAMR6Agcl+tIup9tcwkstloKvFzTgKc+Se18o4=; b=RQcgTGxd0fkHmW8w72vKz8PFbJ Y8X3TmD3AkQNwxBUQRTuLgNTcXu67FlGWsrpztbt3tmqEOI09bjeNMWwCOUNMmhDbdyNAOV+mFYev MRYUF3gDx11dxuZZKgzUrk4kN9zHsm4QWw8w0oDBVed+fiy1md2mX9tMARmCY6WsP6F78g+OppKpp G0WgTEgIZee7+3SAQp7mWpAJCLKTrPGMVPS1Qgv8U4r+4zhYXqd0mBaQostTAJWLiPcagtWrz5oOE 9siZ7O4p8QCJScytyVupOY2jlJxTrFpyQeANQbKBccOPM5B8E8WxqrDWawa/CrA/l/WN26MZYxY3W aU33sHbA==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rAvbU-00AsZq-0P; Wed, 06 Dec 2023 17:22:32 +0000 Message-ID: <2172ccea-0749-44fa-942e-195333dacb62@infradead.org> Date: Wed, 6 Dec 2023 09:22:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency Content-Language: en-US To: Arnd Bergmann , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov Cc: Arnd Bergmann , Neil Armstrong , Bjorn Andersson , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231206123828.587065-1-arnd@kernel.org> From: Randy Dunlap In-Reply-To: <20231206123828.587065-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/6/23 04:38, Arnd Bergmann wrote: > From: Arnd Bergmann > > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed > here to avoid a build failure: > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] > Selected by [y]: > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register': > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init' > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add' > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init': > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register' > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit': > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister' > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE") > Signed-off-by: Arnd Bergmann Acked-by: Randy Dunlap Tested-by: Randy Dunlap Thanks. > --- > drivers/usb/typec/mux/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig > index 5120942f309d..818624f59120 100644 > --- a/drivers/usb/typec/mux/Kconfig > +++ b/drivers/usb/typec/mux/Kconfig > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver" > depends on I2C > depends on DRM || DRM=n > + depends on OF > select DRM_AUX_BRIDGE if DRM_BRIDGE > select REGMAP_I2C > help -- ~Randy