From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arvind Chauhan <arvind.chauhan@arm.com>,
Ips Gandhi <inderpal.s@samsung.com>, Pavel Machek <pavel@ucw.cz>,
Nishanth Menon <nm@ti.com>,
Chander Kashyap <chander.kashyap@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Amit Daniel Kachhap <amit.daniel@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Shawn Guo <shawn.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH Resend] driver/core: cpu: initialize opp table
Date: Thu, 22 May 2014 01:57:29 +0200 [thread overview]
Message-ID: <2173444.bOnmhZJafF@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpokaBo96h4axsntJz8b6q9VE7Z_GfQvfuQ85HEFi8r4V4w@mail.gmail.com>
On Tuesday, May 20, 2014 08:08:11 AM Viresh Kumar wrote:
> On 20 May 2014 02:43, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > What about
> >
> > if (error)
> > return error;
> >
> > and then you'd save an indentation level?
>
> Yes.
>
> > Anyway, I find adding of_node* stuff directly to the driver core this way
> > kind of disgusting as there still are platforms that don't use it.
> >
> > Can we have a call to a function that will change into an empty stub on such
> > platforms here, please?
>
> Okay. But can you explain a bit more about how and where those stubs
> would be implemented?
In a header file included by cpu.c. Something like
#if defined(CONFIG_OF) && defined(CONFIG_PM_OPP)
<function header>
#else
static inline <stub>
#endif
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-05-21 23:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 6:17 [PATCH 0/5] CPUFreq: Initialize CPU's OPP tables from core Viresh Kumar
2014-05-19 6:17 ` [PATCH 1/5] driver/core: cpu: initialize opp table Viresh Kumar
2014-05-19 6:29 ` [PATCH Resend] " Viresh Kumar
2014-05-19 21:13 ` Rafael J. Wysocki
2014-05-19 21:16 ` Rafael J. Wysocki
2014-05-20 2:38 ` Viresh Kumar
2014-05-20 2:38 ` Viresh Kumar
2014-05-21 23:57 ` Rafael J. Wysocki [this message]
2014-05-22 4:12 ` Viresh Kumar
2014-05-21 9:35 ` Sudeep Holla
2014-05-21 9:41 ` Viresh Kumar
2014-05-21 9:48 ` Sudeep Holla
2014-05-21 9:54 ` Viresh Kumar
2014-05-19 6:17 ` [PATCH 2/5] cpufreq: arm_big_little: don't " Viresh Kumar
2014-05-19 6:17 ` [PATCH 3/5] cpufreq: imx6q: " Viresh Kumar
2014-05-19 6:17 ` [PATCH 4/5] cpufreq: cpufreq-cpu0: " Viresh Kumar
2014-05-19 6:17 ` [PATCH 5/5] cpufreq: exynos5440: " Viresh Kumar
2014-05-21 8:59 ` [PATCH 0/5] CPUFreq: Initialize CPU's OPP tables from core Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2173444.bOnmhZJafF@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=amit.daniel@samsung.com \
--cc=arvind.chauhan@arm.com \
--cc=chander.kashyap@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=inderpal.s@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=shawn.guo@linaro.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®